Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191018232124.4126-1-rjones@gateworks.com> <20191021081945.o7knknxacm6uvd3c@pengutronix.de>
In-Reply-To: <20191021081945.o7knknxacm6uvd3c@pengutronix.de>
From:   Bobby Jones <rjones@gateworks.com>
Date:   Mon, 21 Oct 2019 11:30:16 -0700
Message-ID: <CALAE=UBqEShQ6REhqPEChpXX7-soi4w9vdEu8rO8QfqZqCBS8Q@mail.gmail.com>
Subject: Re: [PATCH] ARM: dt: add lsm9ds1 iio imu/magn support to gw553x
To:     Marco Felsch <m.felsch@pengutronix.de>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        NXP Linux Team <linux-imx@nxp.com>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        linux-arm-kernel@lists.infradead.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Oct 21, 2019 at 1:19 AM Marco Felsch <m.felsch@pengutronix.de> wrote:
>
> Hi Robert,
>
> same here, don't name it 'ARM: dt: ...' instead name it 'ARM: dts: imx:
> ventana: ..' or 'ARM: dts: imx: imx6qdl-gw553x: ..'.

Sorry about that, I'll follow that format from now on.
>
> On 19-10-18 16:21, Robert Jones wrote:
> > Add one node for the accel/gyro i2c device and another for the separate
> > magnetometer device in the lsm9ds1.
> >
> > Signed-off-by: Robert Jones <rjones@gateworks.com>
> > ---
> >  arch/arm/boot/dts/imx6qdl-gw553x.dtsi | 31 +++++++++++++++++++++++++++++++
> >  1 file changed, 31 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx6qdl-gw553x.dtsi b/arch/arm/boot/dts/imx6qdl-gw553x.dtsi
> > index a106689..55e6922 100644
> > --- a/arch/arm/boot/dts/imx6qdl-gw553x.dtsi
> > +++ b/arch/arm/boot/dts/imx6qdl-gw553x.dtsi
> > @@ -173,6 +173,25 @@
> >       pinctrl-0 = <&pinctrl_i2c2>;
> >       status = "okay";
> >
> > +     lsm9ds1_ag@6a {
> > +             compatible = "st,lsm9ds1-imu";
>
> Didn't found this compatible string.
So this is a compatible string for a driver that's being mainlined
now. The devicetree bindings for which has already been reviewed-by
Rob Herring as seen here:
https://www.spinics.net/lists/linux-iio/msg47297.html. If possible I'd
prefer to get this in the same kernel release so let me know if
there's anything else I can do to make that happen.

>
> > +             reg = <0x6a>;
> > +             st,drdy-int-pin = <1>;
> > +             pinctrl-names = "default";
> > +             pinctrl-0 = <&pinctrl_acc_gyro>;
> > +             interrupt-parent = <&gpio7>;
> > +             interrupts = <13 IRQ_TYPE_LEVEL_HIGH>;
> > +     };
> > +
> > +     lsm9ds1_m@1c {
> > +             compatible = "st,lsm9ds1-magn";
> > +             reg = <0x1c>;
>
> Nodes are sorted according their i2c-addresses.
>
I'll resubmit with that change, thanks!
- Bobby

> Regards,
>   Marco
>
> > +             pinctrl-names = "default";
> > +             pinctrl-0 = <&pinctrl_mag>;
> > +             interrupt-parent = <&gpio1>;
> > +             interrupts = <2 IRQ_TYPE_EDGE_RISING>;
> > +     };
> > +
> >       ltc3676: pmic@3c {
> >               compatible = "lltc,ltc3676";
> >               reg = <0x3c>;
> > @@ -462,6 +481,18 @@
> >               >;
> >       };
> >
> > +     pinctrl_acc_gyro: acc_gyrogrp {
> > +             fsl,pins = <
> > +                     MX6QDL_PAD_GPIO_18__GPIO7_IO13          0x1b0b0
> > +             >;
> > +     };
> > +
> > +     pinctrl_mag: maggrp {
> > +             fsl,pins = <
> > +                     MX6QDL_PAD_GPIO_2__GPIO1_IO02           0x1b0b0
> > +             >;
> > +     };
> > +
> >       pinctrl_pps: ppsgrp {
> >               fsl,pins = <
> >                       MX6QDL_PAD_ENET_RXD1__GPIO1_IO26        0x1b0b1
> > --
> > 2.9.2
> >
> >
> >
>
> --
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |