Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191008124254.2144-1-benjamin.gaignard@st.com>
In-Reply-To: <20191008124254.2144-1-benjamin.gaignard@st.com>
From:   Benjamin Gaignard <benjamin.gaignard@linaro.org>
Date:   Mon, 21 Oct 2019 20:56:25 +0200
Message-ID: <CA+M3ks6TxRH4XOSn6=m16-f1RVHPuXeXtanruqEmRq2KmmCJuw@mail.gmail.com>
Subject: Re: [PATCH v2] drm: atomic helper: fix W=1 warnings
To:     Benjamin Gaignard <benjamin.gaignard@st.com>
Cc:     David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
        =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= <ville.syrjala@linux.intel.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        ML dri-devel <dri-devel@lists.freedesktop.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Le mer. 9 oct. 2019 =C3=A0 09:13, Benjamin Gaignard
<benjamin.gaignard@st.com> a =C3=A9crit :
>
> Few for_each macro set variables that are never used later which led
> to generate unused-but-set-variable warnings.
> Add (void)(foo) inside the macros to remove these warnings
>

Gentle ping,
Thanks,
Benjamin

> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
> ---
>  include/drm/drm_atomic.h | 17 ++++++++++++++---
>  1 file changed, 14 insertions(+), 3 deletions(-)
>
> diff --git a/include/drm/drm_atomic.h b/include/drm/drm_atomic.h
> index 927e1205d7aa..b6c73fd9f55a 100644
> --- a/include/drm/drm_atomic.h
> +++ b/include/drm/drm_atomic.h
> @@ -693,6 +693,7 @@ void drm_state_dump(struct drm_device *dev, struct dr=
m_printer *p);
>              (__i)++)                                                    =
       \
>                 for_each_if ((__state)->connectors[__i].ptr &&           =
       \
>                              ((connector) =3D (__state)->connectors[__i].=
ptr,     \
> +                            (void)(connector) /* Only to avoid unused-bu=
t-set-variable warning */, \
>                              (old_connector_state) =3D (__state)->connect=
ors[__i].old_state,      \
>                              (new_connector_state) =3D (__state)->connect=
ors[__i].new_state, 1))
>
> @@ -714,6 +715,7 @@ void drm_state_dump(struct drm_device *dev, struct dr=
m_printer *p);
>              (__i)++)                                                    =
       \
>                 for_each_if ((__state)->connectors[__i].ptr &&           =
       \
>                              ((connector) =3D (__state)->connectors[__i].=
ptr,     \
> +                            (void)(connector) /* Only to avoid unused-bu=
t-set-variable warning */, \
>                              (old_connector_state) =3D (__state)->connect=
ors[__i].old_state, 1))
>
>  /**
> @@ -734,7 +736,9 @@ void drm_state_dump(struct drm_device *dev, struct dr=
m_printer *p);
>              (__i)++)                                                    =
       \
>                 for_each_if ((__state)->connectors[__i].ptr &&           =
       \
>                              ((connector) =3D (__state)->connectors[__i].=
ptr,     \
> -                            (new_connector_state) =3D (__state)->connect=
ors[__i].new_state, 1))
> +                            (void)(connector) /* Only to avoid unused-bu=
t-set-variable warning */, \
> +                            (new_connector_state) =3D (__state)->connect=
ors[__i].new_state, \
> +                            (void)(new_connector_state) /* Only to avoid=
 unused-but-set-variable warning */, 1))
>
>  /**
>   * for_each_oldnew_crtc_in_state - iterate over all CRTCs in an atomic u=
pdate
> @@ -754,7 +758,9 @@ void drm_state_dump(struct drm_device *dev, struct dr=
m_printer *p);
>              (__i)++)                                                   \
>                 for_each_if ((__state)->crtcs[__i].ptr &&               \
>                              ((crtc) =3D (__state)->crtcs[__i].ptr,      =
 \
> +                             (void)(crtc) /* Only to avoid unused-but-se=
t-variable warning */, \
>                              (old_crtc_state) =3D (__state)->crtcs[__i].o=
ld_state, \
> +                            (void)(old_crtc_state) /* Only to avoid unus=
ed-but-set-variable warning */, \
>                              (new_crtc_state) =3D (__state)->crtcs[__i].n=
ew_state, 1))
>
>  /**
> @@ -793,7 +799,9 @@ void drm_state_dump(struct drm_device *dev, struct dr=
m_printer *p);
>              (__i)++)                                                   \
>                 for_each_if ((__state)->crtcs[__i].ptr &&               \
>                              ((crtc) =3D (__state)->crtcs[__i].ptr,      =
 \
> -                            (new_crtc_state) =3D (__state)->crtcs[__i].n=
ew_state, 1))
> +                            (void)(crtc) /* Only to avoid unused-but-set=
-variable warning */, \
> +                            (new_crtc_state) =3D (__state)->crtcs[__i].n=
ew_state, \
> +                            (void)(new_crtc_state) /* Only to avoid unus=
ed-but-set-variable warning */, 1))
>
>  /**
>   * for_each_oldnew_plane_in_state - iterate over all planes in an atomic=
 update
> @@ -813,6 +821,7 @@ void drm_state_dump(struct drm_device *dev, struct dr=
m_printer *p);
>              (__i)++)                                                   \
>                 for_each_if ((__state)->planes[__i].ptr &&              \
>                              ((plane) =3D (__state)->planes[__i].ptr,    =
 \
> +                             (void)(plane) /* Only to avoid unused-but-s=
et-variable warning */, \
>                               (old_plane_state) =3D (__state)->planes[__i=
].old_state,\
>                               (new_plane_state) =3D (__state)->planes[__i=
].new_state, 1))
>
> @@ -873,7 +882,9 @@ void drm_state_dump(struct drm_device *dev, struct dr=
m_printer *p);
>              (__i)++)                                                   \
>                 for_each_if ((__state)->planes[__i].ptr &&              \
>                              ((plane) =3D (__state)->planes[__i].ptr,    =
 \
> -                             (new_plane_state) =3D (__state)->planes[__i=
].new_state, 1))
> +                             (void)(plane) /* Only to avoid unused-but-s=
et-variable warning */, \
> +                             (new_plane_state) =3D (__state)->planes[__i=
].new_state, \
> +                             (void)(new_plane_state) /* Only to avoid un=
used-but-set-variable warning */, 1))
>
>  /**
>   * for_each_oldnew_private_obj_in_state - iterate over all private objec=
ts in an atomic update
> --
> 2.15.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel