Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 1/3] power_supply: Add additional health properties to the
 header
To:     Sebastian Reichel <sre@kernel.org>
CC:     <linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20190930143137.21624-1-dmurphy@ti.com>
 <20191020122510.4llflz7s2kogcdbf@earth.universe>
From:   Dan Murphy <dmurphy@ti.com>
Message-ID: <b354bd2e-3fd8-eef9-6609-75d09210e745@ti.com>
Date:   Mon, 21 Oct 2019 14:35:15 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <20191020122510.4llflz7s2kogcdbf@earth.universe>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Sebastian

On 10/20/19 7:25 AM, Sebastian Reichel wrote:
> Hi,
>
> On Mon, Sep 30, 2019 at 09:31:35AM -0500, Dan Murphy wrote:
>> Add HEALTH_WARM, HEALTH_COOL and HEALTH_HOT to the health enum.
> You used OVERHEAT instead of HOT in the implementation,
> which makes sense to me, so please drop HOT here. Also
> this needs to be documented in the ABI documentation:

Hmm.? To me OVERHEAT and HOT can mean two different things.? I will 
check the implementation but I would

prefer to use HOT.

If a battery or charger is HOT that may be expected to be within the 
heat limits of the device being monitored but that it is hot.

Overheating means the device is above the expected upper thermal limit.? 
Or over the heat limit.

The user may want to take action within the hot range to cool the device 
or may expect the device to run hot without over heating.


> Documentation/ABI/testing/sysfs-class-power

ACK

Dan