Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] scsi: lpfc: Honor module parameter lpfc_use_adisc
To:     Daniel Wagner <dwagner@suse.de>, linux-scsi@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org,
        James Smart <james.smart@broadcom.com>,
        Dick Kennedy <dick.kennedy@broadcom.com>
References: <20191021100542.24136-1-dwagner@suse.de>
From:   James Smart <james.smart@broadcom.com>
Message-ID: <3956fdcf-4537-d9c1-74d4-6e937eed05e3@broadcom.com>
Date:   Mon, 21 Oct 2019 13:05:48 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <20191021100542.24136-1-dwagner@suse.de>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 10/21/2019 3:05 AM, Daniel Wagner wrote:
> The initial lpfc_desc_set_adisc implementation dea3101e0a5c ("lpfc:
> add Emulex FC driver version 8.0.28") enabled ADISC if
>
> 	cfg_use_adisc && RSCN_MODE && FCP_2_DEVICE
>
> In commit 92d7f7b0cde3 ("[SCSI] lpfc: NPIV: add NPIV support on top of
> SLI-3") this changed to
>
> 	(cfg_use_adisc && RSC_MODE) || FCP_2_DEVICE
>
> and later in ffc954936b13 ("[SCSI] lpfc 8.3.13: FC Discovery Fixes and
> enhancements.") to
>
> 	(cfg_use_adisc && RSC_MODE) || (FCP_2_DEVICe && FCP_TARGET)
>
> A customer reports that after a Devlos, an ADISC failure is logged. It
> turns out the ADISC flag is set even the user explicitly set
> lpfc_use_adisc = 0.
>
> [Sat Dec 22 22:55:58 2018] lpfc 0000:82:00.0: 2:(0):0203 Devloss timeout on WWPN 50:01:43:80:12:8e:40:20 NPort x05df00 Data: x82000000 x8 xa
> [Sat Dec 22 23:08:20 2018] lpfc 0000:82:00.0: 2:(0):2755 ADISC failure DID:05DF00 Status:x9/x70000
>
> Fixes: 92d7f7b0cde3 ("[SCSI] lpfc: NPIV: add NPIV support on top of SLI-3")
> Cc: James Smart <James.Smart@emulex.com>
> Cc: Alex Iannicelli <alex.iannicelli@emulex.com>
> Signed-off-by: Daniel Wagner <dwagner@suse.de>
> ---
> Hi,
>
> Unfortunatly, I don't really know all the procotols involved. So this
> is just a rough guess what is wrong.
>
> Thanks,
> Daniel
>
>   drivers/scsi/lpfc/lpfc_nportdisc.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_nportdisc.c b/drivers/scsi/lpfc/lpfc_nportdisc.c
> index cc6b1b0bae83..d27ae84326df 100644
> --- a/drivers/scsi/lpfc/lpfc_nportdisc.c
> +++ b/drivers/scsi/lpfc/lpfc_nportdisc.c
> @@ -940,9 +940,9 @@ lpfc_disc_set_adisc(struct lpfc_vport *vport, struct lpfc_nodelist *ndlp)
>   
>   	if (!(vport->fc_flag & FC_PT2PT)) {
>   		/* Check config parameter use-adisc or FCP-2 */
> -		if ((vport->cfg_use_adisc && (vport->fc_flag & FC_RSCN_MODE)) ||
> +		if (vport->cfg_use_adisc && ((vport->fc_flag & FC_RSCN_MODE) ||
>   		    ((ndlp->nlp_fcp_info & NLP_FCP_2_DEVICE) &&
> -		     (ndlp->nlp_type & NLP_FCP_TARGET))) {
> +		     (ndlp->nlp_type & NLP_FCP_TARGET)))) {
>   			spin_lock_irq(shost->host_lock);
>   			ndlp->nlp_flag |= NLP_NPR_ADISC;
>   			spin_unlock_irq(shost->host_lock);

Looks good.

Reviewed-by: James Smart <james.smart@broadcom.com>

Thank You

-- james