Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp4958140ybg; Mon, 21 Oct 2019 17:50:26 -0700 (PDT) X-Google-Smtp-Source: APXvYqzGZWoHZIVVg68v/HoEaalTajHvElpcDj0sRBhUHVQwUqe0lXvOdKJQZaHZc8gj9jbTOn0F X-Received: by 2002:a50:e71a:: with SMTP id a26mr27874619edn.265.1571705426354; Mon, 21 Oct 2019 17:50:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571705426; cv=none; d=google.com; s=arc-20160816; b=XazbH1926B1mWdEeTLENWYVzPvW8XyXvVhsIogKXjbSbkz8vAmomkwuT6mbg80xPh0 cJYYvmYvCw1Jc111Vk15JGAuYHlGl8qNLLnmvfb0gkOmgUGWjYvrBoxyRU1+1Wr1jXEg J77QGGD54080bSOE4ShLUTzPGHJBUWrwI9vXU8WALjLSCvpPLAnc5Bq7/g3b9jc40I7P 5Bd8NexgXWPnFkg6NQ5e+CZjNe7UJK56CPw16JuxKzM4VdhXEhvFoyietJ40RMa8m3SQ 2kdqz80Djas4FwCIp8aRXBJ0j3IylHD3u0AczF5P9hDYNwxXmwoIoL3Rix1ZNHOj4qMd rH2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=9ZxBVNQ9Bd3ja+GyYsGolEdFXPVAh5PHrwO5UMmiKd0=; b=dEMIkzczQF31TIkG9qULbXwU4uZ9Y2Rzk55nLSW+/k0Z6rDXCoU6HpYmwyrAB+NYV3 KQzJaK9ZBB7G3BW0f65G0kZTr5kFLpf97QAYBZu4IyyGfxpBNRhcUhkJePll6opYnF88 apjDiyhDujJWGnZztThpyGh31kxljMQwXqIm4HIP0VnPyn3F6ikor5DC9Wu0j7SaxBlm 1EPMyBlusl4AmUlR7EUXuK2iCK8ynFYIGDdtRnKATHoX05x6Ksi4NzUzL4jcD0fN53US u1fAz8jIN2TxAKXY/ad944QrLSaGE6ILdVzWgXbt1EqS0lcuXaNYNPENv5A6qh9t3weq bC+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@netronome-com.20150623.gappssmtp.com header.s=20150623 header.b=Ax5udvJ6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z15si3810924edd.8.2019.10.21.17.50.02; Mon, 21 Oct 2019 17:50:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@netronome-com.20150623.gappssmtp.com header.s=20150623 header.b=Ax5udvJ6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730460AbfJVAse (ORCPT + 99 others); Mon, 21 Oct 2019 20:48:34 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:45080 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727953AbfJVAsd (ORCPT ); Mon, 21 Oct 2019 20:48:33 -0400 Received: by mail-pf1-f196.google.com with SMTP id b4so587175pfr.12 for ; Mon, 21 Oct 2019 17:48:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=9ZxBVNQ9Bd3ja+GyYsGolEdFXPVAh5PHrwO5UMmiKd0=; b=Ax5udvJ6yIw/qGB4F3BAhXGmaN8F2sVHDpUS8haKtrzzK5yJOgI3GtcC/lbYjuaosH /qGDiiiBpxurUX7vnWLZ78Ds48BgOiRgiBQqA2Uri0kx8wTnkQX/Sl6cjpl/i8AXWvJy 5Do0YGaQUKogPeKHD3mlCqId25gBU7hNyBc+F3mNEGmIpisGA2NbXI41J1kKSSbdyvb5 xaH/TITDFZlsfvj7pLG9UiE6Z+5POwJojnlxIH038ae/zfGvf/LSb3VFVyTkm8Wc0qo6 MAc5F1AZrX1JYrjchag9BH+WIeyDUMzZmNHrCt0myZ3XMhGBRZw4/8WMGf1r0GPGCmTk 5Z9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=9ZxBVNQ9Bd3ja+GyYsGolEdFXPVAh5PHrwO5UMmiKd0=; b=bK3dR3EsBMp8dmOOGAtjQ+pc4R+WTVShzJ/tiMDjoYyp3052lZvDF/6uWaI+wZA4NY QYTORIcqGCv/KeowhFspQhp9Rn2Pz6OBtINXRtwY/DTIsH0u6GO6jIaLb7W9olFZR4Ur Zo9A5ehqjxFEtOj9x0q2QS+WBYAGv88CtRzPVckQsmvvzJ118UPg+1m9yKMhL8Ptrc8+ +vxUtXw85IrLm4l79C+qZv1aPhtPZjABjkL+dxORFrvxlVWJV2UZRO2OQolgwWwz3KDT 9isE33ihgoI1NG+4tmNssjgVopk5T/pjYPj7jftJiN35+t2ydWtshB8hjAlB53NYXLmI UX+g== X-Gm-Message-State: APjAAAWxZXjHQJU5HQC4OERQM04+KC8X4lTa9YVNi8bUdeq06wGtEQWH /fJuENefhiW+TEC4QskYvEYnVg== X-Received: by 2002:a62:5fc3:: with SMTP id t186mr228439pfb.238.1571705313197; Mon, 21 Oct 2019 17:48:33 -0700 (PDT) Received: from cakuba.netronome.com (c-73-202-202-92.hsd1.ca.comcast.net. [73.202.202.92]) by smtp.gmail.com with ESMTPSA id f17sm25360301pgd.8.2019.10.21.17.48.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Oct 2019 17:48:32 -0700 (PDT) Date: Mon, 21 Oct 2019 17:48:29 -0700 From: Jakub Kicinski To: Arnd Bergmann , Jason Baron Cc: Shannon Nelson , Pensando Drivers , "David S. Miller" , Andrew Morton , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dynamic_debug: provide dynamic_hex_dump stub Message-ID: <20191021174829.065f9b66@cakuba.netronome.com> In-Reply-To: <20190918195607.2080036-1-arnd@arndb.de> References: <20190918195607.2080036-1-arnd@arndb.de> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 18 Sep 2019 21:55:11 +0200, Arnd Bergmann wrote: > The ionic driver started using dymamic_hex_dump(), but > that is not always defined: > > drivers/net/ethernet/pensando/ionic/ionic_main.c:229:2: error: implicit declaration of function 'dynamic_hex_dump' [-Werror,-Wimplicit-function-declaration] > > Add a dummy implementation to use when CONFIG_DYNAMIC_DEBUG > is disabled, printing nothing. > > Fixes: 938962d55229 ("ionic: Add adminq action") > Signed-off-by: Arnd Bergmann Looks like this still doesn't appear in any tree, after a month (judging by linux-next). Can we take this into the networking tree? Please scream at me if I'm missing something or this would not be appropriate.