Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH RFC] net: vlan: reverse 4 bytes of vlan header when
 setting initial MTU
To:     David Laight <David.Laight@ACULAB.COM>,
        "davem@davemloft.net" <davem@davemloft.net>
CC:     "dsahern@gmail.com" <dsahern@gmail.com>,
        "jiri@mellanox.com" <jiri@mellanox.com>,
        "allison@lohutok.net" <allison@lohutok.net>,
        "mmanning@vyatta.att-mail.com" <mmanning@vyatta.att-mail.com>,
        "petrm@mellanox.com" <petrm@mellanox.com>,
        "dcaratti@redhat.com" <dcaratti@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <1571660763-117936-1-git-send-email-linyunsheng@huawei.com>
 <8f07f4aad98e44358b92e1e340df131f@AcuMS.aculab.com>
From:   Yunsheng Lin <linyunsheng@huawei.com>
Message-ID: <710cc020-f411-38ad-a9c4-3f44957645f5@huawei.com>
Date:   Tue, 22 Oct 2019 09:28:40 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.0
MIME-Version: 1.0
In-Reply-To: <8f07f4aad98e44358b92e1e340df131f@AcuMS.aculab.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2019/10/21 22:46, David Laight wrote:
> From: Yunsheng Lin
>> Sent: 21 October 2019 13:26
>> Currently the MTU of vlan netdevice is set to the same MTU
>> of the lower device, which requires the underlying device
>> to handle it as the comment has indicated:
>>
>> 	/* need 4 bytes for extra VLAN header info,
>> 	 * hope the underlying device can handle it.
>> 	 */
>> 	new_dev->mtu = real_dev->mtu;
>>
>> Currently most of the physical netdevs seems to handle above
>> by reversing 2 * VLAN_HLEN for L2 packet len.
> 
> s/reverse/reserve/g

Thanks.

> 
> -
> Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
> Registration No: 1397386 (Wales)
> 
> 
> .
>