Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v3 1/5] net: ag71xx: port to phylink
To:     Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc:     Mark Rutland <mark.rutland@arm.com>, Andrew Lunn <andrew@lunn.ch>,
        Jay Cliburn <jcliburn@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        devicetree@vger.kernel.org, James Hogan <jhogan@kernel.org>,
        linux-kernel@vger.kernel.org, Ralf Baechle <ralf@linux-mips.org>,
        "David S. Miller" <davem@davemloft.net>,
        Paul Burton <paul.burton@mips.com>,
        Rob Herring <robh+dt@kernel.org>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Chris Snook <chris.snook@gmail.com>, netdev@vger.kernel.org,
        linux-mips@vger.kernel.org,
        Vivien Didelot <vivien.didelot@gmail.com>
References: <20191021053811.19818-1-o.rempel@pengutronix.de>
 <20191021053811.19818-2-o.rempel@pengutronix.de>
 <20191021222122.GM25745@shell.armlinux.org.uk>
From:   Oleksij Rempel <o.rempel@pengutronix.de>
Message-ID: <bf684928-0800-69df-f5cd-5d1db6958804@pengutronix.de>
Date:   Tue, 22 Oct 2019 07:12:16 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <20191021222122.GM25745@shell.armlinux.org.uk>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 22.10.19 00:21, Russell King - ARM Linux admin wrote:
> On Mon, Oct 21, 2019 at 07:38:07AM +0200, Oleksij Rempel wrote:
>> +static void ag71xx_mac_validate(struct phylink_config *config,
>> +			    unsigned long *supported,
>> +			    struct phylink_link_state *state)
>>   {
>> -	struct ag71xx *ag = netdev_priv(ndev);
>> +	__ETHTOOL_DECLARE_LINK_MODE_MASK(mask) = { 0, };
>> +
>> +	if (state->interface != PHY_INTERFACE_MODE_NA &&
>> +	    state->interface != PHY_INTERFACE_MODE_GMII &&
>> +	    state->interface != PHY_INTERFACE_MODE_MII) {
>> +		bitmap_zero(supported, __ETHTOOL_LINK_MODE_MASK_NBITS);
>> +		return;
>> +	}
>> +
>> +	phylink_set(mask, MII);
>> +
>> +	/* flow control is not supported */
>> +
>> +	phylink_set(mask, 10baseT_Half);
>> +	phylink_set(mask, 10baseT_Full);
>> +	phylink_set(mask, 100baseT_Half);
>> +	phylink_set(mask, 100baseT_Full);
>>   
>> -	ag71xx_link_adjust(ag, true);
>> +	if (state->interface == PHY_INTERFACE_MODE_NA &&
>> +	    state->interface == PHY_INTERFACE_MODE_GMII) {
> 
> This is always false.

... I shame to myself :(

> Apart from that, from just reading the patch I have no further concerns.

ok. thx!

Kind regards,
Oleksij Rempel

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |