Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Jani Nikula <jani.nikula@linux.intel.com>
To:     Patrik Jakobsson <patrik.r.jakobsson@gmail.com>,
        dri-devel@lists.freedesktop.org,
        Thierry Reding <treding@nvidia.com>
Cc:     David Airlie <airlied@linux.ie>, linux-kernel@vger.kernel.org,
        Sean Paul <sean@poorly.run>
Subject: Re: [PATCH] drm/scdc: Fix typo in bit definition of SCDC_STATUS_FLAGS
In-Reply-To: <20191016123342.19119-1-patrik.r.jakobsson@gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
References: <20191016123342.19119-1-patrik.r.jakobsson@gmail.com>
Date:   Tue, 22 Oct 2019 11:16:51 +0300
Message-ID: <87lftdfb4c.fsf@intel.com>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 16 Oct 2019, Patrik Jakobsson <patrik.r.jakobsson@gmail.com> wrote:
> Fix typo where bits got compared (x < y) instead of shifted (x << y).

Fixes: 3ad33ae2bc80 ("drm: Add SCDC helpers")
Cc: Thierry Reding <treding@nvidia.com>

> Signed-off-by: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
> ---
>  include/drm/drm_scdc_helper.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/drm/drm_scdc_helper.h b/include/drm/drm_scdc_helper.h
> index f92eb2094d6b..6a483533aae4 100644
> --- a/include/drm/drm_scdc_helper.h
> +++ b/include/drm/drm_scdc_helper.h
> @@ -50,9 +50,9 @@
>  #define  SCDC_READ_REQUEST_ENABLE (1 << 0)
>  
>  #define SCDC_STATUS_FLAGS_0 0x40
> -#define  SCDC_CH2_LOCK (1 < 3)
> -#define  SCDC_CH1_LOCK (1 < 2)
> -#define  SCDC_CH0_LOCK (1 < 1)
> +#define  SCDC_CH2_LOCK (1 << 3)
> +#define  SCDC_CH1_LOCK (1 << 2)
> +#define  SCDC_CH0_LOCK (1 << 1)
>  #define  SCDC_CH_LOCK_MASK (SCDC_CH2_LOCK | SCDC_CH1_LOCK | SCDC_CH0_LOCK)
>  #define  SCDC_CLOCK_DETECT (1 << 0)

-- 
Jani Nikula, Intel Open Source Graphics Center