Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 22 Oct 2019 11:50:10 +0100
From:   Jonathan Cameron <jic23@kernel.org>
To:     Martin Kepplinger <martink@posteo.de>
Cc:     Andrey Smirnov <andrew.smirnov@gmail.com>,
        linux-iio@vger.kernel.org, Chris Healy <cphealy@gmail.com>,
        Hartmut Knaack <knaack.h@gmx.de>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: mma8452: Re-word 'interrupt-names'
 description
Message-ID: <20191022115010.7957744e@archlinux>
In-Reply-To: <1a1bdf10-2505-6baf-8030-ce5e0e2b55a9@posteo.de>
References: <20191022035626.13002-1-andrew.smirnov@gmail.com>
        <1a1bdf10-2505-6baf-8030-ce5e0e2b55a9@posteo.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 22 Oct 2019 10:43:09 +0200
Martin Kepplinger <martink@posteo.de> wrote:

> On 22.10.19 05:56, Andrey Smirnov wrote:
> > Current wording in the binding documentation doesn't make it 100%
> > clear that only one of "INT1" and "INT2" will ever be used by the
> > driver and that specifying both has no advantages. Re-word it to make
> > this aspect a bit more explicit.

=46rom a quick glance at the datasheet, it appears that the hardware
is capable of routing different interrupts to different pins, even
if the driver does not do so.

CTRL_REG5 has 6 different bits to set whether particular blocks have
their interrupt routed to INT1 or INT2, so it appears to be possible
to send some each way.
=20
A binding is for the hardware not the driver, so if I'm right about this
the current text is correct and should be left alone.

Thanks,

Jonathan

> >=20
> > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> > Cc: Chris Healy <cphealy@gmail.com>
> > Cc: Jonathan Cameron <jic23@kernel.org>
> > Cc: Hartmut Knaack <knaack.h@gmx.de>
> > Cc: Lars-Peter Clausen <lars@metafoo.de>
> > Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
> > Cc: linux-iio@vger.kernel.org
> > Cc: devicetree@vger.kernel.org
> > Cc: linux-kernel@vger.kernel.org
> > ---
> >  Documentation/devicetree/bindings/iio/accel/mma8452.txt | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >=20
> > diff --git a/Documentation/devicetree/bindings/iio/accel/mma8452.txt b/=
Documentation/devicetree/bindings/iio/accel/mma8452.txt
> > index e132394375a1..b27b6bee9eb6 100644
> > --- a/Documentation/devicetree/bindings/iio/accel/mma8452.txt
> > +++ b/Documentation/devicetree/bindings/iio/accel/mma8452.txt
> > @@ -17,7 +17,7 @@ Optional properties:
> > =20
> >    - interrupts: interrupt mapping for GPIO IRQ
> > =20
> > -  - interrupt-names: should contain "INT1" and/or "INT2", the accelero=
meter's
> > +  - interrupt-names: should contain "INT1" or "INT2", the acceleromete=
r's
> >  		     interrupt line in use.
> > =20
> >    - vdd-supply: phandle to the regulator that provides vdd power to th=
e accelerometer.
> >  =20
>=20
> Acked-by: Martin Kepplinger <martink@posteo.de>
>=20
> thanks,
>=20
>                            martin
>=20