Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 22 Oct 2019 10:29:52 -0700
From:   Jakub Kicinski <jakub.kicinski@netronome.com>
To:     Michal Simek <michal.simek@xilinx.com>
Cc:     Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>,
        davem@davemloft.net, netdev@vger.kernel.org,
        anirudha.sarangi@xilinx.com, john.linn@xilinx.com,
        mchehab+samsung@kernel.org, gregkh@linuxfoundation.org,
        nicolas.ferre@microchip.com, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 net-next] net: axienet: In kconfig add ARM64 as
 supported platform
Message-ID: <20191022102952.09211971@cakuba.netronome.com>
In-Reply-To: <cbdd6608-804a-086c-1892-1903ec4a7d80@xilinx.com>
References: <1571653110-20505-1-git-send-email-radhey.shyam.pandey@xilinx.com>
        <cbdd6608-804a-086c-1892-1903ec4a7d80@xilinx.com>
Organization: Netronome Systems, Ltd.
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 21 Oct 2019 16:15:45 +0200, Michal Simek wrote:
> On 21. 10. 19 12:18, Radhey Shyam Pandey wrote:
> > xilinx axi_emac driver is supported on ZynqMP UltraScale platform.
> > So enable ARCH64 in kconfig. It also removes redundant ARCH_ZYNQ
> > dependency. Basic sanity testing is done on zu+ mpsoc zcu102
> > evaluation board.
> > 
> > Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
> > ---
> > Changes for v2:
> > Remove redundant ARCH_ZYNQ dependency.
> > Modified commit description.
> > ---
> >  drivers/net/ethernet/xilinx/Kconfig | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/net/ethernet/xilinx/Kconfig b/drivers/net/ethernet/xilinx/Kconfig
> > index 8d994ce..da11876 100644
> > --- a/drivers/net/ethernet/xilinx/Kconfig
> > +++ b/drivers/net/ethernet/xilinx/Kconfig
> > @@ -6,7 +6,7 @@
> >  config NET_VENDOR_XILINX
> >  	bool "Xilinx devices"
> >  	default y
> > -	depends on PPC || PPC32 || MICROBLAZE || ARCH_ZYNQ || MIPS || X86 || ARM || COMPILE_TEST
> > +	depends on PPC || PPC32 || MICROBLAZE || MIPS || X86 || ARM || ARM64 || COMPILE_TEST
> >  	---help---
> >  	  If you have a network (Ethernet) card belonging to this class, say Y.
> >  
> > @@ -26,11 +26,11 @@ config XILINX_EMACLITE
> >  
> >  config XILINX_AXI_EMAC
> >  	tristate "Xilinx 10/100/1000 AXI Ethernet support"
> > -	depends on MICROBLAZE || X86 || ARM || COMPILE_TEST
> > +	depends on MICROBLAZE || X86 || ARM || ARM64 || COMPILE_TEST
> >  	select PHYLINK
> >  	---help---
> >  	  This driver supports the 10/100/1000 Ethernet from Xilinx for the
> > -	  AXI bus interface used in Xilinx Virtex FPGAs.
> > +	  AXI bus interface used in Xilinx Virtex FPGAs and Soc's.
> >  
> >  config XILINX_LL_TEMAC
> >  	tristate "Xilinx LL TEMAC (LocalLink Tri-mode Ethernet MAC) driver"
> >   
> 
> Acked-by: Michal Simek <michal.simek@xilinx.com>
> 
> But I can image that others could prefer to remove all dependencies.

Yes, we'd much rather see this litany of architectures removed.
Is there any reason it's there in the first place?

Most drivers are tested on just a few architectures, but as long
as correct APIs are used they are assumed to work across the board.
Otherwise 75% of our drivers would be x86 only. Don't be shy.