Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp474030ybg; Wed, 23 Oct 2019 00:47:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqz8CPQ1ELrDwljXxhTKrNOCEeWcYWTsj9z7Dk7wNiBH9b3FXbDTxGi5S0a8vuw5QND31x3C X-Received: by 2002:aa7:d852:: with SMTP id f18mr9474413eds.110.1571816847506; Wed, 23 Oct 2019 00:47:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571816847; cv=none; d=google.com; s=arc-20160816; b=zjrrL0MbVJgu2Aq9sLBktXx7zJ9kIm8f/PbD4A7hjqMwP3tWX9wF422LOBTE9akV/o 2yjGwRE2mrm9VPnGOEj/qCm8D3xY/Z+1dJKS1Ej7h+hacsWfYeMRxeHxKDA/sa+SHZRI /bJlPlUiLVWBZ2NFraOF7pMwdKL8Oxc4rYcVt5IT2SiN+7ZdbT9/CD1hzbbFqjcudMdc fNyxUO/+Nt2fUYVX0v/p3/Uut+ZeQB2z2JyBuICpjj//J+veNEWjyVOJD0mgc4dkrelu puIuB8OmcP6rLu6/3Z0ZqbjSR1a4N4vgnS666DcUncn/Ygj4cN5Fn2hEtYAuDy48BzwO ZNHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=33x7ICr9fxs1J4Vu9qmTnOIG8Qr9Paia3taGadlBeds=; b=yBe+4arPkML7Emhv/eoyKLFOxXTGkcpCovQwdPmqggetFf+0i2YUVTKIEF7h/iP/ig TynZgEUBRP+XXA/pZInl94IgL9uxfVgB4iTSaQHPWrWm1ii/qeGxCXWlL/rcs25zwEpM qVI+CTEPqk5E50aS7reKHHIsFxzyqjST9StAZ9n0EFWZpH4vjPTLyVfKXOiIiFMV30G6 acQat+hoc6tEC8NtaiA0AdGRR0oASibZSlFxFtZWkI9G7XbyVL9EEWBcor97gRhHkI/F iclJ3Y16+ejSM3oVB+s6MINtRZSVPEYFDESqCk9C8Ghsm9m4hc2F5vBwqY9qoCNAHCij BydQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=sF90pXPO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l20si11966741ejb.111.2019.10.23.00.47.02; Wed, 23 Oct 2019 00:47:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=sF90pXPO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389750AbfJWHqF (ORCPT + 99 others); Wed, 23 Oct 2019 03:46:05 -0400 Received: from mail.skyhub.de ([5.9.137.197]:55526 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732328AbfJWHqE (ORCPT ); Wed, 23 Oct 2019 03:46:04 -0400 Received: from zn.tnic (p200300EC2F11E8005961F1FA34C94581.dip0.t-ipconnect.de [IPv6:2003:ec:2f11:e800:5961:f1fa:34c9:4581]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id B69C01EC0C97; Wed, 23 Oct 2019 09:46:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1571816763; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=33x7ICr9fxs1J4Vu9qmTnOIG8Qr9Paia3taGadlBeds=; b=sF90pXPOJvEOtqF8Zq0yKWXrr3MeSgzvDQ0HYHx+rjLoH2+4RmK73uq/jUqNeB7aEDtm8x IX9nXFmsaljQqV1fzFtTxdjFv0qD5Kd+xBedwsBx7DzFAkf8jpWYIp6dg6Fr60NnWP4NUg Lo3n0JOPGdzv4oLF6joYAx1XUFfSmyc= Date: Wed, 23 Oct 2019 09:46:02 +0200 From: Borislav Petkov To: lijiang Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, bhe@redhat.com, dyoung@redhat.com, jgross@suse.com, dhowells@redhat.com, Thomas.Lendacky@amd.com, ebiederm@xmission.com, vgoyal@redhat.com, kexec@lists.infradead.org Subject: Re: [PATCH 1/3 v4] x86/kdump: always reserve the low 1MiB when the crashkernel option is specified Message-ID: <20191023074602.GB16060@zn.tnic> References: <20191017094347.20327-1-lijiang@redhat.com> <20191017094347.20327-2-lijiang@redhat.com> <20191022083015.GB31700@zn.tnic> <75648e8d-4ef7-0537-618e-e4a57f0d3b9b@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <75648e8d-4ef7-0537-618e-e4a57f0d3b9b@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 23, 2019 at 01:35:09PM +0800, lijiang wrote: > Would you mind if i improve this patch as follow? Thanks. Yap, looks good to me. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette