Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 1/3] phy: cadence: Sierra: add phy_reset hook
To:     Kishon Vijay Abraham I <kishon@ti.com>
CC:     <aniljoy@cadence.com>, <adouglas@cadence.com>, <nsekhar@ti.com>,
        <jsarha@ti.com>, <linux-kernel@vger.kernel.org>,
        <devicetree@vger.kernel.org>
References: <20191022132249.869-1-rogerq@ti.com>
 <20191022132249.869-2-rogerq@ti.com>
 <3d261add-8fa8-13b8-a42b-8662fcbe4b23@ti.com>
From:   Roger Quadros <rogerq@ti.com>
Message-ID: <1956da9e-ec5f-ce68-25ea-1d570e1f7b54@ti.com>
Date:   Wed, 23 Oct 2019 11:08:46 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <3d261add-8fa8-13b8-a42b-8662fcbe4b23@ti.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Kishon,

On 23/10/2019 10:36, Kishon Vijay Abraham I wrote:
> Roger,
> 
> On 22/10/19 6:52 PM, Roger Quadros wrote:
>> This is required if type C driver needs to hold
>> global reset on J7ES to perform LN10 swap.
> 
> Can you replace "This" with something more specific.

I meant this patch, but I will revise the commit message.

cheers,
-roger
> 
> Thanks
> Kishon
>>
>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>> Signed-off-by: Sekhar Nori <nsekhar@ti.com>
>> ---
>>   drivers/phy/cadence/phy-cadence-sierra.c | 10 ++++++++++
>>   1 file changed, 10 insertions(+)
>>
>> diff --git a/drivers/phy/cadence/phy-cadence-sierra.c b/drivers/phy/cadence/phy-cadence-sierra.c
>> index affede8c4368..e6d27bdec22a 100644
>> --- a/drivers/phy/cadence/phy-cadence-sierra.c
>> +++ b/drivers/phy/cadence/phy-cadence-sierra.c
>> @@ -339,10 +339,20 @@ static int cdns_sierra_phy_off(struct phy *gphy)
>>   	return reset_control_assert(ins->lnk_rst);
>>   }
>>   
>> +static int cdns_sierra_phy_reset(struct phy *gphy)
>> +{
>> +	struct cdns_sierra_phy *sp = dev_get_drvdata(gphy->dev.parent);
>> +
>> +	reset_control_assert(sp->phy_rst);
>> +	reset_control_deassert(sp->phy_rst);
>> +	return 0;
>> +};
>> +
>>   static const struct phy_ops ops = {
>>   	.init		= cdns_sierra_phy_init,
>>   	.power_on	= cdns_sierra_phy_on,
>>   	.power_off	= cdns_sierra_phy_off,
>> +	.reset		= cdns_sierra_phy_reset,
>>   	.owner		= THIS_MODULE,
>>   };
>>   
>>

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki