Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] arch: microblaze: support for reserved-memory entries in
 DT
To:     Alvaro Gamez Machado <alvaro.gamez@hazent.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org
References: <20191022081929.10602-1-alvaro.gamez@hazent.com>
 <64db9f22-2e24-23f8-bf64-c4a972fa50c1@monstr.eu>
 <20191023081728.GA17517@salem.gmr.ssr.upm.es>
From:   Michal Simek <monstr@monstr.eu>
Message-ID: <741d5f8b-439f-5d03-b279-d8844da55e4a@monstr.eu>
Date:   Wed, 23 Oct 2019 12:23:08 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <20191023081728.GA17517@salem.gmr.ssr.upm.es>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 23. 10. 19 10:17, Alvaro Gamez Machado wrote:
> Hi Michal
> 
> On Wed, Oct 23, 2019 at 09:59:40AM +0200, Michal Simek wrote:
>> Hi,
>>
>>
>> On 22. 10. 19 10:19, Alvaro Gamez Machado wrote:
>>> Signed-off-by: Alvaro Gamez Machado <alvaro.gamez@hazent.com>
>>
>> please put there reasonable description to commit message.
> 
> Ok, will use those below as template.
>  
>>> ---
>>>  arch/microblaze/mm/init.c | 5 +++++
>>>  1 file changed, 5 insertions(+)
>>>
>>> diff --git a/arch/microblaze/mm/init.c b/arch/microblaze/mm/init.c
>>> index a015a951c8b7..928c5c2816e4 100644
>>> --- a/arch/microblaze/mm/init.c
>>> +++ b/arch/microblaze/mm/init.c
>>> @@ -17,6 +17,8 @@
>>>  #include <linux/slab.h>
>>>  #include <linux/swap.h>
>>>  #include <linux/export.h>
>>> +#include <linux/of_fdt.h>
>>> +#include <linux/of.h>
>>
>> of_fdt.h should be enough.
> 
> Ok
> 
>>>  
>>>  #include <asm/page.h>
>>>  #include <asm/mmu_context.h>
>>> @@ -188,6 +190,9 @@ void __init setup_memory(void)
>>>  
>>>  void __init mem_init(void)
>>>  {
>>> +	early_init_fdt_reserve_self();
>>> +	early_init_fdt_scan_reserved_mem();
>>> +
>>>  	high_memory = (void *)__va(memory_start + lowmem_size - 1);
>>>  
>>>  	/* this will put all memory onto the freelists */
>>>
>>
>>
>> Also I have looked at others arch and take a look at
>>
>> 1b10cb21d888c021bedbe678f7c26aee1bf04ffa
>> ARC: add support for reserved memory defined by device tree
>>
>> where they also enable OF_RESERVED_MEM to call fdt_init_reserve_mem()
>>
>> The same here
>> 4e7c84ec045921dacc78d36295e2e61390249665
>>  xtensa: support reserved-memory DT node
>>
>> and here
>> 9bf14b7c540ae9ca7747af3a0c0d8470ef77b6ce
>> arm64: add support for reserved memory defined by device tree
>>
> 
> They did that at the time, but it seems it's not needed anymore:
> 
> 34e04eedd1cf1be714abb0e5976338cc72ccc05f
>   of: select OF_RESERVED_MEM automatically
> 
> This commit removed those select OF_RESERVED_MEM lines. Is it needed
> specifically for microblaze? I didn't need to do that in order for
> reserved-memory entries to work on my platform.

Ok. Even better. It is not needed if it is built already.

Thanks,
Michal


-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs