Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Received-SPF: Pass (esa4.microchip.iphmx.com: domain of
  Eugen.Hristev@microchip.com designates 198.175.253.82 as
  permitted sender) identity=mailfrom;
  client-ip=198.175.253.82; receiver=esa4.microchip.iphmx.com;
  envelope-from="Eugen.Hristev@microchip.com";
  x-sender="Eugen.Hristev@microchip.com";
  x-conformance=spf_only; x-record-type="v=spf1";
  x-record-text="v=spf1 mx a:ushub1.microchip.com
  a:smtpout.microchip.com a:mx1.microchip.iphmx.com
  a:mx2.microchip.iphmx.com include:servers.mcsv.net
  include:mktomail.com include:spf.protection.outlook.com ~all"
Received-SPF: None (esa4.microchip.iphmx.com: no sender
  authenticity information available from domain of
  postmaster@email.microchip.com) identity=helo;
  client-ip=198.175.253.82; receiver=esa4.microchip.iphmx.com;
  envelope-from="Eugen.Hristev@microchip.com";
  x-sender="postmaster@email.microchip.com";
  x-conformance=spf_only
IronPort-SDR: dzE5Gzzpu15wWm9IL/0HgdTSH2B9PQyIRFcdtxNVhH+Lx8klXJuZr9+w/UtJe3k9deJqcpA/rS
 1MWAnR/GYTj2NLywghWe9FdsYMdkyffx6LGHGhIV4yPKc0ADOyCF+TMTQaYbIcjscxm67nm3oV
 5e6ynpsgK4QgpdA5qjJgW4S10idNsJ3xShwEAaa4tiNflah/ZbIqZSlbPB90sWONO+EF49M0RR
 kxCkq8MiWXST3Ob6enm+9KUV4qeLA1iA+q3jrc+2BgxUaUWySI8uX/+TtX+1Bs18FIUqLC9Wlv
 A0Q=
From:   <Eugen.Hristev@microchip.com>
To:     <peda@axentia.se>, <wsa@the-dreams.de>
CC:     <mark.rutland@arm.com>, <Ludovic.Desroches@microchip.com>,
        <linux-i2c@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <alexandre.belloni@bootlin.com>,
        <robh+dt@kernel.org>, <Nicolas.Ferre@microchip.com>
Subject: Re: [PATCH v5 0/9] i2c: add support for filters
Thread-Topic: [PATCH v5 0/9] i2c: add support for filters
Thread-Index: AQHVaHpLr7113TR4Hk2itVe9BFeajadO9gMAgBZqJ4CAABXHgIAC2ggA
Date:   Wed, 23 Oct 2019 11:01:40 +0000
Message-ID: <c1f5c3f0-860e-e86a-5658-49e2100225a9@microchip.com>
References: <1568189911-31641-1-git-send-email-eugen.hristev@microchip.com>
 <c17182ac-67dd-d11f-5daf-066bf446b969@microchip.com>
 <20191021140515.GC26782@ninjato>
 <f5bd0c1f-9a72-6661-146b-ef5de77e31ff@axentia.se>
In-Reply-To: <f5bd0c1f-9a72-6661-146b-ef5de77e31ff@axentia.se>
Accept-Language: en-US, ro-RO
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-tagtoolbar-keys: D20191023135604197
x-originating-ip: [94.177.32.156]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: bc5685d9-7589-40cb-91ed-08d757a86187
x-ms-traffictypediagnostic: DM5PR11MB2057:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <DM5PR11MB20577C55704E4FFF71047F1BE86B0@DM5PR11MB2057.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:6790;
x-forefront-prvs: 019919A9E4
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(136003)(366004)(396003)(376002)(346002)(39860400002)(199004)(189003)(36756003)(7736002)(305945005)(6512007)(6116002)(3846002)(2906002)(6246003)(107886003)(25786009)(478600001)(4001150100001)(4326008)(14454004)(256004)(14444005)(102836004)(8936002)(81156014)(8676002)(81166006)(476003)(99286004)(486006)(31686004)(446003)(11346002)(66946007)(66446008)(66476007)(66556008)(64756008)(66066001)(110136005)(6436002)(54906003)(229853002)(71190400001)(5660300002)(6486002)(71200400001)(52116002)(26005)(386003)(6506007)(53546011)(2616005)(316002)(76176011)(86362001)(186003)(31696002);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR11MB2057;H:DM5PR11MB1242.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: microchip.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: yEsmK0T0Ca7WgifFzWgeRjh2buCI1i1Ll/7PC/cIAThR9PNOm2MJgJ9m58ViYqKa07QTf7LlBXTCe0qKH1ZCs2SOq4JqYB/wil2jhPVmf6k1qPpJKrUIQdBQUFP8EZXm91VTIfDVSvQj8ZBYg40JNQAYom3QL33YPWpGGSgbQF1w0oJYPCBWEButZPHWM3X5RVPhiHfwpgrpVF6okzo0l0yKK23Uvh1SaK+VNqiugTfZOuROfkAJeyp15o63uMg9VMPH9jw7Z5rjyp3zQtjnwVDHmqrf1v1A74hvn0PM4gjCT2cvs4j/s3xcTospWA8Vc5VoVgnfgOxNp+vLC2p8C+JsJyIlROZtdHg33s/OBlf6UzHdvh8Qfcn1X/dXOQZWNMZwioKKPp5bBji1dNZlgLuf8lBYFJFPqXGnSiqWS0tOZNeWcEKHX8Qkwr1OFt3j
Content-Type: text/plain; charset="Windows-1252"
Content-ID: <B3A0FB639092C0468D6D620D672A992D@namprd11.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: bc5685d9-7589-40cb-91ed-08d757a86187
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Oct 2019 11:01:40.1770
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 6YSZaRHedoGKGnA7Mpr0qg6fQzGDESad2f/eSkoCDlsOU4AH2aJ51Lh8KAPuzbVnhLCehgXW4j1ZkmnaGUbApac8AuDVyGcanbil9uzB2pA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB2057
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 21.10.2019 18:23, Peter Rosin wrote:

>=20
> On 2019-10-21 16:05, Wolfram Sang wrote:
>> On Mon, Oct 07, 2019 at 07:53:21AM +0000, Eugen.Hristev@microchip.com wr=
ote:
>>>
>>>
>>> On 11.09.2019 11:24, Eugen Hristev - M18282 wrote:
>>>> From: Eugen Hristev <eugen.hristev@microchip.com>
>>>>
>>>> Hello,
>>>>
>>>> This series adds support for analog and digital filters for i2c contro=
llers
>>>>
>>>> This series is based on the series:
>>>> [PATCH v2 0/9] i2c: at91: filters support for at91 SoCs
>>>> and later
>>>> [PATCH v4 0/9] i2c: add support for filters
>>>> and enhanced to add the bindings for all controllers plus an extra bin=
dings
>>>> for the width of the spikes in nanoseconds (digital filters) and cut-o=
ff
>>>> frequency (analog filters)
>>>>
>>>> First, bindings are created for
>>>> 'i2c-analog-filter'
>>>> 'i2c-digital-filter'
>>>> 'i2c-digital-filter-width-ns'
>>>> 'i2c-analog-filter-cutoff-frequency'
>>>>
>>>> The support is added in the i2c core to retrieve filter width/cutoff f=
requency
>>>> and add it to the timings structure.
>>>> Next, the at91 driver is enhanced for supporting digital filter, advan=
ced
>>>> digital filter (with selectable spike width) and the analog filter.
>>>>
>>>> Finally the device tree for two boards are modified to make use of the
>>>> new properties.
>>>>
>>>> This series is the result of the comments on the ML in the direction
>>>> requested: to make the bindings globally available for i2c drivers.
>>>>
>>>> Changes in v5:
>>>> - renamed i2c-filter-width-ns to i2c-digital-filter-width-ns as this
>>>> is applicable only to digital filter
>>>> - created new binding i2c-digital-filter-width-ns for analog filters.
>>>
>>> Hello Wolfram and Peter,
>>>
>>> Are you happy with the changes in this version? I haven't heard from yo=
u
>>> since this latest update.
>>> I am interested to know if anymore changes are required or maybe we can
>>> move further with this support.
>>
>> So, I had a look now and I am happy. I will give Peter one more day to
>> comment, otherwise I'll apply it tomorrow.
>=20
> I had another read-through and only found one nit which is in a separate
> message. You can add
>=20
> Reviewed-by: Peter Rosin <peda@axentia.se>
>=20
> for the whole series.

Hello Peter and Wolfram,

Thanks for reviewing.
Send another version of the patch with the nit ?
Or how would you like to proceed ?

Thanks,
Eugen

>=20
> Cheers,
> Peter
>=20
>> Thanks for your patience and keeping at it!
>>
>=20
>=20
>=20