Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp714594ybg; Wed, 23 Oct 2019 04:57:22 -0700 (PDT) X-Google-Smtp-Source: APXvYqyFolniznOZEPMc3SjNrH4LBI2PPfBZCfGZTciQyS0vHxCgwMc2OmlTbNFosA/DK8xmNUWf X-Received: by 2002:a50:b536:: with SMTP id y51mr19007100edd.271.1571831842274; Wed, 23 Oct 2019 04:57:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571831842; cv=none; d=google.com; s=arc-20160816; b=NnDzyLibhVuTsydVErpJ3IDzcKnTJ+SWs7WWiqBRpY+ebtzLBhauDxMtJ0e4jmv0YU GwaDY0Nz76CXISynyRCkLmjZPw3DlWXHq6wDyT24ESf3sQTJfo2n0j3ZlCGpIT3nJgEh Sr6xmFEu6j4/lNMAS6o9e+Cr71TrdAI8hbId6Rq6s6UCrRH86feH+Dh0BNjUSeJPcknr 22hK0hkJBHnielUJIElVz8NhhfTtqjWfz+Zbh82ZX7NuMyV8szWx3i9j8fha1wJRq+z2 rfUNuZMPY9f0SbdAA77lZJLNB5oYHuwgr6NKN6ak8vkw+2mF7WVI/uS1eU2QS1cQ3CYs c+Ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=fvXrQGKwIXHeFtg8Dq6u2zyMS+4tf5N2t/6iPtIhlgc=; b=s4aoI4DkfMFcmPt/HLmSN9RDO+JiApIbKtyzVKAogtlAQ3VZbqVmylGEee/ivxG+LI uqwm4ISBwKjfSwOByHdEQXWGOFWjfvL40La/JTbGaRunK5yOeb8YvAqkgTH+6liY8LIM idFvEx2c9nvB8+qQSCVBO5lRYe0S26L0U1NSvB5Pr0zFyJpuLeX0EJIPD0ry02GgdujX 7TSnpmlYFHfuxcEBWqrt3GHOmDw2NtzCisDGCZU4g1lNxUNiKaerb4c0tuO2bwr3rdFL ASnHxLQzttYILKwMwZxgUGUc/RbtlnRfA4HgPyakhWtInitst65SNMRFT0DYbwiHkQsb C6gg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="R21h/IlO"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ly18si5215704ejb.374.2019.10.23.04.56.57; Wed, 23 Oct 2019 04:57:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="R21h/IlO"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388917AbfJWFJe (ORCPT + 99 others); Wed, 23 Oct 2019 01:09:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:35852 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728697AbfJWFJe (ORCPT ); Wed, 23 Oct 2019 01:09:34 -0400 Received: from localhost (unknown [122.181.210.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5FFD4214B2; Wed, 23 Oct 2019 05:09:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571807374; bh=yHRR1qaWgApvonMqA4KR2biBOE3OmpEgupa0lezkM0M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=R21h/IlOeR/5NGFmEipA8/XzUX9RObcjqUIfu1kzWiTtCkMr6Tf4gqCl5fnqDdTC/ QUqx9pXRV2ITidQMqdCDmlPIGKf4+NmPqvv0EyKemFVDmei/ced4i+3MGTpQrESppR AhXXil0XZGhNcpJkFKvx1OM04DOLOfOh/SWMWrcw= Date: Wed, 23 Oct 2019 10:39:27 +0530 From: Vinod Koul To: Peng Ma Cc: dan.j.williams@intel.com, leoyang.li@nxp.com, anders.roxell@linaro.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org Subject: Re: [next, v2] dmaengine: fsl-dpaa2-qdma: export the symbols Message-ID: <20191023050927.GP2654@vkoul-mobl> References: <20191023045617.22764-1-peng.ma@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191023045617.22764-1-peng.ma@nxp.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23-10-19, 12:56, Peng Ma wrote: > The symbols were not exported leading to error: > > WARNING: modpost: missing MODULE_LICENSE() in drivers/dma/fsl-dpaa2-qdma/dpdmai.o > see include/linux/module.h for more information > GZIP arch/arm64/boot/Image.gz > ERROR: "dpdmai_enable" [drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko] undefined! > ERROR: "dpdmai_set_rx_queue" [drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko] undefined! > ERROR: "dpdmai_get_tx_queue" [drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko] undefined! > ERROR: "dpdmai_get_rx_queue" [drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko] undefined! > ERROR: "dpdmai_get_attributes" [drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko] undefined! > ERROR: "dpdmai_open" [drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko] undefined! > ERROR: "dpdmai_close" [drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko] undefined! > ERROR: "dpdmai_disable" [drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko] undefined! > ERROR: "dpdmai_reset" [drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko] undefined! > WARNING: "HYPERVISOR_platform_op" [vmlinux] is a static EXPORT_SYMBOL_GPL > make[2]: *** [__modpost] Error 1 > make[1]: *** [modules] Error 2 > make[1]: *** Waiting for unfinished jobs.... > make: *** [sub-make] Error 2 > > So export it. Applied, thanks -- ~Vinod