Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp764072ybg; Wed, 23 Oct 2019 05:38:01 -0700 (PDT) X-Google-Smtp-Source: APXvYqzhSDWQHbu6w0+UQPB0u8mRwjejtNjE1C/aJKyOCYCIF+RdA15We68/vBingpHTHo4bGJ9j X-Received: by 2002:a17:906:66c2:: with SMTP id k2mr7586085ejp.1.1571834281437; Wed, 23 Oct 2019 05:38:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571834281; cv=none; d=google.com; s=arc-20160816; b=shy4AfjYv0mT6OD5lviUICAD/A1lcOCAZ+LTW1cgVf8ExDlT5rgRPfJti7fanxTRg1 q8vx4TZRVtxbbwcloWSC47MgX9IMUys2khomnJvUlH4KsUwGgb8NoyZCZytIQlDuTwCw 0sPepqtfl/B6o9hvE75msQEaas8zmdrZnjJBa3KspDnyJQz3fXMgwW+wqEMzWO0rdUUm gZKUk4sCM/6R3quh0XOYh0GtpaseIecslNdOeKDwfBh3ceQIIhH7mE3aPV/DcTlHSKTX dupjTZqyt0d8vF+lMdMOLEzVSqrQlBmlirXoXxcTn3xxF+Cq1Jvp5W3bQ6qMq9UM4i/Y hmwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=52Jm32jrrusywh/3nqAsIZ0YYBHKi0vZ9VhuEV0cCIA=; b=GZf73u7fSGZ4Lame0lr4h+DLsctiehskbxVKgWHFVAHWoHWuXPwkuDVq3UiHL/4XWf EK0ZFA1RCFMo00gd9XP7T57VgWwo6g+/pgqLNnN7rv6wl/E8OtSn76xIt8+iPDLVhNWv uP6DP9MrcFPqDL+xiPnKyBmKFD4TTJimDX7DzTPWI6QSwVv2I46elFBuwtG5cikOYrlt SZGWxoyBLhXg3lWLE9whw0SCLmGtR71GynauCY6Eh3G9OGs0FIU/iE+gSeDobkrXuv8u wL05KKDgRGrHiOv8qZgzsyHTm78t6oa4tj/y+5T8LPsW+kZGG1SCzcM173s/Jmll03c4 FjmA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b="bP5gy/Ff"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f23si1616850ejb.333.2019.10.23.05.37.37; Wed, 23 Oct 2019 05:38:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b="bP5gy/Ff"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390760AbfJWJUi (ORCPT + 99 others); Wed, 23 Oct 2019 05:20:38 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:42160 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389998AbfJWJUi (ORCPT ); Wed, 23 Oct 2019 05:20:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=52Jm32jrrusywh/3nqAsIZ0YYBHKi0vZ9VhuEV0cCIA=; b=bP5gy/FfoLW6d56GYc4h+bRVX L9MAtKkYul7Ui6vwj8Kpd+3HhjRrHBExFOQM/94qxKspB8OVXc9yZU9DmokRw2ZiBFxB1iVKkvTwH Pbqu8XVBnl7RzDKPla608gGz0w7EBm0FXoRFR0eehg25Ry4/eUxjdXZyb4i+zg1bG3ROl037p7myL RJe+ACljRKSQ9TQahbGmVkMGq787/xdXrCokB5IHxbBYlBx/pNP9pRKO9OMLpeMAx/I8K8BUc9M6K FddMUH5sCvKo2133j+6u5firXeKrcTDAy9Jf6p1j3e/dmJN1QA/6ZwYxcUvxajqOdwLRovfEMoxtM tblwX+Vuw==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1iNCol-0004T6-FG; Wed, 23 Oct 2019 09:20:35 +0000 Date: Wed, 23 Oct 2019 02:20:35 -0700 From: Christoph Hellwig To: Omer Shpigelman Cc: "oded.gabbay@gmail.com" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 1/2] habanalabs: support kernel memory mapping Message-ID: <20191023092035.GA12222@infradead.org> References: <20191022063028.9030-1-oshpigelman@habana.ai> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191022063028.9030-1-oshpigelman@habana.ai> User-Agent: Mutt/1.12.1 (2019-06-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 22, 2019 at 06:30:35AM +0000, Omer Shpigelman wrote: > Changes in v2: > - use a boolean parameter to indicate for kernel address rather than > calling is_vmalloc_addr, as kernel and user addresses can overlap on > some architectures. That is still broken. Please use an actual kernel pointer instead of losing all type safety by casting it an integer type.