Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 23 Oct 2019 12:30:48 +0200
From:   Jiri Olsa <jolsa@redhat.com>
To:     Andi Kleen <andi@firstfloor.org>
Cc:     acme@kernel.org, linux-kernel@vger.kernel.org, jolsa@kernel.org,
        eranian@google.com, kan.liang@linux.intel.com,
        peterz@infradead.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH v2 9/9] perf stat: Use affinity for enabling/disabling
 events
Message-ID: <20191023103048.GK22919@krava>
References: <20191020175202.32456-1-andi@firstfloor.org>
 <20191020175202.32456-10-andi@firstfloor.org>
MIME-Version: 1.0
In-Reply-To: <20191020175202.32456-10-andi@firstfloor.org>
User-Agent: Mutt/1.12.1 (2019-06-15)
Content-Type: text/plain; charset=WINDOWS-1252
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Oct 20, 2019 at 10:52:02AM -0700, Andi Kleen wrote:

SNIP

> =20
>  void evlist__enable(struct evlist *evlist)
>  {
>  =09struct evsel *pos;
> +=09struct affinity affinity;
> +=09struct perf_cpu_map *cpus;
> +=09int i;
> +
> +=09if (affinity__setup(&affinity) < 0)
> +=09=09return;
> +
> +=09cpus =3D evlist__cpu_iter_start(evlist);
> +=09for (i =3D 0; i < cpus->nr; i++) {
> +=09=09int cpu =3D cpus->map[i];
> +=09=09affinity__set(&affinity, cpu);
> =20
> +=09=09evlist__for_each_entry(evlist, pos) {
> +=09=09=09if (evlist__cpu_iter_skip(pos, cpu))
> +=09=09=09=09continue;
> +=09=09=09if (!perf_evsel__is_group_leader(pos) || !pos->core.fd)
> +=09=09=09=09continue;

all the previous patches and this one have this code in common,
could we make this a single function, that would call a callback
that would have affinity set.. sort of like what we do in=20
cpu_function_call in the kernel

thanks,
jirka

> +=09=09=09evsel__enable_cpu(pos, pos->cpu_index);
> +=09=09=09evlist__cpu_iter_next(pos);
> +=09=09}
> +=09}
> +=09affinity__cleanup(&affinity);

SNIP