Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp1084541ybg; Wed, 23 Oct 2019 10:07:26 -0700 (PDT) X-Google-Smtp-Source: APXvYqw2lNqFDBukZEK1fJFJq+11Jly0R/g7LiFodnZynSJDzdqGlDbVSZcp+If7I66aJTjHP1Tr X-Received: by 2002:a05:6402:13c5:: with SMTP id a5mr19813220edx.106.1571850446600; Wed, 23 Oct 2019 10:07:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571850446; cv=none; d=google.com; s=arc-20160816; b=uPa6pGqqM6Egk+CUf7WXUEnxuLUybR4cHP+oNMmDTHerKLbZdU0vkyrCwCVxJeEAym 7sQXtOu/Pyqt01mpoauMDqSpw0OqB3fScpQmEi363WaZl3O0mK4c4JUfycJ/Cnig0n4z ggEkvijMasT3vpsfgvZrmGKJUk2OwU6H0WTGE9Wpg6SpbLaepY66eN6an+1ZZmNObzVd xZ9/wVhd/DSVzj4o949AXJ6RoBwcKpF5390Op7ArQiAuSCd+Cc3ETIXgIdKo78GrH2vB 32I15i1ipy3DNKTqojfHOZTx47P/Sc9D6Pbb/+ytQcTgNko+caBpwhwB+N6DrV9kaBGN jLvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:subject:cc:to :from:date:user-agent:message-id; bh=T6O31aVGgNu5nsoqFI97V6/TsfkL2VZkd43q1NhhXrc=; b=EU8CuB/7Gk/CTZlTjTboOTxdgauUxwOJgaWrJf8dP/YvfnvrAR3XR0EzETOEqp6YFj MN249ZcFI6PrsFvCBT7j17+fajo32+9U4qBsNiaZNJxvJNTs8+z/tASc6EW3DMp6z+E5 zRb4wquiYCFPbIMt4SvxjTq449tz0deY5DuieIL1riuWLgYgzB7IfS4bMc781d3j7xtu EHU6WQULgYWwVz/gY8sYdn4eszEVf/umzqPbbOtIYodFHnuH468b87Og0QSKUtj6t68L Lq3BvQBm3FVTChUE5rg8BiKH28127eOUYmUQqemm+YzjeBaRIf/1cSeS4TsgMIOAws9U OnsQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id oq16si8662000ejb.323.2019.10.23.10.07.00; Wed, 23 Oct 2019 10:07:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391358AbfJWMbk (ORCPT + 99 others); Wed, 23 Oct 2019 08:31:40 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:49084 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732144AbfJWMbj (ORCPT ); Wed, 23 Oct 2019 08:31:39 -0400 Received: from localhost ([127.0.0.1] helo=nanos.tec.linutronix.de) by Galois.linutronix.de with esmtp (Exim 4.80) (envelope-from ) id 1iNFnb-000174-UN; Wed, 23 Oct 2019 14:31:35 +0200 Message-Id: <20191023123117.871608831@linutronix.de> User-Agent: quilt/0.65 Date: Wed, 23 Oct 2019 14:27:08 +0200 From: Thomas Gleixner To: LKML Cc: x86@kernel.org, Peter Zijlstra , Andy Lutomirski , Will Deacon , Paolo Bonzini , kvm@vger.kernel.org, linux-arch@vger.kernel.org, Mike Rapoport , Josh Poimboeuf , Miroslav Benes Subject: [patch V2 03/17] x86/traps: Remove pointless irq enable from do_spurious_interrupt_bug() References: <20191023122705.198339581@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org That function returns immediately after conditionally reenabling interrupts which is more than pointless and requires the ASM code to disable interrupts again. Signed-off-by: Thomas Gleixner --- arch/x86/kernel/traps.c | 1 - 1 file changed, 1 deletion(-) --- a/arch/x86/kernel/traps.c +++ b/arch/x86/kernel/traps.c @@ -871,7 +871,6 @@ do_simd_coprocessor_error(struct pt_regs dotraplinkage void do_spurious_interrupt_bug(struct pt_regs *regs, long error_code) { - cond_local_irq_enable(regs); } dotraplinkage void