Date: Sun, 08 Jan 2006 16:41:34 -0500
From: Ben Collins <ben.collins@ubuntu.com>
Subject: Re: [PATCH 15/15] kconf: Check for eof from input stream.
In-reply-to: <Pine.LNX.4.61.0601082158310.8860@spit.home>
To: Roman Zippel <zippel@linux-m68k.org>
Cc: linux-kernel@vger.kernel.org
Message-id: <1136756494.1043.16.camel@grayson>
Organization: Ubuntu Linux
MIME-version: 1.0
Content-type: text/plain
Content-transfer-encoding: 7BIT
References: <0ISL003ZI97GCY@a34-mta01.direcway.com>
 <200601081734.30349.zippel@linux-m68k.org> <1136746381.1043.10.camel@grayson>
 <Pine.LNX.4.61.0601082158310.8860@spit.home>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1084
Lines: 30

On Sun, 2006-01-08 at 21:59 +0100, Roman Zippel wrote:
> Hi,
> 
> On Sun, 8 Jan 2006, Ben Collins wrote:
> 
> > Anyway, the problem is that if there is no terminal (e.g. stdout is
> > redirected to a file, and stdin is closed), then kconf loops forever
> > trying to get an answer (NULL is not the same as "").
> 
> Then let's fix the real problem.

That's not entirely acceptable. The reason this shows up is if an
automatic build is being done, and the config files are not up-to-date,
the prefered action is a build failure, not selecting defaults. The
reason for my fix was that instead of filling up diskspace with a
logfile of kconf's infinite loop, we just exit with an error.

Currently, this is the only way to ensure that these issues don't go
unnoticed.

-- 
   Ben Collins <ben.collins@ubuntu.com>
   Developer
   Ubuntu Linux

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/