Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp1275044ybg; Wed, 23 Oct 2019 13:08:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqxC5QhY9p4F62uzLWDOZy4C4MWQVIUVNDiwMUbvWtK+Yw8+UKcKNyyi+G1NvjrHvEsGgiyb X-Received: by 2002:a17:907:4451:: with SMTP id mw1mr15442894ejb.209.1571861325010; Wed, 23 Oct 2019 13:08:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571861325; cv=none; d=google.com; s=arc-20160816; b=i51altKihAiJOArEBlzaSFo9vORsXugs1Bt3ccpiu4NR0pWeudav+HRpP5WFhd6ShI pc8NTFpKOe4yIHQgahovPnNtjyBZvYexr07gyfhnNZibnyxZUhnaWdTSnpO6XUMqTPIn MTS1/askxJ6StaSL4meoh59UBeC5u7WWOiBeiihE05PTnEFrxoOBfcvafoGMLI/AO18a Lub9HONGSybJhMSuengDoEmFgveTb+GgI5Epu+28H9k78k8+5kuIqn1/hfLu7SdYtJsl VXVghDn9N+5SvOwtSU0D8r9cHBmRF9YUyx/ixROma0ylt5v6uYVvDTv6x9AUxpqzzB8N hqKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:references :organization:in-reply-to:subject:cc:to:from; bh=UxOVJfNJjUSXOp8orLq8rR2EHBGI1apuFL5V1cXs8yg=; b=Mg5NMxKIQeiMgsPF164QfAj1BwlaoeokH6HBjnVgcmMicMf275YIZl0mj4BOWT098r DXjlkDFeuJNG5tG24e2SGwFnyMtL5bJheAw+SpouvuSTV77RJfCFZTJgQda5DRH6OOvh /4W+78LmXrw2r1h4vwSVrACQ1C2Zu28OGDMeTQa7vdoqQWMFHVm+Ih56dg045n/bxmol r90Erd1SCEAQY+uzlTKPYNYKmHPOJ4CGtlxOSUKeUQEr+lwyuG/xybG7JXpBp/RymHeu wURRUiVaQPsUYKcRzmSkNiFhh/bBnV8dU+LdkWi7uI2EefibFnuutaqSVM3pmhjYtiPe R2EQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s52si10295880edd.65.2019.10.23.13.08.20; Wed, 23 Oct 2019 13:08:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391931AbfJWN0U (ORCPT + 99 others); Wed, 23 Oct 2019 09:26:20 -0400 Received: from mga14.intel.com ([192.55.52.115]:38480 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391495AbfJWN0U (ORCPT ); Wed, 23 Oct 2019 09:26:20 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Oct 2019 06:26:20 -0700 X-IronPort-AV: E=Sophos;i="5.68,221,1569308400"; d="scan'208";a="191828934" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Oct 2019 06:26:16 -0700 From: Jani Nikula To: Rasmus Villemoes , linux-kernel@vger.kernel.org Cc: Joonas Lahtinen , Rodrigo Vivi , intel-gfx@lists.freedesktop.org, Vishal Kulkarni , netdev@vger.kernel.org, Greg Kroah-Hartman , linux-usb@vger.kernel.org, Andrew Morton , Julia Lawall Subject: Re: [PATCH v4] string-choice: add yesno(), onoff(), enableddisabled(), plural() helpers In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20191023131308.9420-1-jani.nikula@intel.com> Date: Wed, 23 Oct 2019 16:26:13 +0300 Message-ID: <87h83zegp6.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 23 Oct 2019, Rasmus Villemoes wrote: > On 23/10/2019 15.13, Jani Nikula wrote: >> The kernel has plenty of ternary operators to choose between constant >> strings, such as condition ? "yes" : "no", as well as value == 1 ? "" : >> "s": >> >> >> v4: Massaged commit message about space savings to make it less fluffy >> based on Rasmus' feedback. > > Thanks, it looks good to me. FWIW, > > Acked-by: Rasmus Villemoes Thanks. I think the question is, which tree to apply this to, who's going to pick it up? I'm fine with any route. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center