Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: 5umrMZGbR1676MZWVWSSs9yqqeNsYyeNAIN/7LlGfxNnfoVrnWUPYiRnAlX2bF/ccJ4J2vseGv
 lTKaHxKDKRzW28SO3IjzmVNWRvBkBR8f3HFc4UQJJPDJNQFmSHJAvpNauF7z22m0zIO9nV9OS2
 gHqB18eOAiGl/X957x4GNckzxLC3ITCgiyJ6Kp8xBJ/cKnad7G/YAnIaaviNLMYlnSYr1XRoAU
 nJTihLn0mVX1kxUv65pSoQTAppbiowKwqpQMz8PHt/hykIWa4ESQvAXBfsoK+meQlivOAGmG/o
 bcg=
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To:     Logan Gunthorpe <logang@deltatee.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
CC:     Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
        Max Gurtovoy <maxg@mellanox.com>,
        Stephen Bates <sbates@raithlin.com>
Subject: Re: [PATCH 5/7] nvmet: Introduce nvmet_dsm_len() helper
Thread-Topic: [PATCH 5/7] nvmet: Introduce nvmet_dsm_len() helper
Thread-Index: AQHVib/6vP1Zu73G8kKgTvQAkF+kfw==
Date:   Wed, 23 Oct 2019 20:31:58 +0000
Message-ID: <BYAPR04MB574984DB7059767E40564B4C866B0@BYAPR04MB5749.namprd04.prod.outlook.com>
References: <20191023163545.4193-1-logang@deltatee.com>
 <20191023163545.4193-6-logang@deltatee.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 6b7288b3-be2c-4f2b-e51d-08d757f80d84
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Oct 2019 20:31:58.4964
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: aWE5wsouLi3es1nV3ScPObZGj7YWfDuUgOsmIR5IUuOBc1GayhBt/6dORrzJhZf9ILZFeD+VAmpReRZSErqch8RAXLtHJ7y+96Ia4Zhoz4g=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR04MB4742
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Looks good.=0A=
=0A=
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>=0A=
=0A=
On 10/23/2019 09:36 AM, Logan Gunthorpe wrote:=0A=
> Similar to the nvmet_rw_len helper.=0A=
>=0A=
> Signed-off-by: Christoph Hellwig <hch@lst.de>=0A=
> [logang@deltatee.com: separated out of a larger draft patch from hch]=0A=
> Signed-off-by: Logan Gunthorpe <logang@deltatee.com>=0A=
> ---=0A=
>   drivers/nvme/target/io-cmd-file.c | 3 +--=0A=
>   drivers/nvme/target/nvmet.h       | 6 ++++++=0A=
>   2 files changed, 7 insertions(+), 2 deletions(-)=0A=
>=0A=
> diff --git a/drivers/nvme/target/io-cmd-file.c b/drivers/nvme/target/io-c=
md-file.c=0A=
> index 05453f5d1448..7481556da6e6 100644=0A=
> --- a/drivers/nvme/target/io-cmd-file.c=0A=
> +++ b/drivers/nvme/target/io-cmd-file.c=0A=
> @@ -379,8 +379,7 @@ u16 nvmet_file_parse_io_cmd(struct nvmet_req *req)=0A=
>   		return 0;=0A=
>   	case nvme_cmd_dsm:=0A=
>   		req->execute =3D nvmet_file_execute_dsm;=0A=
> -		req->data_len =3D (le32_to_cpu(cmd->dsm.nr) + 1) *=0A=
> -			sizeof(struct nvme_dsm_range);=0A=
> +		req->data_len =3D nvmet_dsm_len(req);=0A=
>   		return 0;=0A=
>   	case nvme_cmd_write_zeroes:=0A=
>   		req->execute =3D nvmet_file_execute_write_zeroes;=0A=
> diff --git a/drivers/nvme/target/nvmet.h b/drivers/nvme/target/nvmet.h=0A=
> index c51f8dd01dc4..6ccf2d098d9f 100644=0A=
> --- a/drivers/nvme/target/nvmet.h=0A=
> +++ b/drivers/nvme/target/nvmet.h=0A=
> @@ -495,6 +495,12 @@ static inline u32 nvmet_rw_len(struct nvmet_req *req=
)=0A=
>   			req->ns->blksize_shift;=0A=
>   }=0A=
>=0A=
> +static inline u32 nvmet_dsm_len(struct nvmet_req *req)=0A=
> +{=0A=
> +	return (le32_to_cpu(req->cmd->dsm.nr) + 1) *=0A=
> +		sizeof(struct nvme_dsm_range);=0A=
> +}=0A=
> +=0A=
>   u16 errno_to_nvme_status(struct nvmet_req *req, int errno);=0A=
>=0A=
>   /* Convert a 32-bit number to a 16-bit 0's based number */=0A=
>=0A=
=0A=