Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: oiotO1KfJ3dJwG93qEWGZEgYQLQW0Z7LvSiwiG4lOr4tUzMTl8WnkGC8zCjYqzAbSRPRkC3A/j
 MtTtjcSdPkn62kDnFQLVX9SSSEybMUUHBU+RZdwEtjTkPEyIYDESI0NzpT54Q7gDZ924m2Jt0p
 I/WS4LYk7rB19KGr+HoES4yXT/6q+VnOr+KdW5vR2eJjBdduQctzjN90eVnwdELPxzJoyvCWWd
 GG7KgolgNbs2jj5H9HDRCh5z3fqpxyYAo59a18DoUust9yo5UPgntVRUFH5GF2s5B506n9KC3O
 sy8=
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To:     Logan Gunthorpe <logang@deltatee.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
CC:     Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
        Max Gurtovoy <maxg@mellanox.com>,
        Stephen Bates <sbates@raithlin.com>
Subject: Re: [PATCH 7/7] nvmet: Open code nvmet_req_execute()
Thread-Topic: [PATCH 7/7] nvmet: Open code nvmet_req_execute()
Thread-Index: AQHVib/6nPsLqYy1yEqvZCLnovEzDg==
Date:   Wed, 23 Oct 2019 20:34:34 +0000
Message-ID: <BYAPR04MB57490B2F11504A26F2166862866B0@BYAPR04MB5749.namprd04.prod.outlook.com>
References: <20191023163545.4193-1-logang@deltatee.com>
 <20191023163545.4193-8-logang@deltatee.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 60a876fc-2b85-47c5-600b-08d757f86aaf
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Oct 2019 20:34:34.8589
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Uf9YNZJkTISJ73hOoj16P2TFoaatuKYPF9rZybWsyUJ7mj2T55pROjlCiDTQY4rO51CYWbICpEacv0u1Ix7LbtBakxuDlDdy+yW9aXxPoK0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR04MB4469
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

It doesn't hurt to keep that function, makes code easier to=0A=
read and search since it has been used in different places.=0A=
=0A=
Anyways, looks good.=0A=
=0A=
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>=0A=
=0A=
On 10/23/2019 09:36 AM, Logan Gunthorpe wrote:=0A=
> Now that nvmet_req_execute does nothing, open code it.=0A=
>=0A=
> Signed-off-by: Christoph Hellwig <hch@lst.de>=0A=
> [logang@deltatee.com: separated out of a larger draft patch from hch]=0A=
> Signed-off-by: Logan Gunthorpe <logang@deltatee.com>=0A=
> ---=0A=
>   drivers/nvme/target/core.c  | 6 ------=0A=
>   drivers/nvme/target/fc.c    | 4 ++--=0A=
>   drivers/nvme/target/loop.c  | 2 +-=0A=
>   drivers/nvme/target/nvmet.h | 1 -=0A=
>   drivers/nvme/target/rdma.c  | 4 ++--=0A=
>   drivers/nvme/target/tcp.c   | 6 +++---=0A=
>   6 files changed, 8 insertions(+), 15 deletions(-)=0A=
>=0A=
> diff --git a/drivers/nvme/target/core.c b/drivers/nvme/target/core.c=0A=
> index 87fe82ccfa89..f7da0e50beeb 100644=0A=
> --- a/drivers/nvme/target/core.c=0A=
> +++ b/drivers/nvme/target/core.c=0A=
> @@ -942,12 +942,6 @@ bool nvmet_check_data_len(struct nvmet_req *req, siz=
e_t data_len)=0A=
>   }=0A=
>   EXPORT_SYMBOL_GPL(nvmet_check_data_len);=0A=
>=0A=
> -void nvmet_req_execute(struct nvmet_req *req)=0A=
> -{=0A=
> -	req->execute(req);=0A=
> -}=0A=
> -EXPORT_SYMBOL_GPL(nvmet_req_execute);=0A=
> -=0A=
>   int nvmet_req_alloc_sgl(struct nvmet_req *req)=0A=
>   {=0A=
>   	struct pci_dev *p2p_dev =3D NULL;=0A=
> diff --git a/drivers/nvme/target/fc.c b/drivers/nvme/target/fc.c=0A=
> index ce8d819f86cc..7f9c11138b93 100644=0A=
> --- a/drivers/nvme/target/fc.c=0A=
> +++ b/drivers/nvme/target/fc.c=0A=
> @@ -2015,7 +2015,7 @@ nvmet_fc_fod_op_done(struct nvmet_fc_fcp_iod *fod)=
=0A=
>   		}=0A=
>=0A=
>   		/* data transfer complete, resume with nvmet layer */=0A=
> -		nvmet_req_execute(&fod->req);=0A=
> +		fod->req.execute(&fod->req);=0A=
>   		break;=0A=
>=0A=
>   	case NVMET_FCOP_READDATA:=0A=
> @@ -2231,7 +2231,7 @@ nvmet_fc_handle_fcp_rqst(struct nvmet_fc_tgtport *t=
gtport,=0A=
>   	 * can invoke the nvmet_layer now. If read data, cmd completion will=
=0A=
>   	 * push the data=0A=
>   	 */=0A=
> -	nvmet_req_execute(&fod->req);=0A=
> +	fod->req.execute(&fod->req);=0A=
>   	return;=0A=
>=0A=
>   transport_error:=0A=
> diff --git a/drivers/nvme/target/loop.c b/drivers/nvme/target/loop.c=0A=
> index 11f5aea97d1b..f4b878b113f7 100644=0A=
> --- a/drivers/nvme/target/loop.c=0A=
> +++ b/drivers/nvme/target/loop.c=0A=
> @@ -126,7 +126,7 @@ static void nvme_loop_execute_work(struct work_struct=
 *work)=0A=
>   	struct nvme_loop_iod *iod =3D=0A=
>   		container_of(work, struct nvme_loop_iod, work);=0A=
>=0A=
> -	nvmet_req_execute(&iod->req);=0A=
> +	iod->req.execute(&iod->req);=0A=
>   }=0A=
>=0A=
>   static blk_status_t nvme_loop_queue_rq(struct blk_mq_hw_ctx *hctx,=0A=
> diff --git a/drivers/nvme/target/nvmet.h b/drivers/nvme/target/nvmet.h=0A=
> index ff55f1005b35..46df45e837c9 100644=0A=
> --- a/drivers/nvme/target/nvmet.h=0A=
> +++ b/drivers/nvme/target/nvmet.h=0A=
> @@ -374,7 +374,6 @@ bool nvmet_req_init(struct nvmet_req *req, struct nvm=
et_cq *cq,=0A=
>   		struct nvmet_sq *sq, const struct nvmet_fabrics_ops *ops);=0A=
>   void nvmet_req_uninit(struct nvmet_req *req);=0A=
>   bool nvmet_check_data_len(struct nvmet_req *req, size_t data_len);=0A=
> -void nvmet_req_execute(struct nvmet_req *req);=0A=
>   void nvmet_req_complete(struct nvmet_req *req, u16 status);=0A=
>   int nvmet_req_alloc_sgl(struct nvmet_req *req);=0A=
>   void nvmet_req_free_sgl(struct nvmet_req *req);=0A=
> diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c=0A=
> index 36d906a7f70d..248e68da2e13 100644=0A=
> --- a/drivers/nvme/target/rdma.c=0A=
> +++ b/drivers/nvme/target/rdma.c=0A=
> @@ -603,7 +603,7 @@ static void nvmet_rdma_read_data_done(struct ib_cq *c=
q, struct ib_wc *wc)=0A=
>   		return;=0A=
>   	}=0A=
>=0A=
> -	nvmet_req_execute(&rsp->req);=0A=
> +	rsp->req.execute(&rsp->req);=0A=
>   }=0A=
>=0A=
>   static void nvmet_rdma_use_inline_sg(struct nvmet_rdma_rsp *rsp, u32 le=
n,=0A=
> @@ -746,7 +746,7 @@ static bool nvmet_rdma_execute_command(struct nvmet_r=
dma_rsp *rsp)=0A=
>   				queue->cm_id->port_num, &rsp->read_cqe, NULL))=0A=
>   			nvmet_req_complete(&rsp->req, NVME_SC_DATA_XFER_ERROR);=0A=
>   	} else {=0A=
> -		nvmet_req_execute(&rsp->req);=0A=
> +		rsp->req.execute(&rsp->req);=0A=
>   	}=0A=
>=0A=
>   	return true;=0A=
> diff --git a/drivers/nvme/target/tcp.c b/drivers/nvme/target/tcp.c=0A=
> index 3378480c49f6..af674fc0bb1e 100644=0A=
> --- a/drivers/nvme/target/tcp.c=0A=
> +++ b/drivers/nvme/target/tcp.c=0A=
> @@ -930,7 +930,7 @@ static int nvmet_tcp_done_recv_pdu(struct nvmet_tcp_q=
ueue *queue)=0A=
>   		goto out;=0A=
>   	}=0A=
>=0A=
> -	nvmet_req_execute(&queue->cmd->req);=0A=
> +	queue->cmd->req.execute(&queue->cmd->req);=0A=
>   out:=0A=
>   	nvmet_prepare_receive_pdu(queue);=0A=
>   	return ret;=0A=
> @@ -1050,7 +1050,7 @@ static int nvmet_tcp_try_recv_data(struct nvmet_tcp=
_queue *queue)=0A=
>   			nvmet_tcp_prep_recv_ddgst(cmd);=0A=
>   			return 0;=0A=
>   		}=0A=
> -		nvmet_req_execute(&cmd->req);=0A=
> +		cmd->req.execute(&cmd->req);=0A=
>   	}=0A=
>=0A=
>   	nvmet_prepare_receive_pdu(queue);=0A=
> @@ -1090,7 +1090,7 @@ static int nvmet_tcp_try_recv_ddgst(struct nvmet_tc=
p_queue *queue)=0A=
>=0A=
>   	if (!(cmd->flags & NVMET_TCP_F_INIT_FAILED) &&=0A=
>   	    cmd->rbytes_done =3D=3D cmd->req.transfer_len)=0A=
> -		nvmet_req_execute(&cmd->req);=0A=
> +		cmd->req.execute(&cmd->req);=0A=
>   	ret =3D 0;=0A=
>   out:=0A=
>   	nvmet_prepare_receive_pdu(queue);=0A=
>=0A=
=0A=