Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp2264363ybg; Thu, 24 Oct 2019 07:17:55 -0700 (PDT) X-Google-Smtp-Source: APXvYqzRCad1rCmavfmZBhw/BBgrVTp75me60LKBBc/Y+blT1C17Pu9Ymxyl3IzOO6IgGdLUhsD8 X-Received: by 2002:a05:6402:643:: with SMTP id u3mr26346021edx.60.1571926675746; Thu, 24 Oct 2019 07:17:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571926675; cv=none; d=google.com; s=arc-20160816; b=SSQmLJg3dePwxyjCSTgq1JYwGX9WAp9Do5FDpKS4TfeA23lwdoxQYfJBwENoQP1Ik0 dxdBkwhUovGfrLLuP1dEp5fPC9gLDQ1ajKgXy0GAc0mgMsdllRk1H1hG9BzhDPCM2xWf Kr+BduGF9xtI9Fz+S0Ln5qdvjunhvKxEkaeEUNYWUH97wsSA0s05guhG6I9QJxwovd5e IAk+b00ELfV6GqgiLKtulh2KptkNzpzT0DglpVA6fiHmgT4cle6KsfVCtHIh6XJ/Y/jr AVqun9seYoFiGmMCxg7exc+urRK+4kzlRHcrzNx+75I2SGMFoLXyrotSmfUFIZq6XlEA fJ+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:cc:to:from :subject:organization:dkim-signature; bh=Y5oBrUtAQ9C0QhrzjBJAL+muXoHgzb+Th6vM8rdAcVs=; b=CaZWRSv3IUkLHTYoMJlTrQfC7b+mh5YtfWcAFYvQ+/N0q5MZc3tln7OE61cL7vJVOO 8XccgtfuowpuCPm4alAGufuSdAIbixajIDS4zBOh6mKxOCHOmFuUd2r8lQPeNgqFa8wx GTgl8Mymjls0BcAM7yTs+bloGUZUb57u00UC4y59NWRyh/PN7dm58ssj9aZQu+diWLcf u0BeboOuuy7EJVGmx7iU1ixL4OLhDZBVe0Ah9bxPvW/J+WNc6drOk0a+d7VCPg/JWQR9 w6E7N0yzL542bsRT7p/PnohjXZ21kb18uwCpTWSlGIMPaOtyK4ASBUjZTnFjpPOu8xeo QBmw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Ea287AW2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t4si14577405edc.171.2019.10.24.07.17.30; Thu, 24 Oct 2019 07:17:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Ea287AW2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407478AbfJWUSi (ORCPT + 99 others); Wed, 23 Oct 2019 16:18:38 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:34792 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2407467AbfJWUSh (ORCPT ); Wed, 23 Oct 2019 16:18:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571861916; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y5oBrUtAQ9C0QhrzjBJAL+muXoHgzb+Th6vM8rdAcVs=; b=Ea287AW2XIPF+citlEhjKs4KbG6R09vARa2undLGO5ndEzvP07Yu0z37g4zrBVrhKDfwoC 27LNLDZNufmTzexIWWkWYQikrB8YqMkM+QJnv+v8vh+LR+Zruw5mo60o+bL37LMn/K+Jlg dyImMzyuoDv92m5VdLq//ZgudM5ggzI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-197-15ykxvHfOZeZpt2NssVyQw-1; Wed, 23 Oct 2019 16:18:33 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4FEC7107AD31; Wed, 23 Oct 2019 20:18:31 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-121-40.rdu2.redhat.com [10.10.121.40]) by smtp.corp.redhat.com (Postfix) with ESMTP id BB1715DD7A; Wed, 23 Oct 2019 20:18:28 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 Subject: [RFC PATCH 09/10] pipe: Remove redundant wakeup from pipe_write() [ver #2] From: David Howells To: torvalds@linux-foundation.org Cc: dhowells@redhat.com, Rasmus Villemoes , Greg Kroah-Hartman , Peter Zijlstra , nicolas.dichtel@6wind.com, raven@themaw.net, Christian Brauner , dhowells@redhat.com, keyrings@vger.kernel.org, linux-usb@vger.kernel.org, linux-block@vger.kernel.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 23 Oct 2019 21:18:28 +0100 Message-ID: <157186190801.3995.3420819228734631242.stgit@warthog.procyon.org.uk> In-Reply-To: <157186182463.3995.13922458878706311997.stgit@warthog.procyon.org.uk> References: <157186182463.3995.13922458878706311997.stgit@warthog.procyon.org.uk> User-Agent: StGit/unknown-version MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: 15ykxvHfOZeZpt2NssVyQw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove a redundant wakeup from pipe_write(). Signed-off-by: David Howells --- fs/pipe.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/fs/pipe.c b/fs/pipe.c index 1bfad2212b95..3df93990dd9d 100644 --- a/fs/pipe.c +++ b/fs/pipe.c @@ -516,11 +516,6 @@ pipe_write(struct kiocb *iocb, struct iov_iter *from) =09=09=09=09ret =3D -ERESTARTSYS; =09=09=09break; =09=09} -=09=09if (do_wakeup) { -=09=09=09wake_up_interruptible_sync_poll(&pipe->wait, EPOLLIN | EPOLLRDNOR= M); -=09=09=09kill_fasync(&pipe->fasync_readers, SIGIO, POLL_IN); -=09=09=09do_wakeup =3D 0; -=09=09} =09=09pipe->waiting_writers++; =09=09pipe_wait(pipe); =09=09pipe->waiting_writers--;