Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 23 Oct 2019 15:30:40 -0700
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Waiman Long <longman@redhat.com>
Cc:     Qian Cai <cai@lca.pw>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, Johannes Weiner <hannes@cmpxchg.org>,
        Michal Hocko <mhocko@kernel.org>, Roman Gushchin <guro@fb.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        Konstantin Khlebnikov <khlebnikov@yandex-team.ru>,
        Jann Horn <jannh@google.com>, Song Liu <songliubraving@fb.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Rafael Aquini <aquini@redhat.com>
Subject: Re: [PATCH] mm/vmstat: Reduce zone lock hold time when reading
 /proc/pagetypeinfo
Message-Id: <20191023153040.c7fff4bc7c86ed605fc4667f@linux-foundation.org>
In-Reply-To: <a4398f60-c07e-8fa9-c26d-3b8f688e65a1@redhat.com>
References: <20191022162156.17316-1-longman@redhat.com>
        <20191022145902.d9c4a719c0b32175e06e4eee@linux-foundation.org>
        <2236495a-ead0-e08e-3fb6-f3ab906b75b6@redhat.com>
        <1571842093.5937.84.camel@lca.pw>
        <a4398f60-c07e-8fa9-c26d-3b8f688e65a1@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 23 Oct 2019 11:01:04 -0400 Waiman Long <longman@redhat.com> wrote:

> On 10/23/19 10:48 AM, Qian Cai wrote:
> >>> this still isn't a bulletproof fix.  Maybe just terminate the list
> >>> walk if freecount reaches 1024.  Would anyone really care?
> >>>
> >>> Sigh.  I wonder if anyone really uses this thing for anything
> >>> important.  Can we just remove it all?
> >>>
> >> Removing it will be a breakage of kernel API.
> > Who cares about breaking this part of the API that essentially nobody will use
> > this file?
> >
> There are certainly tools that use /proc/pagetypeinfo and this is how
> the problem is found. I am not against removing it, but we have to be
> careful and deprecate it in way that minimize user impact.

Yes, removing things is hard.  One approach is to add printk_once(this
is going away, please email us if you use it) then wait a few years. 
Backport that one-liner into -stable kernels to hopefully speed up the
process.

Meanwhile, we need to fix the DoS opportunity.  How about my suggestion
that we limit the count to 1024, see if anyone notices?  I bet they
don't!