Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp2506198ybg; Thu, 24 Oct 2019 10:43:16 -0700 (PDT) X-Google-Smtp-Source: APXvYqyf+5Zy5th8RWRRLbjCpV/jI+3EeRl/NT3IQRllPnvhxBIsqmMmYZQbtQfJafw5UJLYTn7a X-Received: by 2002:a17:906:5f8a:: with SMTP id a10mr15518971eju.204.1571938996319; Thu, 24 Oct 2019 10:43:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571938996; cv=none; d=google.com; s=arc-20160816; b=AeLmLXr9LtjGz6HcKddlLj/jdAC+mPxBZ7uv8MPjn02oYWByInGgkWbuB08Kqa3CAn GEebyojY7DDJ1Uq+RiHFSrH15wnZhosmQnYBZO3HcLLRUeTk4cjctWHOTJIDuAc/fxyp GrFLIQ2EzA85QmJ8Q0FtWAR+IKqDR3m7IO879C9Zv2fj/BbPSibM31A92CIx3fMFO8n7 Ky+G4/dYT34Qinf6nZFMm5dga1J/0Gq9vewXhu1hAEU60xB9tUleZu8g7dYENEM4ZVq3 nfYydWG8nbnXPJy8t9AG6wrIfqb6DVI3MeR/VL7R1xgSt5TMQBiNYKS4ZVDgobRw6YRV UUmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=jD3ajuwfKZdk4JSIR8vGZp1pzv/W899TJw8TAPz4bwc=; b=Dnmez+TFZfTohgdww+9Z8aGdEg0iF+IWw1Aa3Jm7rG8beGhp2K9ThaZAoHnWCZydZF RP1MGALQAgEQ6EFLrS+NC1eZnlbobOQE6dMr5YVdigAV8DqA6y5l+cIRa0+kjV51bR7E s2a06HE7GlIzx/4skO9Z7xSEkZiHatNrbIY7UAzZ0RROQLekQT4KE/h70ezYvz0xGL+1 23BiLMsuxFMM1tUbuilYDBkeXVjAAwk9GhQIjZL7RJgKRDPLnYSmu2YGrLJt/Q9WnRFv r2yyEhXaViw2O8fJ6LQc4X5yicFtLswvAmDh/YFXZCglZimn2lgcIMvvlm6PFN1ovFmx WWqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=FRnJsusz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w54si10492932eda.214.2019.10.24.10.42.52; Thu, 24 Oct 2019 10:43:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=FRnJsusz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391733AbfJXB2v (ORCPT + 99 others); Wed, 23 Oct 2019 21:28:51 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:54770 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726925AbfJXB2v (ORCPT ); Wed, 23 Oct 2019 21:28:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=jD3ajuwfKZdk4JSIR8vGZp1pzv/W899TJw8TAPz4bwc=; b=FRnJsusz6bSIUrtKJ6Rs+PrZV Rc9FtFgXZBhIBEkKenmtYBEcir5YrbubUFQYHHfE9g3/FDpXB9kOL6/1Qi8+G01C/rQSE9aNme4yY MMUmUSJI9YGor3UtogZ2VQcLoi4/y5H1P5oNsd1xDjt91IesmvUN7ADATTlrxwp1MnQEiafDwsv/F LNFly8yS18xzdzOqDRwRCYir98guFp+/o/79TgnadysBMIB1udT59a6QXxt800zUNNA2746hL0T3H zlkrcgr/f2f6i3eHFi9uPvDkQD/xlBuvSX6NWogmJNaCUZQqy6hFOUK7QAqJowy+BBJYut9znFEQU jrUOn0UQA==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1iNRvl-0000AW-1o; Thu, 24 Oct 2019 01:28:49 +0000 Date: Wed, 23 Oct 2019 18:28:49 -0700 From: Christoph Hellwig To: Omer Shpigelman Cc: Christoph Hellwig , "oded.gabbay@gmail.com" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 1/2] habanalabs: support kernel memory mapping Message-ID: <20191024012849.GB32358@infradead.org> References: <20191022063028.9030-1-oshpigelman@habana.ai> <20191023092035.GA12222@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 23, 2019 at 01:39:41PM +0000, Omer Shpigelman wrote: > I'm not sure I understand. Can you please pin point the problematic line? Every line you touch addr field basically. If you have a kernel address please store it in an actual C pointer type, not in a u64 to ensure that the compiler can do proper type checking.