Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp2642155ybg;
        Thu, 24 Oct 2019 12:54:39 -0700 (PDT)
X-Google-Smtp-Source: APXvYqwtwZNSg70msNpyOJZhB/Okkz0iEyk5QicKwQQZlYA/LLWd8U8tAfBQNPpTRWXrdTMM7d/0
X-Received: by 2002:a17:906:3197:: with SMTP id 23mr3793661ejy.156.1571946879721;
        Thu, 24 Oct 2019 12:54:39 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1571946879; cv=none;
        d=google.com; s=arc-20160816;
        b=NunaHNnmlcClghc4n3v5bEsu7L9ecAZlmDoOyGFy2sV7BOfgSHRcw9AfxBGdNw45GP
         Rz3lFFW18xjWEt6PJbsIa4frUfeakmdyx/zh9pPFqVZyvQwb7uTDBk1fPT+t5E+pasL6
         60ZEA7c7bXwxDS4PEl3Ju3pk43V5W5YTJDddJpLHckRMhzbziKLRopKHXHaClmexNVZF
         G2PEm/QQpXENdJzK8lD2P2beE54MiQWgCQQ5pxbX+DufBJRCuO02uycMLHDVLkuKMpIG
         leYJQhhvsjltKZgcCclijqGYIZBXFKCAThW5tB60DMApQcCmtoufo4ZnBWrpJdd/55ig
         Baiw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version;
        bh=tqY8MkrFlRuB64lQselPYGZKvMHD/g09EyqNLXd31OI=;
        b=DQdq7yIzOnQtK2tad/hdZzI28opdcBfk7e3Zt/97Xxb1KteMADZiorLGAlRXyY0GOw
         PPqqrbOaLIFZbKHlMIVcSQC8wHCYulghiVgAIfELN9s+DQSCwldVYOXF5Ebmf6fR5HH4
         vBzLgLFJgvLZTlim0DIbSn0dNpgBok5rTz5SbJBkVLKGiYXr5T1egrYc8aVr3ZNu+L1Z
         ehJeXamf58hYxgzWdFOiRdx+M/dMcy/Dt+QcY/CLsruxgaUCrZ8njUaht0aWOlzOB/+I
         gQVCbRzjnniSMSU0qOFZ4wISW1mvidIJHygGZ5J6D5Ch63BoP1rNueRvOSJJ+xeuqakz
         YqGA==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id fy18si11451393ejb.371.2019.10.24.12.54.14;
        Thu, 24 Oct 2019 12:54:39 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S2392433AbfJXDvZ (ORCPT
        <rfc822;paul.schmitz.hallo.parkuhr@gmail.com> + 99 others);
        Wed, 23 Oct 2019 23:51:25 -0400
Received: from mail-ed1-f66.google.com ([209.85.208.66]:38053 "EHLO
        mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S2390377AbfJXDvY (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 23 Oct 2019 23:51:24 -0400
Received: by mail-ed1-f66.google.com with SMTP id y8so5190299edu.5
        for <linux-kernel@vger.kernel.org>; Wed, 23 Oct 2019 20:51:23 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=tqY8MkrFlRuB64lQselPYGZKvMHD/g09EyqNLXd31OI=;
        b=tW5tO2aI0Wm8eYh5okwLDaEw5rqNRh8KOMa0tuSTIf25LnKze+O/ZZPORvSnvc6xvS
         dHGH532/QLE8jUR94nquPNBpEzbovgiQ8CyfB6nSkgSi7qpbPjXv8yurs0leivhLq/yW
         KekOqqO6d9zOyrwKXQ36vqvEPVN9ZHpU2kjKLShbyJRGzZ/z7ZsaUutTN/lEfJ0c4OyO
         PMFgymzvk6cmLBnjLHqJjKKsYiUmBKxExVHQVPY0Ggr/82IU8NWcyG7en1gCWxJdYpy9
         BRU8QmV7tgQHTyLmUJDikhoBdPk30+04GPv0BIQPPsxb6hjNPSyINK0qo5Ivkl7FfR6c
         uK8Q==
X-Gm-Message-State: APjAAAX9SZ4qogNlRFVlQsUvbxHP5JDfzF0JWBona24A+wGX72/vly+0
        FfbLTj37o4Z05bW0TNyHjGxSxHdP/so=
X-Received: by 2002:a50:af45:: with SMTP id g63mr40404898edd.21.1571889082665;
        Wed, 23 Oct 2019 20:51:22 -0700 (PDT)
Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com. [209.85.128.50])
        by smtp.gmail.com with ESMTPSA id b22sm56795ejq.87.2019.10.23.20.51.22
        for <linux-kernel@vger.kernel.org>
        (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
        Wed, 23 Oct 2019 20:51:22 -0700 (PDT)
Received: by mail-wm1-f50.google.com with SMTP id q130so827055wme.2
        for <linux-kernel@vger.kernel.org>; Wed, 23 Oct 2019 20:51:22 -0700 (PDT)
X-Received: by 2002:a1c:c90f:: with SMTP id f15mr2815314wmb.125.1571889081917;
 Wed, 23 Oct 2019 20:51:21 -0700 (PDT)
MIME-Version: 1.0
References: <20191023120925.30668-1-tomeu.vizoso@collabora.com> <20191023122157.32067-1-tomeu.vizoso@collabora.com>
In-Reply-To: <20191023122157.32067-1-tomeu.vizoso@collabora.com>
From:   Chen-Yu Tsai <wens@csie.org>
Date:   Thu, 24 Oct 2019 11:51:12 +0800
X-Gmail-Original-Message-ID: <CAGb2v675oCOr6JR6CXB28hrUuwBN2M9C9SS6UPNpbEAfw9ztjA@mail.gmail.com>
Message-ID: <CAGb2v675oCOr6JR6CXB28hrUuwBN2M9C9SS6UPNpbEAfw9ztjA@mail.gmail.com>
Subject: Re: [PATCH v2] panfrost: Properly undo pm_runtime_enable when
 deferring a probe
To:     Tomeu Vizoso <tomeu.vizoso@collabora.com>
Cc:     linux-kernel <linux-kernel@vger.kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        Rob Herring <robh@kernel.org>, David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        dri-devel <dri-devel@lists.freedesktop.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Oct 23, 2019 at 8:22 PM Tomeu Vizoso <tomeu.vizoso@collabora.com> wrote:
>
> When deferring the probe because of a missing regulator, we were calling
> pm_runtime_disable even if pm_runtime_enable wasn't called.
>
> Move the call to pm_runtime_disable to the right place.
>
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> Reported-by: Chen-Yu Tsai <wens@csie.org>
> Cc: Robin Murphy <robin.murphy@arm.com>
> Fixes: f4a3c6a44b35 ("drm/panfrost: Disable PM on probe failure")

Tested-by: Chen-Yu Tsai <wens@csie.org>