Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750813AbWAICNK (ORCPT ); Sun, 8 Jan 2006 21:13:10 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750826AbWAICNJ (ORCPT ); Sun, 8 Jan 2006 21:13:09 -0500 Received: from jack.kinetikon.it ([62.152.125.81]:58753 "EHLO mail.towertech.it") by vger.kernel.org with ESMTP id S1750813AbWAICNI convert rfc822-to-8bit (ORCPT ); Sun, 8 Jan 2006 21:13:08 -0500 Date: Mon, 9 Jan 2006 03:13:39 +0100 From: Alessandro Zummo To: Dmitry Torokhov Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/8] RTC subsystem, sysfs interface Message-ID: <20060109031339.6c661d9c@inspiron> In-Reply-To: <200601082102.40992.dtor_core@ameritech.net> References: <20060108231235.153748000@linux> <20060108231254.952993000@linux> <200601082102.40992.dtor_core@ameritech.net> Organization: Tower Technologies X-Mailer: Sylpheed Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 954 Lines: 33 On Sun, 8 Jan 2006 21:02:40 -0500 Dmitry Torokhov wrote: > On Sunday 08 January 2006 18:12, Alessandro Zummo wrote: > > +static ssize_t rtc_sysfs_show_date(struct class_device *dev, char *buf) > > +{ > > +???????ssize_t retval = -ENODEV; > > +???????struct rtc_device *rtc = to_rtc_device(dev); > > +???????struct rtc_time tm; [...] > ops locking is a mess here. Half of the code accesses it under protection > of ops_lock while other half is unlocked. I think it would be better if > that lock was taken in rtc_read_time and friends. Good point. I'll move them, thanks. -- Best regards, Alessandro Zummo, Tower Technologies - Turin, Italy http://www.towertech.it - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/