From: Dmitry Torokhov <dtor_core@ameritech.net>
To: Alessandro Zummo <alessandro.zummo@towertech.it>
Subject: Re: [PATCH 4/8] RTC subsystem, proc interface
Date: Sun, 8 Jan 2006 21:50:55 -0500
User-Agent: KMail/1.8.3
Cc: Alessandro Zummo <a.zummo@towertech.it>, linux-kernel@vger.kernel.org
References: <20060108231235.153748000@linux> <200601082056.30227.dtor_core@ameritech.net> <20060109030433.581c49e7@inspiron>
In-Reply-To: <20060109030433.581c49e7@inspiron>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 8BIT
Content-Disposition: inline
Message-Id: <200601082150.55926.dtor_core@ameritech.net>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1345
Lines: 37

On Sunday 08 January 2006 21:04, Alessandro Zummo wrote:
> On Sun, 8 Jan 2006 20:56:29 -0500
> Dmitry Torokhov <dtor_core@ameritech.net> wrote:
> 
> > > +static void rtc_proc_remove_device(struct class_device *class_dev,
> > > +??????????????????????????????????????? ? ? ?struct class_interface *class_intf)
> > > +{
> > > +???????down(&rtc_sem);
> > > +???????if (rtc_dev == class_dev) {
> > > +???????????????remove_proc_entry("driver/rtc", NULL);
> > > +???????????????rtc_dev = NULL;
> > > +???????}
> > > +???????up(&rtc_sem);
> > > +}
> > 
> > What if I happen to remove (unregister) rtc devices in order other
> > than they were registered in? You need a counter there instead of
> > storing the first device created.
> 
>  Only the first device that registers will get the /proc/driver/rtc
>  entry, which will be removed when the driver unregisters.
> 
>  /proc/driver/rtc is a legacy interface, thus supporting it
>  for more than one RTC is useless. Any system that uses
>  more than one RTCs should access them via /dev/rtcX or
>  via sysfs.
> 

Oh, I see. Ignore me then... 

-- 
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/