Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 24 Oct 2019 10:24:01 +0200
From:   Jiri Olsa <jolsa@redhat.com>
To:     Igor Lubashev <ilubashe@akamai.com>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/3] perf: Allow running without stdin
Message-ID: <20191024082401.GA13378@krava>
References: <1571795693-23558-1-git-send-email-ilubashe@akamai.com>
MIME-Version: 1.0
In-Reply-To: <1571795693-23558-1-git-send-email-ilubashe@akamai.com>
User-Agent: Mutt/1.12.1 (2019-06-15)
Content-Type: text/plain; charset=WINDOWS-1252
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Oct 22, 2019 at 09:54:50PM -0400, Igor Lubashev wrote:
> This series allows perf to run in batch mode with stdin closed.
> This is arguably a bug fix for code that runs with --stdio option and doe=
s not
> check for EOF return code from getc().
>=20
> This series makes the following work as expected:
>=20
>   $ perf top --stdio < /dev/null
>   $ perf kvm top --stdio < /dev/null
>=20
> Patches:
>   01: perf top: Allow running without stdin
>     Make "perf top --stdio" handle EOF from stdin correctly.
>     There is one getc() that does not handle EOF explicitly, since its re=
turn
>     value is checked against a list of known characters, and the main loo=
p in
>     display_thread() will handle the EOF on the next iteration.
>=20
>   02: perf kvm: Allow running without stdin
>     Make "perf kvm --stdio" handle EOF from stdin correctly.
>=20
>   03: perf kvm: Use evlist layer api when possible
>     This is a simple fix for a needless layering violation.
>=20
> Igor Lubashev (3):
>   perf top: Allow running without stdin
>   perf kvm: Allow running without stdin
>   perf kvm: Use evlist layer api when possible

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka

>=20
>  tools/perf/builtin-kvm.c | 35 +++++++++++++++++++++--------------
>  tools/perf/builtin-top.c | 10 ++++++++--
>  2 files changed, 29 insertions(+), 16 deletions(-)
>=20
> --=20
> 2.7.4
>=20