Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp3536235ybg; Fri, 25 Oct 2019 05:42:59 -0700 (PDT) X-Google-Smtp-Source: APXvYqx02mAPOMLTMp+4IEGxN99K8F/j83wnbH7ZpWXEvKx44PORmYYEezGZMs4vacgJkK+PuBrE X-Received: by 2002:a17:906:79cf:: with SMTP id m15mr3185189ejo.79.1572007379886; Fri, 25 Oct 2019 05:42:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572007379; cv=none; d=google.com; s=arc-20160816; b=cqhS0g7cf9fNXcRCYlM1e14aXDctnM8UnzC6L5E2yE7DUnbEXhgAu+tn8MJaAPpCOG /IvuRiu07BjmdfXpCl/Li/sjKaFVJnr+Z41nRpovMIguXXCGbYbzParbNzvS8ZxOb0Rb xXFuGOh9u+HVrJHqdQfOYho+xxWoyE+ivOeT5KCYb6osC99MBZZL8sutWD5fwYM5NiiN hnUWM4tMsqmIH00dRhO6U907ibyMnAYJewoJInGoEjC7Lm7RTJjn0P2HmHkQyy+ts22d vx/E31+2zn4J/jHqdGY/EopbSDUE/vQO57vBiK7Bju5QeiZXdYmRXwch6jxeqHte+pQw keWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=NgbYS/kTOZkSPLuBzFcVDZXs2ymgPWmgApsJDE0G9To=; b=xseSjE6YIA9IXdMZJxBR6SdJ6TJsnLm9s/s5rHUJu3eevywLDbJ0QLSlNczHn/pPef wmp59kMG+7aZV3bpB7T2MvBebdVcaBuuFDSWVstQDJTsPFhLONhH/UD6vkKtxcW2f8aA h6vTUBFCBMpmCTKamHl6wPyD6qM3QlYFdK/gR/OduWuLhmT3at22riQztS8mg8uuBaU6 u+y6kGBnjSDZgzLVZ9TWnQHu1VtK3oQRz0g/RYdbCha5cCkQdPGe6IheramQ9GneAeQM PzVDT6ZhyVPLnycqhrYbfa1vUSl2SFzSJ27WUalsOczGt37pO8MqDFKEsCv0EqvzaLgW C24Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v8si1142341eja.227.2019.10.25.05.42.36; Fri, 25 Oct 2019 05:42:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2439503AbfJXLyo (ORCPT + 99 others); Thu, 24 Oct 2019 07:54:44 -0400 Received: from 6.mo173.mail-out.ovh.net ([46.105.43.93]:47485 "EHLO 6.mo173.mail-out.ovh.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726298AbfJXLyn (ORCPT ); Thu, 24 Oct 2019 07:54:43 -0400 Received: from player737.ha.ovh.net (unknown [10.108.35.210]) by mo173.mail-out.ovh.net (Postfix) with ESMTP id 56DBC11D3C0 for ; Thu, 24 Oct 2019 09:06:16 +0200 (CEST) Received: from kaod.org (lns-bzn-46-82-253-208-248.adsl.proxad.net [82.253.208.248]) (Authenticated sender: groug@kaod.org) by player737.ha.ovh.net (Postfix) with ESMTPSA id DFAA11E5A0F5; Thu, 24 Oct 2019 07:05:28 +0000 (UTC) Date: Thu, 24 Oct 2019 09:05:27 +0200 From: Greg Kurz To: Sean Christopherson Cc: Marc Zyngier , James Hogan , Paul Mackerras , Christian Borntraeger , Janosch Frank , Paolo Bonzini , Radim =?UTF-8?B?S3LEjW3DocWZ?= , James Morse , Julien Thierry , Suzuki K Poulose , David Hildenbrand , Cornelia Huck , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/45] KVM: PPC: Book3S PR: Free shared page if mmu initialization fails Message-ID: <20191024090527.6b73a3bc@bahia.lan> In-Reply-To: <20191022015925.31916-3-sean.j.christopherson@intel.com> References: <20191022015925.31916-1-sean.j.christopherson@intel.com> <20191022015925.31916-3-sean.j.christopherson@intel.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Ovh-Tracer-Id: 5577708138938931537 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedufedrledtgdduudegucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddm Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 21 Oct 2019 18:58:42 -0700 Sean Christopherson wrote: > Explicitly free the shared page if kvmppc_mmu_init() fails during > kvmppc_core_vcpu_create(), as the page is freed only in > kvmppc_core_vcpu_free(), which is not reached via kvm_vcpu_uninit(). > > Fixes: 96bc451a15329 ("KVM: PPC: Introduce shared page") > Cc: stable@vger.kernel.org > Signed-off-by: Sean Christopherson > --- Reviewed-by: Greg Kurz > arch/powerpc/kvm/book3s_pr.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/powerpc/kvm/book3s_pr.c b/arch/powerpc/kvm/book3s_pr.c > index cc65af8fe6f7..3f6ad3f58628 100644 > --- a/arch/powerpc/kvm/book3s_pr.c > +++ b/arch/powerpc/kvm/book3s_pr.c > @@ -1769,10 +1769,12 @@ static struct kvm_vcpu *kvmppc_core_vcpu_create_pr(struct kvm *kvm, > > err = kvmppc_mmu_init(vcpu); > if (err < 0) > - goto uninit_vcpu; > + goto free_shared_page; > > return vcpu; > > +free_shared_page: > + free_page((unsigned long)vcpu->arch.shared); > uninit_vcpu: > kvm_vcpu_uninit(vcpu); > free_shadow_vcpu: