Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp3717287ybg; Fri, 25 Oct 2019 08:02:11 -0700 (PDT) X-Google-Smtp-Source: APXvYqzWO4NKgGXmAPTEGyYTJPTcb/L9cnkVX6feiTxQGmq1Hwn1OdDBRSLsxzLaYEox2npmd9Yb X-Received: by 2002:a05:6402:328:: with SMTP id q8mr4359555edw.136.1572015731595; Fri, 25 Oct 2019 08:02:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572015731; cv=none; d=google.com; s=arc-20160816; b=ZLRpaFy63wikFYH8UbMdXebrNYqK3yiXQWm5CSK6dMMD+sHCNGkasdEdsR+t11j20m 0XXUEqw5PwgZmij3wRdsYwPGtgBD+HD0SDpmL/pp3rAXAi2Cgueba9HgkqWzSDqBr0X0 ghvxRgGOO/jmEBM2ibpw4vvKHAQom37mkop4woMTi4tP7jhfXsugj4vFPU4KnAb4KQ6E JQlmineSOkQODMnQbd8TfK6+AZizhPo83/9RgKy1x9FBGQzrL8qnOKgxEP6QtDVzp6h7 +z+rMVedNWaWj3dsa8ad3zT4qyH/3bAOKbmJXXmRhNZNFGJ40vAW4s/80CI67gScxr62 2LIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=5Anddj229tZy866HidMF8Epzg/ueEqbOCuwRqkKuMGk=; b=xvF4EHAd3lAHOLk/je0pIrPkYCRYs6vkpTv+ryRzINJ3uNgs5pL89CoA3BMnzyYG+R muUK/XzE/JLlEQmBS3dadq9RrTWFZCrqH4NiMAIYgNWJ62MfGyX45YOdyzU0AumgYYwc Xr1148N94ksgxKhziRtacg6Yv+/cR3rZ78oMgWm+WxZR3nP9tOSk0GeCCOGjz5XLnauo HE77k0DvoY1MM0rmzk+rORvfA25RbcLxNMJx0j6kR9hGGafc8JNAR7ENmHax2N/Ijzqg oRXvh0wF6su1Z02uDPI+mClw98+FbAVl9kXZoq38QWgoEbZE9wg87euyqztbYkfPd3bh AfOg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 92si1692101edh.321.2019.10.25.08.01.46; Fri, 25 Oct 2019 08:02:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2504011AbfJXSRf convert rfc822-to-8bit (ORCPT + 99 others); Thu, 24 Oct 2019 14:17:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:59672 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404839AbfJXSRf (ORCPT ); Thu, 24 Oct 2019 14:17:35 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A204D20684; Thu, 24 Oct 2019 18:17:33 +0000 (UTC) Date: Thu, 24 Oct 2019 14:17:31 -0400 From: Steven Rostedt To: Peter Zijlstra Cc: x86@kernel.org, linux-kernel@vger.kernel.org, mhiramat@kernel.org, bristot@redhat.com, jbaron@akamai.com, torvalds@linux-foundation.org, tglx@linutronix.de, mingo@kernel.org, namit@vmware.com, hpa@zytor.com, luto@kernel.org, ard.biesheuvel@linaro.org, jpoimboe@redhat.com, jeyu@kernel.org Subject: Re: [PATCH v4 15/16] module: Move where we mark modules RO,X Message-ID: <20191024141731.5c7c414c@gandalf.local.home> In-Reply-To: <20191024164320.GD4131@hirez.programming.kicks-ass.net> References: <20191018073525.768931536@infradead.org> <20191018074634.801435443@infradead.org> <20191021222110.49044eb5@oasis.local.home> <20191022202401.GO1817@hirez.programming.kicks-ass.net> <20191023145245.53c75d70@gandalf.local.home> <20191024101609.GA4131@hirez.programming.kicks-ass.net> <20191024110024.324a9435@gandalf.local.home> <20191024164320.GD4131@hirez.programming.kicks-ass.net> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 24 Oct 2019 18:43:20 +0200 Peter Zijlstra wrote: > > > > CC [M] drivers/gpu/drm/i915/gem/i915_gem_context.o > > /work/git/linux-trace.git/kernel/trace/trace_events_hist.c: In function ‘register_synth_event’: > > /work/git/linux-trace.git/kernel/trace/trace_events_hist.c:1157:15: error: ‘struct trace_event_class’ has no member named ‘define_fields’; did you mean ‘get_fields’? > > call->class->define_fields = synth_event_define_fields; > > ^~~~~~~~~~~~~ > > get_fields > > make[3]: *** [/work/git/linux-trace.git/scripts/Makefile.build:265: kernel/trace/trace_events_hist.o] Error 1 > > make[3]: *** Waiting for unfinished jobs.... > > allmodconfig clean > > (omg, so much __field(); fail) Well it built without warnings and passed the ftrace selftests. I haven't ran it through the full suite, but that can wait for the v5. -- Steve