Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp3992217ybg; Fri, 25 Oct 2019 11:47:40 -0700 (PDT) X-Google-Smtp-Source: APXvYqygZkTxS6LRwgntfMin5k2JyZKcVrZ/VSmQZBNQ7cjLhe9n/UtVMxhvn/awSClrcGpYMsq/ X-Received: by 2002:aa7:d0c9:: with SMTP id u9mr5440591edo.217.1572029259955; Fri, 25 Oct 2019 11:47:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572029259; cv=none; d=google.com; s=arc-20160816; b=lXg8sqkwyPE67L0Tu+nHf8zLfRSNAKR6kvk6CRySxZwfZMQpwuk8UhQ/740GdpOOrs 8caHYvVIn8ZGZDdnaZwbrUQWNL+T89+lSvpzoLa2pmbdhjVe7DJvMLqK+5SYW93K7z3D pxf1FUsUKdy62g67H2gjm9gkwoOejl8cgZqhswzP3DjxvwnFCbvQ9dPrGFOP0/UqXkSs 2wpfnJhZ+MeZfYDmbFQGRg9Bo5NoXmfFBLfUMWKDBbIurDyGpbfAQqT8b1jYmZ7J3KXj QTSzGrLFwF2FYjIE6T0hjyhQT9RsPUXl/Ty5XJs3t4mGohBI/NNMbuiXf/XG8IPMyCcJ TOTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature:dkim-filter; bh=5R3b8oxPvTR6qGGx7vVi+OuiVSZNkllUsHU4qd/a/nE=; b=fGUKskZeyL1GqtcTOd/ccE7f1IgKxTk/kOkIZhBMHIlhJVI1Te48QhrN4vWt5iPXtH JEOYA+PXOJQs3ihT6XxGEUnQs4NywqkJnvlpbgzt8jZwm695Hs1Bav4aN0MkcBqGrOwy FYKSuq3yw68pPw/V6Xdt71XuP8wd1wVucQvEsgFb+ZcobvGLnLXMxsUNAZ+5Vn1giWIF 9j72MubQzdyIi+f9CrPBLnnstC+L3ZyNuqZqI6JyDLCAQ+vnejUqzXR0KalY9GSaX8uu mXl+RHosm9aAXaJwqHwGA0iqvA0c49P5M42dH/dHdRbsBg11IFMIKs+qC37MCkwohRvi 2hhQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=OSCT2Wjd; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bq16si1738214ejb.221.2019.10.25.11.47.16; Fri, 25 Oct 2019 11:47:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=OSCT2Wjd; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394011AbfJXR0b (ORCPT + 99 others); Thu, 24 Oct 2019 13:26:31 -0400 Received: from linux.microsoft.com ([13.77.154.182]:54710 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389384AbfJXR0b (ORCPT ); Thu, 24 Oct 2019 13:26:31 -0400 Received: from [10.137.112.111] (unknown [131.107.147.111]) by linux.microsoft.com (Postfix) with ESMTPSA id 3B2552007698; Thu, 24 Oct 2019 10:26:30 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 3B2552007698 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1571937990; bh=5R3b8oxPvTR6qGGx7vVi+OuiVSZNkllUsHU4qd/a/nE=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=OSCT2WjdmQ1xniyUn2/peoWgE9ycpc8Wc2ZzDicCH9kewV38vZAm5RmcKcKk8JDul vNhWVweVtxUsfZF4xhG/qHuI8Rd7EwsQ+Nok8m5DqU4EetWGl4pOiPxKH5SORqCBkb rOGzLTADWSqaGBt2UxTEU3rZBd/6AnlKTOr8YOeI= Subject: Re: [PATCH v9 1/8] powerpc: detect the secure boot mode of the system To: Nayna Jain , linuxppc-dev@ozlabs.org, linux-efi@vger.kernel.org, linux-integrity@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Ard Biesheuvel , Jeremy Kerr , Matthew Garret , Mimi Zohar , Greg Kroah-Hartman , Claudio Carvalho , George Wilson , Elaine Palmer , Eric Ricther , Oliver O'Halloran , Prakhar Srivastava References: <20191024034717.70552-1-nayna@linux.ibm.com> <20191024034717.70552-2-nayna@linux.ibm.com> From: Lakshmi Ramasubramanian Message-ID: Date: Thu, 24 Oct 2019 10:26:47 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: <20191024034717.70552-2-nayna@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/23/2019 8:47 PM, Nayna Jain wrote: > This patch defines a function to detect the secure boot state of a > PowerNV system. > +bool is_ppc_secureboot_enabled(void) > +{ > + struct device_node *node; > + bool enabled = false; > + > + node = of_find_compatible_node(NULL, NULL, "ibm,secvar-v1"); > + if (!of_device_is_available(node)) { > + pr_err("Cannot find secure variable node in device tree; failing to secure state\n"); > + goto out; Related to "goto out;" above: Would of_find_compatible_node return NULL if the given node is not found? If of_device_is_available returns false (say, because node is NULL or it does not find the specified node) would it be correct to call of_node_put? > + > +out: > + of_node_put(node); -lakshmi