Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] scsi: lpfc: lpfc_nvmet.c: Fix Use plain integer as NULL
 pointer
To:     Saurav Girepunje <saurav.girepunje@gmail.com>,
        dick.kennedy@broadcom.com, jejb@linux.ibm.com,
        martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     saurav.girepunje@hotmail.com
References: <20191024030857.GA12097@saurav>
From:   James Smart <james.smart@broadcom.com>
Message-ID: <c08db818-8c35-e4a0-2ff3-53820075d859@broadcom.com>
Date:   Thu, 24 Oct 2019 11:15:30 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <20191024030857.GA12097@saurav>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 10/23/2019 8:09 PM, Saurav Girepunje wrote:
> Replace assignment of 0 to pointer with NULL assignment.
>
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> ---
>   drivers/scsi/lpfc/lpfc_nvmet.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_nvmet.c b/drivers/scsi/lpfc/lpfc_nvmet.c
> index faa596f9e861..f6ebfe05224c 100644
> --- a/drivers/scsi/lpfc/lpfc_nvmet.c
> +++ b/drivers/scsi/lpfc/lpfc_nvmet.c
> @@ -3364,7 +3364,7 @@ lpfc_nvmet_sol_fcp_issue_abort(struct lpfc_hba *phba,
>   	/* ABTS WQE must go to the same WQ as the WQE to be aborted */
>   	abts_wqeq->hba_wqidx = ctxp->wqeq->hba_wqidx;
>   	abts_wqeq->wqe_cmpl = lpfc_nvmet_sol_fcp_abort_cmp;
> -	abts_wqeq->iocb_cmpl = 0;
> +	abts_wqeq->iocb_cmpl = NULL;
>   	abts_wqeq->iocb_flag |= LPFC_IO_NVME;
>   	abts_wqeq->context2 = ctxp;
>   	abts_wqeq->vport = phba->pport;
> @@ -3499,7 +3499,7 @@ lpfc_nvmet_unsol_ls_issue_abort(struct lpfc_hba *phba,
>   
>   	spin_lock_irqsave(&phba->hbalock, flags);
>   	abts_wqeq->wqe_cmpl = lpfc_nvmet_xmt_ls_abort_cmp;
> -	abts_wqeq->iocb_cmpl = 0;
> +	abts_wqeq->iocb_cmpl = NULL;
>   	abts_wqeq->iocb_flag |=  LPFC_IO_NVME_LS;
>   	rc = lpfc_sli4_issue_wqe(phba, ctxp->hdwq, abts_wqeq);
>   	spin_unlock_irqrestore(&phba->hbalock, flags);

Thanks

Reviewed-by: James Smart <james.smart@broadcom.com>

-- james