Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Leonard Crestez <leonard.crestez@nxp.com>
To:     "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Viresh Kumar <viresh.kumar@linaro.org>
CC:     Linux PM <linux-pm@vger.kernel.org>,
        Linux ACPI <linux-acpi@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Sudeep Holla <sudeep.holla@arm.com>,
        Dmitry Osipenko <digetx@gmail.com>
Subject: Re: [RFT][PATCH 1/3] PM: QoS: Introduce frequency QoS
Thread-Topic: [RFT][PATCH 1/3] PM: QoS: Introduce frequency QoS
Thread-Index: AQHVhA83pBLldkQGO0OkZWmZhR1Vyw==
Date:   Thu, 24 Oct 2019 19:34:59 +0000
Message-ID: <VI1PR04MB70234EB305F60855491EBFDDEE6A0@VI1PR04MB7023.eurprd04.prod.outlook.com>
References: <2811202.iOFZ6YHztY@kreacher> <4551555.oysnf1Sd0E@kreacher>
 <VI1PR04MB7023ECFFD42193CF864524ACEE6A0@VI1PR04MB7023.eurprd04.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: c6efb7da-5afb-4dc2-ac8b-08d758b94208
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Oct 2019 19:34:59.5765
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: KdCTBZJfWmrP0PkF5mKuwWIAC7FW7T6LaKqkgPuuiV/NklpmFSikUTq9csnzyrJViVaWLeel/AOioOt9iY0Trw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6061
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 24.10.2019 22:01, Leonard Crestez wrote:=0A=
> On 16.10.2019 13:48, Rafael J. Wysocki wrote:=0A=
>> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>=0A=
>>=0A=
>> Introduce frequency QoS, based on the "raw" low-level PM QoS, to=0A=
>> represent min and max frequency requests and aggregate constraints.=0A=
>>=0A=
>> The min and max frequency requests are to be represented by=0A=
>> struct freq_qos_request objects and the aggregate constraints are to=0A=
>> be represented by struct freq_constraints objects.  The latter are=0A=
>> expected to be initialized with the help of freq_constraints_init().=0A=
>>=0A=
>> The freq_qos_read_value() helper is defined to retrieve the aggregate=0A=
>> constraints values from a given struct freq_constraints object and=0A=
>> there are the freq_qos_add_request(), freq_qos_update_request() and=0A=
>> freq_qos_remove_request() helpers to manipulate the min and max=0A=
>> frequency requests.  It is assumed that the the helpers will not=0A=
>> run concurrently with each other for the same struct freq_qos_request=0A=
>> object, so if that may be the case, their uses must ensure proper=0A=
>> synchronization between them (e.g. through locking).=0A=
>>=0A=
>> In addition, freq_qos_add_notifier() and freq_qos_remove_notifier()=0A=
>> are provided to add and remove notifiers that will trigger on aggregate=
=0A=
>> constraint changes to and from a given struct freq_constraints object,=
=0A=
>> respectively.=0A=
>>=0A=
>> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>=0A=
>> ---=0A=
>>    include/linux/pm_qos.h |   44 ++++++++=0A=
>>    kernel/power/qos.c     |  240 +++++++++++++++++++++++++++++++++++++++=
++++++++++=0A=
>>    2 files changed, 284 insertions(+)=0A=
>>=0A=
>> Index: linux-pm/include/linux/pm_qos.h=0A=
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0A=
>> --- linux-pm.orig/include/linux/pm_qos.h=0A=
>> +++ linux-pm/include/linux/pm_qos.h=0A=
>> @@ -267,4 +267,48 @@ static inline s32 dev_pm_qos_raw_resume_=0A=
>>    }=0A=
>>    #endif=0A=
>>    =0A=
>> +#define FREQ_QOS_MIN_DEFAULT_VALUE	0=0A=
>> +#define FREQ_QOS_MAX_DEFAULT_VALUE	(-1)=0A=
>> +=0A=
>> +enum freq_qos_req_type {=0A=
>> +	FREQ_QOS_MIN =3D 1,=0A=
>> +	FREQ_QOS_MAX,=0A=
>> +};=0A=
>> +=0A=
>> +struct freq_constraints {=0A=
>> +	struct pm_qos_constraints min_freq;=0A=
>> +	struct blocking_notifier_head min_freq_notifiers;=0A=
>> +	struct pm_qos_constraints max_freq;=0A=
>> +	struct blocking_notifier_head max_freq_notifiers;=0A=
> =0A=
> These min/max_freq_notifiers fields seem unused? They're initialized but=
=0A=
> the freq_qos_add/remove_notifier calls use min/max_freq.notifiers directl=
y.=0A=
> =0A=
> Should probably just be dropped.=0A=
=0A=
Never mind, I see now that pm_qos_constraints.notifiers is actually a =0A=
pointer to notifier block provided by somebody else.=0A=
=0A=
--=0A=
Regards,=0A=
Leonard=0A=