Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp4029027ybg; Fri, 25 Oct 2019 12:18:16 -0700 (PDT) X-Google-Smtp-Source: APXvYqxEfyh1JoO+IMELs5N4mzWdu88Kih7lwKfVuI+Br9Lwy3kaM4BzFcbDVoB62XCMjusS4/iK X-Received: by 2002:a50:af44:: with SMTP id g62mr5865318edd.164.1572031096376; Fri, 25 Oct 2019 12:18:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572031096; cv=none; d=google.com; s=arc-20160816; b=QRC9pCjqVfaaKf9lyKTTHIjf/tWACYeq8BjBDd1LYQI9mqnmPDRqVj1InulQnk36wI 5Nur6zZr2TGA4A6KXBe/BwSAt+o5TCg/6+nitQs0pa3fkG4T/CSViISdHX6bpuhgygjE GdQda4nYifeLA+Ptnx6RCwuLQk38WhxEruyiTXBlaa0bOW+Y40TWim9sUOrwOFCewHEM 1Pntb5qL4hM+bj6FbhuGFfer868rigni+k9pBJihl3+mJrHM6dfd01EithPEXOEJQD0Q 9g5Ww2ENC7VSVqYCywjndsQDyeHNAsyKV6EKkY/+YR2jWS8tplCdnMGV7iSfzDWhZs5b 2SiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=VRityUeXXzAVrWCTsOXmqYprwZfsFu9DDlBj+N+FqLw=; b=mfFK6nzkjer+bwBLZvrGMxXxXPXh/x4xejbtDBdBGdPMJtNuHZ5EaG9zqMhFurUNpF iWBPaN2kJC/KjT/CYThKZDnwB/dIg7z/4d7PcBmDsS9vBxz+FC0X93/akRCWVS4IFbTq 0cqZWVniVPxveVqhskmLaMGq0AHIz+5YVtZilRBI4+oqeOtzFff4PWJXb4bBnUsFsYWF M8jeOyp/SkBmbaM0jMqzuvByKGl1gueKFrASjBNE93YrAITZDS1bRB70N3STS9+HsGY0 kEV598pIMvZQ9xl2crRitiZqzq3GD3Trtkc6+exqwkqUO7YWhVYnIYuE/3lGtcwxXbLV yyEA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=T4Pk3Kom; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f54si1842597edb.255.2019.10.25.12.17.53; Fri, 25 Oct 2019 12:18:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=T4Pk3Kom; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732682AbfJYARw (ORCPT + 99 others); Thu, 24 Oct 2019 20:17:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:60998 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732374AbfJYARw (ORCPT ); Thu, 24 Oct 2019 20:17:52 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3A16E21929; Fri, 25 Oct 2019 00:17:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571962671; bh=rqD7W4s+LZOUcm0Bvx9xbKfspitHAUdWO36YJUu908M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=T4Pk3KomY52w6ti8D4zLshL8rlj/YqzLSsc7Wyzi+sJiH5DNvI0MGNQ6yAGlpz1Vi 0KUF7+uVm2NsFgpSJapNZj6LLQIs9+3Vgb6OsqijNpPAEovnfKjUuGK8W/gEQBi0hR GrNxiblyVCdMuPB5KMZiPUb067qMD6Zwd+o+WgQc= Date: Thu, 24 Oct 2019 20:17:50 -0400 From: Sasha Levin To: Alessio Balsini Cc: gregkh@linuxfoundation.org, stable@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com, Jens Axboe Subject: Re: [PATCH 4.4 4.9 4.14] loop: Add LOOP_SET_DIRECT_IO to compat ioctl Message-ID: <20191025001750.GE31224@sasha-vm> References: <20190805115309.GJ2349@hirez.programming.kicks-ass.net> <20191023171736.161697-1-balsini@android.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20191023171736.161697-1-balsini@android.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 23, 2019 at 06:17:36PM +0100, Alessio Balsini wrote: >[ Upstream commit fdbe4eeeb1aac219b14f10c0ed31ae5d1123e9b8 ] > >Enabling Direct I/O with loop devices helps reducing memory usage by >avoiding double caching. 32 bit applications running on 64 bits systems >are currently not able to request direct I/O because is missing from the >lo_compat_ioctl. > >This patch fixes the compatibility issue mentioned above by exporting >LOOP_SET_DIRECT_IO as additional lo_compat_ioctl() entry. >The input argument for this ioctl is a single long converted to a 1-bit >boolean, so compatibility is preserved. > >Cc: Jens Axboe >Signed-off-by: Alessio Balsini >Signed-off-by: Jens Axboe >Signed-off-by: Sasha Levin Queued up, thanks! -- Thanks, Sasha