Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp4031158ybg; Fri, 25 Oct 2019 12:20:03 -0700 (PDT) X-Google-Smtp-Source: APXvYqzoY5uNxuKzj5/sFySV+tPUjYi9o+qz1Nnga/3nKZSeK/+VjUwwnvBOd5/TOd2V5lCbVQC0 X-Received: by 2002:a05:6402:21c7:: with SMTP id bi7mr5789735edb.205.1572031202998; Fri, 25 Oct 2019 12:20:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572031202; cv=none; d=google.com; s=arc-20160816; b=WyRE33bwNpMur6tLTY19paCXYsXa61doIKiSOrsECFSKfHqf6AKiTWWJD8tJHz3cAS Y9nXd8IDeRrT05RXtvLVIOcSSfg03b7v+GbbTlCQrII4IaG9xY72FB99yU731y7M5DGb zRFEVBgXhT4fChgJAj+/8TXu7fNz86cMzvvkm2QSHQ8f+sbpq+A/Gqa1Lo4OJkPz1/fG oJFCY4BG1iB8Hp/VwiT27vm3KGtl1OGzucCszeS7eoOlZCJPbllI4Klfi+B+fP/Jtflb JfyDCsxdcrNxgLLA7USfxVXL63eMiINZpaslrlwbY5JmnS44AGGMhYILKuk9BWa/OvRg dvKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=sVL72IEnASGUFIun+CE72v94BxJjKdJ1NDcm7LwViSw=; b=E/B2Akw6y3/DxTraXuqhCtapWmG3nmtcxZwX5zS5E1GaIC7cMuD7m5cUAgG1kzLonT /wA+HeapyUqXZAslYyiJrwRyaXcV7PlyWJLfl/ZOH5EvukibwClNaOk2FT59F/0F5Cp/ 6vDIH1DfiI5xNUxSKUz558Yttrj+2Wpbk+D9VtEVP4yLrZ1dwG6WWblleW2aldf9PAAG aB9FzNgSTDRuVLP6ehN5N213tnkJo3FwQb6rta5Bo1bMbCGWEz4WUlhMVa4veGpn4Q66 BUnSvcU7J61AePCFX/el013lWdfVgby03ZKL7CfpdqwmWY78piLZEWwnKCBlXHDM8Tyj rheg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=dL3ngCsL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v26si2039584edd.364.2019.10.25.12.19.39; Fri, 25 Oct 2019 12:20:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=dL3ngCsL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390385AbfJYCjK (ORCPT + 99 others); Thu, 24 Oct 2019 22:39:10 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:41440 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728416AbfJYCjJ (ORCPT ); Thu, 24 Oct 2019 22:39:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=sVL72IEnASGUFIun+CE72v94BxJjKdJ1NDcm7LwViSw=; b=dL3ngCsLRac53SA2YNqk+ZHSH5 /c+2xQjru/wv3o1K9PFWtdRc+BJWDT9L7Fm9GRiDQAvV8vRB45MnBE750UHjij1PwEf5tBSG6e2l6 /Tg+3oFNXeFsCALow9InwXg4UdprbSzoxL9wjNSbCrnjbAmFmgmARliJ5PP9Jt0n/5Lce4uHz3Jyw CiSgP7n/s3xVb/xPTWpl4uXywI0WOyvsRKTMCzYi1sYssZ9fSAOxRKrbVtReTgSMO3XPm5SSlBtRO lMWsTttycMSw5WoLF9mldBrdK2PQgzz2zsjxcXDnBh3fA7M1eejwnHXPwp/77YQh95XZdnWeMrKi/ ZuW4lIFA==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1iNpVM-0003py-Ui; Fri, 25 Oct 2019 02:39:08 +0000 Date: Thu, 24 Oct 2019 19:39:08 -0700 From: Christoph Hellwig To: Michal =?iso-8859-1?Q?Such=E1nek?= Cc: Christoph Hellwig , linux-scsi@vger.kernel.org, Jonathan Corbet , Jens Axboe , "James E.J. Bottomley" , "Martin K. Petersen" , Alexander Viro , Mauro Carvalho Chehab , Eric Biggers , "J. Bruce Fields" , Benjamin Coddington , Hannes Reinecke , Omar Sandoval , Ming Lei , Damien Le Moal , Bart Van Assche , Tejun Heo , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 2/8] cdrom: factor out common open_for_* code Message-ID: <20191025023908.GB14108@infradead.org> References: <20191024021958.GA11485@infradead.org> <20191024085014.GF938@kitsune.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191024085014.GF938@kitsune.suse.cz> User-Agent: Mutt/1.12.1 (2019-06-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 24, 2019 at 10:50:14AM +0200, Michal Such?nek wrote: > Then I will get complaints I do unrelated changes and it's hard to > review. The code gets removed later anyway. If you refactor you you pretty much have a card blanche for the refactored code and the direct surroundings.