Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Peter Chen <peter.chen@nxp.com>
To:     Pawel Laszczak <pawell@cadence.com>
CC:     Roger Quadros <rogerq@ti.com>,
        "felipe.balbi@linux.intel.com" <felipe.balbi@linux.intel.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "nsekhar@ti.com" <nsekhar@ti.com>,
        Rahul Kumar <kurahul@cadence.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: cdns3: gadget: Don't manage pullups
Thread-Topic: [PATCH] usb: cdns3: gadget: Don't manage pullups
Thread-Index: AQHViYCigHhLS+QXN0CJz1D+9q4PbKdn8nSAgAK+9IA=
Date:   Fri, 25 Oct 2019 03:13:54 +0000
Message-ID: <20191025031343.GA13392@b29397-desktop>
References: <20191023090232.27237-1-rogerq@ti.com>
 <BYAPR07MB4709A6212601A75DCB1A25ACDD6B0@BYAPR07MB4709.namprd07.prod.outlook.com>
In-Reply-To: <BYAPR07MB4709A6212601A75DCB1A25ACDD6B0@BYAPR07MB4709.namprd07.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-ID: <AB5B58989835C5428788BF3A068EA261@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 6887b738-7b52-4303-e213-08d758f95e5e
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Oct 2019 03:13:54.7863
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ZHAKWQwZsGeNQMhxggBz8NfzxjcdI2/PKqTIaHVLAnlrxfJ/9PrOBfYf/EWejBFL4v1jPNIuPWuvMiQZA5rzig==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3966
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 19-10-23 09:17:45, Pawel Laszczak wrote:
> Hi,
>=20
> Reviewed-by: Pawel Laszczak <pawell@cadence.com>

Hi Roger & Pawel,

Assume gadget function has already enabled, if you switch host mode
to device mode, with your changes, where the device mode will be enabled
again?

Peter
>=20
> Regards,=20
> Pawel,=20
>=20
> >The USB gadget core is supposed to manage pullups
> >of the controller. Don't manage pullups from within
> >the controller driver. Otherwise, function drivers
> >are not able to keep the controller disconnected from
> >the bus till they are ready. (e.g. g_webcam)
> >
> >Signed-off-by: Roger Quadros <rogerq@ti.com>
> >---
> >Hi Greg/Felipe,
> >
> >This can be used for -rc as it is a bug fix.
> >
> >cheers,
> >-roger
> >
> > drivers/usb/cdns3/gadget.c | 4 ----
> > 1 file changed, 4 deletions(-)
> >
> >diff --git a/drivers/usb/cdns3/gadget.c b/drivers/usb/cdns3/gadget.c
> >index 2ca280f4c054..714382d96055 100644
> >--- a/drivers/usb/cdns3/gadget.c
> >+++ b/drivers/usb/cdns3/gadget.c
> >@@ -2324,8 +2324,6 @@ static void cdns3_gadget_config(struct cdns3_devic=
e *priv_dev)
> > 	writel(USB_CONF_CLK2OFFDS | USB_CONF_L1DS, &regs->usb_conf);
> >
> > 	cdns3_configure_dmult(priv_dev, NULL);
> >-
> >-	cdns3_gadget_pullup(&priv_dev->gadget, 1);
> > }
> >
> > /**
> >@@ -2708,8 +2706,6 @@ static int cdns3_gadget_suspend(struct cdns3 *cdns=
, bool do_wakeup)
> > 	/* disable interrupt for device */
> > 	writel(0, &priv_dev->regs->usb_ien);
> >
> >-	cdns3_gadget_pullup(&priv_dev->gadget, 0);
> >-
> > 	return 0;
> > }
> >
> >--
> >Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> >Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
>=20

--=20

Thanks,
Peter Chen=