Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 25 Oct 2019 09:39:13 +0200
From:   Jiri Olsa <jolsa@redhat.com>
To:     Hewenliang <hewenliang4@huawei.com>
Cc:     peterz@infradead.org, acme@kernel.org, mark.rutland@arm.com,
        alexander.shishkin@linux.intel.com, namhyung@kernel.org,
        ilubashe@akamai.com, ak@linux.intel.com,
        linux-kernel@vger.kernel.org, hushiyuan@huawei.com,
        linfeilong@huawei.com
Subject: Re: [PATCH] perf tools: Call closedir to release the resource before
 we return
Message-ID: <20191025073913.GC31679@krava>
References: <20191025031605.23658-1-hewenliang4@huawei.com>
MIME-Version: 1.0
In-Reply-To: <20191025031605.23658-1-hewenliang4@huawei.com>
User-Agent: Mutt/1.12.1 (2019-06-15)
Content-Type: text/plain; charset=WINDOWS-1252
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Oct 24, 2019 at 11:16:05PM -0400, Hewenliang wrote:
> We should close the directory on pattern failure before the return
> of rm_rf_depth_pat.
>=20
> Fixes: cdb6b0235f170 ("perf tools: Add pattern name checking to rm_rf")
> Signed-off-by: Hewenliang <hewenliang4@huawei.com>

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka

> ---
>  tools/perf/util/util.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>=20
> diff --git a/tools/perf/util/util.c b/tools/perf/util/util.c
> index 5eda6e19c947..1aadca8c43f3 100644
> --- a/tools/perf/util/util.c
> +++ b/tools/perf/util/util.c
> @@ -154,8 +154,10 @@ static int rm_rf_depth_pat(const char *path, int dep=
th, const char **pat)
>  =09=09if (!strcmp(d->d_name, ".") || !strcmp(d->d_name, ".."))
>  =09=09=09continue;
> =20
> -=09=09if (!match_pat(d->d_name, pat))
> +=09=09if (!match_pat(d->d_name, pat)) {
> +=09=09=09closedir(dir);
>  =09=09=09return -2;
> +=09=09}
> =20
>  =09=09scnprintf(namebuf, sizeof(namebuf), "%s/%s",
>  =09=09=09  path, d->d_name);
> --=20
> 2.19.1
>=20