Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Roman Kagan <rkagan@virtuozzo.com>
To:     Thomas Gleixner <tglx@linutronix.de>
CC:     Vitaly Kuznetsov <vkuznets@redhat.com>,
        "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>,
        "K. Y. Srinivasan" <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        Sasha Levin <sashal@kernel.org>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Michael Kelley <mikelley@microsoft.com>
Subject: Re: [PATCH] x86/hyper-v: micro-optimize send_ipi_one case
Thread-Topic: [PATCH] x86/hyper-v: micro-optimize send_ipi_one case
Thread-Index: AQHVioF8f6JnvYZ8LUKUUp53PHF9w6dp/CAAgABmQ4CAALlWgA==
Date:   Fri, 25 Oct 2019 09:41:28 +0000
Message-ID: <20191025094125.GA23240@rkaganb.sw.ru>
References: <20191024152152.25577-1-vkuznets@redhat.com>
 <20191024163204.GA4673@rkaganb.sw.ru>
 <alpine.DEB.2.21.1910250036090.1783@nanos.tec.linutronix.de>
In-Reply-To: <alpine.DEB.2.21.1910250036090.1783@nanos.tec.linutronix.de>
Accept-Language: en-US, ru-RU
Content-Language: en-US
user-agent: Mutt/1.12.1 (2019-06-15)
mail-followup-to: Roman Kagan <rkagan@virtuozzo.com>,   Thomas Gleixner
 <tglx@linutronix.de>,  Vitaly Kuznetsov <vkuznets@redhat.com>,
        "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>,      "K. Y. Srinivasan" <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>, Stephen Hemminger
 <sthemmin@microsoft.com>,      Sasha Levin <sashal@kernel.org>, Ingo Molnar
 <mingo@redhat.com>,    Borislav Petkov <bp@alien8.de>, "H. Peter Anvin"
 <hpa@zytor.com>,       Michael Kelley <mikelley@microsoft.com>
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: e6070eb6-5e61-4734-6316-08d7592f8244
x-ms-traffictypediagnostic: AM4PR0802MB2322:|AM4PR0802MB2322:|AM4PR0802MB2322:
x-microsoft-antispam-prvs: <AM4PR0802MB2322606CF355B0BCEB63C503C9650@AM4PR0802MB2322.eurprd08.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:2150;
x-forefront-prvs: 02015246A9
x-forefront-antispam-report: SFV:SPM;SFS:(10019020)(39850400004)(376002)(366004)(396003)(346002)(136003)(189003)(199004)(2906002)(6436002)(102836004)(386003)(6506007)(66556008)(66446008)(26005)(8936002)(36756003)(8676002)(81166006)(81156014)(64756008)(66476007)(66946007)(5660300002)(478600001)(446003)(71190400001)(7736002)(11346002)(71200400001)(256004)(86362001)(76176011)(66066001)(7416002)(1076003)(4326008)(99286004)(14454004)(3846002)(54906003)(476003)(6116002)(52116002)(305945005)(486006)(4744005)(229853002)(6486002)(58126008)(6246003)(6916009)(186003)(25786009)(33656002)(316002)(9686003)(6512007)(30126002);DIR:OUT;SFP:1501;SCL:5;SRVR:AM4PR0802MB2322;H:AM4PR0802MB2242.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
received-spf: None (protection.outlook.com: virtuozzo.com does not designate
 permitted sender hosts)
x-ms-exchange-transport-forked: True
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: Ik242GzpNj0pm4vSnLX3euHgLMtiZiYU+0uNFmnz5sKdOgt2GlapKje0mT7k+xIkyaWxREeIliqMLbP8BGG33QIyWk12cc+K89BW8PeOyRFIVZ5750if83BdMNNH9266cb1jRHvfSuSGjrmCEixXLLqjsTj43OZXrhDCVr0VVDUkOUdf7/t5ixrP3egFWj3Mn/ZKarqknsQsbUWaGD7FaSJNz134K9VRUa5GGnN7LZVlZnjLxgx0uZDIOZyo3zXd1lv0kKDwHd35CJEgwCZz61+nLXurjYq+5MMsbTWurM1HWlQckPn5rV+VWX9kpRvWPnTRI9WKwKd5H/3ps0Szvv5qCuBbQPDl2rwslmJrHjJgGUTn1C1b/UJOEaqPayHf0C2W3d0+EzMjMgnFMfTEaGdtXaQrwvsdx+PbGMtN71+VHymohLSeowO34rZWQuQTvuuuEDWW+Qv533C8nPn+l6g0GgtqzIf6X14enIsVhfWKSQvKCXgd8T0XDYbLd9CyWIItA6t6NFh/QomGWEcWzQ==
Content-Type: text/plain; charset="us-ascii"
Content-ID: <783196C564771B4B9EE7F464C8909E3F@eurprd08.prod.outlook.com>
MIME-Version: 1.0
X-OriginatorOrg: virtuozzo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e6070eb6-5e61-4734-6316-08d7592f8244
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Oct 2019 09:41:28.2088
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 0bc7f26d-0264-416e-a6fc-8352af79c58f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 8bQQ+KgNlsz3E21TV0wC4UVPjWbHw0idW0mTIZxdpDAR8a9RpCmGJaDAkPk3ZLHkdA2aciFxrFZMEp55Lt9Etg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0802MB2322
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Oct 25, 2019 at 12:38:05AM +0200, Thomas Gleixner wrote:
> On Thu, 24 Oct 2019, Roman Kagan wrote:
> > > +
> > > +	if (cpu >= 64)
> > > +		goto do_ex_hypercall;
> > > +
> > > +	ret = hv_do_fast_hypercall16(HVCALL_SEND_IPI, vector,
> > > +				     BIT_ULL(hv_cpu_number_to_vp_number(cpu)));
> > > +	return ((ret == 0) ? true : false);
> > 
> > D'oh.  Isn't "return ret == 0;" or just "return ret;" good enough?
> 
>    'return ret == 0' != 'return ret'
> 
> !ret perhaps :)

Sure.  Time to vacuum my keyboard ;)

Thanks,
Roman.