Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 25 Oct 2019 10:55:37 +0100
From:   Mark Brown <broonie@kernel.org>
To:     vishnu <vravulap@amd.com>
Cc:     "RAVULAPATI, VISHNU VARDHAN RAO" 
        <Vishnuvardhanrao.Ravulapati@amd.com>,
        "Deucher, Alexander" <Alexander.Deucher@amd.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        "Mukunda, Vijendar" <Vijendar.Mukunda@amd.com>,
        Maruthi Bayyavarapu <maruthi.bayyavarapu@amd.com>,
        Colin Ian King <colin.king@canonical.com>,
        YueHaibing <yuehaibing@huawei.com>,
        Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
        "Mehta, Sanju" <Sanju.Mehta@amd.com>,
        "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." 
        <alsa-devel@alsa-project.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/7] ASoC: amd: Enabling I2S instance in DMA and DAI
Message-ID: <20191025095537.GB4209@sirena.co.uk>
References: <1571432760-3008-1-git-send-email-Vishnuvardhanrao.Ravulapati@amd.com>
 <1571432760-3008-3-git-send-email-Vishnuvardhanrao.Ravulapati@amd.com>
 <20191024114015.GG5207@sirena.co.uk>
 <3aed0c75-80e7-cc9d-59f9-6ef29b665efc@amd.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="tjCHc7DPkfUGtrlw"
Content-Disposition: inline
In-Reply-To: <3aed0c75-80e7-cc9d-59f9-6ef29b665efc@amd.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--tjCHc7DPkfUGtrlw
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Oct 25, 2019 at 06:53:16AM +0000, vishnu wrote:
> On 24/10/19 5:10 PM, Mark Brown wrote:
> > On Sat, Oct 19, 2019 at 02:35:41AM +0530, Ravulapati Vishnu vardhan rao=
 wrote:

> >> +		case I2S_BT_INSTANCE:
> >> +			val =3D rv_readl(rtd->acp3x_base + mmACP_BTTDM_ITER);
> >> +			val =3D val | (rtd->xfer_resolution  << 3);
> >> +			rv_writel(val, rtd->acp3x_base + mmACP_BTTDM_ITER);
> >> +		break;

> > For some reason the break; isn't indented with the rest of the block.
> > I'm fairly sure I've mentioned this before...

> Sorry for this but I am not able to find indentation.I have tested with=
=20
> scripts/checkpatch.pl. It shows no warnings.

The break should be aligned with the rest of the block like I said, an
extra tab in - you can see lots of examples of break statements in the
kernel.

--tjCHc7DPkfUGtrlw
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl2yxpgACgkQJNaLcl1U
h9D2EAf/WSOT4sEicM8hxRm4Afv0zc8QzmWWpk3kpMbsbHCyqGcZi3zLh98kr8lD
u47RPeWzylVb9VRl9y+sPxFSijyTtzN/QAbhGjEkK4hqE+q6mqsawKdKljlMdFUR
tx8E1yWONkYobWTs94EYAwP2gg6fsQs6qaUTqQWaZB2E5yvxjFsJWNoIpICxVYOR
oGFZzwW/ly8/taJtA5Q5310KIsLxmnl+HcJXQmZpRnZj3pdSUTKj3z9ukwgy9I9U
v1yBS4ghFDjZod4vkFjPEJZpScJLabIrgXFgGI/PCHvy7fkvB8Wz9IabAyfWMmVr
3kT2BFuIxxgXp2xDYxHDxFeahLzuMg==
=fpuJ
-----END PGP SIGNATURE-----

--tjCHc7DPkfUGtrlw--