Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp4079136ybg; Fri, 25 Oct 2019 13:01:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqwMU1GGtgpJ4nq9FvBqRMwIdILET8oRuHimXjkmu9+RXKon4JP4eBiJ5/Qc9ClSHc3utQy9 X-Received: by 2002:a17:906:f2d4:: with SMTP id gz20mr5154115ejb.215.1572033705466; Fri, 25 Oct 2019 13:01:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572033705; cv=none; d=google.com; s=arc-20160816; b=obVCHI0LA/xW81vCWKrNd6wNXM11IeFfxEPe+3EVN4CWhZyVwkq3bj6vEDl2jFWq2i ufi4YCSoYg/dGFPbymPWGzC3IQjlg9ZhUbaRgKWRqHKCdsnkiVxSBlUhp3to8Ja1jIPh +EnEN02SFvH2cw4TR7cqYV8dWpCsRq740yt0EK2+A395fMmOsqQUeRDXwd0kiH9X5226 VRK6IGARmORbwmvVLImRAadbHrD/sz+wyBdIqxMsBm0lsXyOicty6UfAIpZWVDZmZWdM DoOBRqsmaAWm50sUSv0FbPU7Lu2bykuqdaJqOeWHIxILTXQmYOgyaWP6Hx8r2kMB0zxK jB1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:to :from:date:dkim-signature; bh=OVCm2Qs1zv8zur/SF5/gMRMvq8CDHixNh16CKJ09A4M=; b=rJcQ4h4MrXN+/C8ahsDuELgCQ36LrZxMgrF0/8KJjN0N8KjFwIp+r1RU7akPCGlSLa edaK7QVA3rRv9GgKKRXu9qE8/5vVBYnCtduerohKhkZAHoxJAzAjJ9h30ZgqsAbDC/Uy UlX+lOLEyMRZaj/283BAZ5XjYu9w1mgOJLzh6+FfVywnjHU1DxCT0K+6EwiFFwKhMDLD I2TUX/1CeGByJl8ilyQh4YUg+m56LfySGfpdZx8F4fJGh/7yRnUUvStAqQ+TPbmlhmsQ IQMg1ZtGAMk6FJ1g0pcL4raPGFiddFNcX36iO+WY6sOnpoUrKPCaw3+pZEV5foRdkXOo 3mNA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=c0AEcHuE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h14si1439846edj.225.2019.10.25.13.01.22; Fri, 25 Oct 2019 13:01:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=c0AEcHuE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2502514AbfJYL67 (ORCPT + 99 others); Fri, 25 Oct 2019 07:58:59 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:41972 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2393497AbfJYL67 (ORCPT ); Fri, 25 Oct 2019 07:58:59 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x9PBhi8N080218; Fri, 25 Oct 2019 11:58:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2019-08-05; bh=OVCm2Qs1zv8zur/SF5/gMRMvq8CDHixNh16CKJ09A4M=; b=c0AEcHuEeFS56V1Dwq3qmcf4y8ksHyi5aTw1xw3LyGzpVWhkUPCsV7j731WYVjMoutBB L54TFh2yfbz3d4SWv8/xVtK4Hx60r3jlRsxJYaxg6cFoyMP0qx0LTL47Pzg8/9jmdxIp c6ADv73cLEBsgk1OcxBGZaKPrRuiG1uovRTqBDC/52SmB7FyQVKihCxfqTWHaL1T9TY4 Z7wnfX6w1wRGXVatp+QPMyF3tcGYCWEEzcgHqFo1MTyN7kKKViHrDGnxuaasWyJmECXa Znxv1vrvtjGC316xcHDeN9gb5ymvt/OcdKO9/aN9W2FiYChGIlWM2dN2un2rlM4/CwDg Eg== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2130.oracle.com with ESMTP id 2vqswu2ndw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 25 Oct 2019 11:58:31 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x9PBgdp3161155; Fri, 25 Oct 2019 11:58:30 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3020.oracle.com with ESMTP id 2vuun11sx6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 25 Oct 2019 11:58:30 +0000 Received: from abhmp0007.oracle.com (abhmp0007.oracle.com [141.146.116.13]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x9PBwRqZ015711; Fri, 25 Oct 2019 11:58:27 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 25 Oct 2019 04:58:26 -0700 Date: Fri, 25 Oct 2019 14:58:20 +0300 From: Dan Carpenter To: Colin King , Eric Anholt , David Airlie , Navid Emamdoost , Iago Toral Quiroga , dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] drm/v3d: fix double free of bin Message-ID: <20191025115819.GA7244@kadam> References: <20191024104801.3122-1-colin.king@canonical.com> <20191024123853.GH11828@phenom.ffwll.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191024123853.GH11828@phenom.ffwll.local> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9420 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=2 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1910250113 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9420 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1910250113 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 24, 2019 at 02:38:53PM +0200, Daniel Vetter wrote: > On Thu, Oct 24, 2019 at 11:48:01AM +0100, Colin King wrote: > > From: Colin Ian King > > > > Two different fixes have addressed the same memory leak of bin and > > this now causes a double free of bin. While the individual memory > > leak fixes are fine, both fixes together are problematic. > > > > Addresses-Coverity: ("Double free") > > Fixes: 29cd13cfd762 ("drm/v3d: Fix memory leak in v3d_submit_cl_ioctl") > > Fixes: 0d352a3a8a1f (" rm/v3d: don't leak bin job if v3d_job_init fails.") > > Signed-off-by: Colin Ian King > > That sounds like wrong merge resolution somewhere, and we don't have those > patches merged together in any final tree yet anywhere. What's this based > on? > -Daniel linux-next. I sent this fix to you and Stephen Rothwell yesterday so this one is sorted already. Stephen will apply my patch until you guys merge your drm trees. regards, dan carpenter