Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp4101449ybg; Fri, 25 Oct 2019 13:20:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqy8s804+c7smjtfIU11w9VmAhrbf76iiEnql0OSQVUdv8dZ7jEH8zrTIXeS6/ArA9S2tJM8 X-Received: by 2002:a17:906:5911:: with SMTP id h17mr5411879ejq.194.1572034845496; Fri, 25 Oct 2019 13:20:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572034845; cv=none; d=google.com; s=arc-20160816; b=ubR6WEzRlYUQc96+aXzPMjI78VaG8lHaA7rzYtiWnYf7YKapKI5srTrOse65XwZapH 7tl+14elkK6cbKEkHsp/gVU6H9m//TwrhENnSGP5AdHLU6LDaWi9siaxEPKzkcLo/EE1 UjwlglClUC2g3TxAvrbzWCZCZCygntWFg14Xt3dA98uUIyTJv7AJEkfYWmp+TbgKsc5Z SqNirueZfxSK0+bCEQWTMqT88mTOb5sPgsDAB9kU7CLQeWBjzNbH1Sgbtdj2VgrS7oTL zGDKTYnbwnF5hltKy42rSAIyYGWjAzSrakqeK3lVfblpUAlk6xExnHHNNtUx5WZvQuYQ /1HQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=sv5dF6qflHr5ZwIn8QIRu82I7QMFKoEE4TlrSi1RwOQ=; b=HinnuyNDsisTw8uNaTNya7MFe8rfMxSsae4LoZfpdzNMJNmkqPrgaxIL8dWTaWX7/K oEO5QYEO5POklkkx7PYimROpxVbAa0kv9ff1iFLCgrKsfFwkFA2zNol8JJmQZP7/0OAT sspWad1KgGfOkX3EoHQu22WxBdpwssbuLHubIHe0XdoxBhQHFrj5F4owE/fV5e4D4BIl gJZZAhQs31B5LL7rUO3rVJz4TLwvStSWshiA4dcm5gOX2WEtKl3w8j90xrXyjwzRxkXT qu7GjPdfpYgOi99pmf/jUZcuC70HzT4qSrKN5f2fXZiQ2W9t40E7oTHHCTB1L2Ew03K3 7Lvw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=meVJ1grC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t49si2119678edd.198.2019.10.25.13.20.21; Fri, 25 Oct 2019 13:20:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=meVJ1grC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2504848AbfJYNmF (ORCPT + 99 others); Fri, 25 Oct 2019 09:42:05 -0400 Received: from mail.skyhub.de ([5.9.137.197]:47344 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2504824AbfJYNmE (ORCPT ); Fri, 25 Oct 2019 09:42:04 -0400 Received: from zn.tnic (p200300EC2F0D3C00E44239D1C9BE3FA7.dip0.t-ipconnect.de [IPv6:2003:ec:2f0d:3c00:e442:39d1:c9be:3fa7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id A81211EC0CE5; Fri, 25 Oct 2019 15:41:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1572010918; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=sv5dF6qflHr5ZwIn8QIRu82I7QMFKoEE4TlrSi1RwOQ=; b=meVJ1grCo8aqtBibAed2PwgSaUG7POqonCWl4A+Rymf5qJjd0nRfGqbLEv3HixcqWwZRfL sJz16lZWDW3XrAWDR4vvIAYjOnGQYV5+KBfqAEaSB+mhabwM0Yy3txUIJkVmqzSBvrBrl/ 9L+2/qqafQz0TzdNWt5H8DJXVdUHVMA= Date: Fri, 25 Oct 2019 15:41:58 +0200 From: Borislav Petkov To: "Ghannam, Yazen" Cc: "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 6/6] EDAC/amd64: Set grain per DIMM Message-ID: <20191025134158.GB6483@zn.tnic> References: <20191022203448.13962-1-Yazen.Ghannam@amd.com> <20191022203448.13962-7-Yazen.Ghannam@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191022203448.13962-7-Yazen.Ghannam@amd.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 22, 2019 at 08:35:14PM +0000, Ghannam, Yazen wrote: > From: Yazen Ghannam > > The following commit introduced a warning on error reports without a > non-zero grain value. > > 3724ace582d9 ("EDAC/mc: Fix grain_bits calculation") > > The amd64_edac_mod module does not provide a value, so the warning will > be given on the first reported memory error. > > Set the grain per DIMM to cacheline size (64 bytes). This is the current > recommendation. > > Fixes: 3724ace582d9 ("EDAC/mc: Fix grain_bits calculation") > Signed-off-by: Yazen Ghannam > --- > Link: > https://lkml.kernel.org/r/20191018153114.39378-7-Yazen.Ghannam@amd.com > > v1 -> v2: > * No change. > > rfc -> v1: > * New patch. > > drivers/edac/amd64_edac.c | 2 ++ > 1 file changed, 2 insertions(+) This one I can take now. Applied, thanks. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette