Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Roman Kagan <rkagan@virtuozzo.com>
To:     Vitaly Kuznetsov <vkuznets@redhat.com>
CC:     "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>,
        "K. Y. Srinivasan" <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        Sasha Levin <sashal@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Michael Kelley <mikelley@microsoft.com>,
        Joe Perches <joe@perches.com>
Subject: Re: [PATCH v2] x86/hyper-v: micro-optimize send_ipi_one case
Thread-Topic: [PATCH v2] x86/hyper-v: micro-optimize send_ipi_one case
Thread-Index: AQHVizZYGDIi3UW4YkWmU3NiXuLPeqdrZBUA
Date:   Fri, 25 Oct 2019 14:05:34 +0000
Message-ID: <20191025140528.GB23240@rkaganb.sw.ru>
References: <20191025131546.18794-1-vkuznets@redhat.com>
In-Reply-To: <20191025131546.18794-1-vkuznets@redhat.com>
Accept-Language: en-US, ru-RU
Content-Language: en-US
user-agent: Mutt/1.12.1 (2019-06-15)
mail-followup-to: Roman Kagan <rkagan@virtuozzo.com>,   Vitaly Kuznetsov
 <vkuznets@redhat.com>, linux-hyperv@vger.kernel.org,
 linux-kernel@vger.kernel.org,  x86@kernel.org, "K. Y. Srinivasan"
 <kys@microsoft.com>,   Haiyang Zhang <haiyangz@microsoft.com>, Stephen
 Hemminger <sthemmin@microsoft.com>,    Sasha Levin <sashal@kernel.org>,        Thomas
 Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, Borislav
 Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,       Michael Kelley
 <mikelley@microsoft.com>,      Joe Perches <joe@perches.com>
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 9c7f713f-f0ae-4066-f730-08d759546743
x-ms-traffictypediagnostic: AM4PR0802MB2305:|AM4PR0802MB2305:|AM4PR0802MB2305:
x-microsoft-antispam-prvs: <AM4PR0802MB2305ACB8F527740BFBA40C8FC9650@AM4PR0802MB2305.eurprd08.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7691;
x-forefront-prvs: 02015246A9
x-forefront-antispam-report: SFV:SPM;SFS:(10019020)(376002)(346002)(136003)(366004)(396003)(39840400004)(189003)(199004)(25786009)(6436002)(6486002)(52116002)(6512007)(9686003)(186003)(26005)(476003)(6916009)(102836004)(11346002)(446003)(386003)(6506007)(229853002)(486006)(66946007)(478600001)(66446008)(64756008)(66556008)(66476007)(14444005)(81166006)(8676002)(81156014)(8936002)(76176011)(256004)(305945005)(7736002)(7416002)(99286004)(58126008)(316002)(71200400001)(71190400001)(6116002)(86362001)(66066001)(3846002)(2906002)(33656002)(5660300002)(4326008)(1076003)(4744005)(6246003)(14454004)(54906003)(36756003)(30126002);DIR:OUT;SFP:1501;SCL:5;SRVR:AM4PR0802MB2305;H:AM4PR0802MB2242.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
received-spf: None (protection.outlook.com: virtuozzo.com does not designate
 permitted sender hosts)
x-ms-exchange-transport-forked: True
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 8pd8kFQkHqtKZKOvPSqIYz4JlrN0v97YFj/WKQVwk5y2PCvgvkzXVkFG4WwPcbO79f1Lu2SiECdPuadYhSEo33GyTLy/pjn5F0mAYjw+fnu9rQFlG3rzQ2dz5WN8TEVRAqrUlaDA7uMHnJ7tpJx0uCVMYc+3RAD0xrWVEs8Pz4ygmX7vn+GnEdNkHiyJB+flE5j1DtWZq364U4Mf65NKNx/D2pHVooKaf1BXRu8phI5tUB4mwVGSlearY90A8VrOoHVGGN7vfl7xwuwedSRWf7iwEZIBh410YIUt8bEaZM2k3ceb/YrCk4ahGFCbmOkEHpvawMynCsR4MgxVxb5/mHr5Yp83IOeAHFFfXHWdL3JLS2lFbMB5k4Yih2seVqybn6tFXnuZhEFNOs7G7yCWO2ucmRK79rRXQmjgFPB8g7JLYmsJjPBVxKQdHUgrctptQ3EDDiwsmLzPffoRfanCC/2z4aOv1rZdGgPfuCFRIMazCmU1Bhop25CdCNCz7XrA8y9OBCBcytvcED7ES6mKwg==
Content-Type: text/plain; charset="us-ascii"
Content-ID: <7910855E4302C34FB54E12C5C8111618@eurprd08.prod.outlook.com>
MIME-Version: 1.0
X-OriginatorOrg: virtuozzo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9c7f713f-f0ae-4066-f730-08d759546743
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Oct 2019 14:05:34.3785
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 0bc7f26d-0264-416e-a6fc-8352af79c58f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: iFCAnhKManmWYXAW1ARwqbi7ni1EVTlvJ+JfDcDjTBmCvyohSSEIYZZ0APM0rm7dSOVHEuCRpX1jq1kT5kULHA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0802MB2305
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Oct 25, 2019 at 03:15:46PM +0200, Vitaly Kuznetsov wrote:
> When sending an IPI to a single CPU there is no need to deal with cpumasks.
> With 2 CPU guest on WS2019 I'm seeing a minor (like 3%, 8043 -> 7761 CPU
> cycles) improvement with smp_call_function_single() loop benchmark. The
> optimization, however, is tiny and straitforward. Also, send_ipi_one() is
> important for PV spinlock kick.
> 
> I was also wondering if it would make sense to switch to using regular
> APIC IPI send for CPU > 64 case but no, it is twice as expesive (12650 CPU
> cycles for __send_ipi_mask_ex() call, 26000 for orig_apic.send_IPI(cpu,
> vector)).
> 
> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> ---
> Changes since v1:
>  - Style changes [Roman, Joe]
> ---
>  arch/x86/hyperv/hv_apic.c           | 13 ++++++++++---
>  arch/x86/include/asm/trace/hyperv.h | 15 +++++++++++++++
>  2 files changed, 25 insertions(+), 3 deletions(-)

Reviewed-by: Roman Kagan <rkagan@virtuozzo.com>