Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp4122432ybg; Fri, 25 Oct 2019 13:41:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqy9VW+lcQqbVBQy7qlAMQaHv7U/RUdg6s3lsUsvHeF5tPwkKt4wPMsFD/0J508AMnmDL3Oc X-Received: by 2002:a17:906:2599:: with SMTP id m25mr1054727ejb.227.1572036068498; Fri, 25 Oct 2019 13:41:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572036068; cv=none; d=google.com; s=arc-20160816; b=L5Cl49Uugyjxu024KXy4OC89+ZXnM8W3rE9QDkE6qw9DNfL1xeFCXKMqG3VetVXrVH 4EDmplsEh16sB8Wns5A9MZePJr/uWZxfKAgeO5OozMzi21Lg9L40JSL0bXB5m8xVz8vs PHf7UI2fiA6+ULiCxlpapxqOGwS2877rdGc3F3kvdYLZG4oAqxFU9EAVofc2Cyl6um6X yaTR4HyN3MfjO1xkt+0Nj8XQzNsdN1soK8WlgHgsXaaq9FCjsdgtBxlQw+S1LCMBTT7K fV7lFVKPmDbDQJ9GBIfNVAyXH7Ys85pBDkZRM2+wnX8y6zmFuusYlOK8b8L2vlt74X8h i49Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=aF6JPZTJ/gBdIJwVCjuZWdvm5qo4nqf8GBjBjU4VHfM=; b=yU8kxSDDDRDwyUYh/18YDJKfR57J98CQiYZXSzAg/ou3zJQbtapWDDSOvAk2aM0Vpo p00GpSjVH7fimmpTK0BkgOQw2Fi4UxsSqZGJahMAK7LDvAxOBBo6F7qT/o2nA/xb6Vig hVvmfpMJeTq20Ex/2HwkEm4uzTcnksJAWpojVu64tYIvi8sFztoUrU364mEoy4wb27I2 qG2brmJWHIKh2eNUFAEFFchh6uMjoL9Nj3zkpGSTcIN2afuFpC0nj5by6Y66XsuKKAEQ A/6AkFLk8+DAh01RRCEamuo7v+G3CvABdr5m14U1MnNRZV3qvRNVFzjGYjcxAiT/emPD KTzQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=KhSrz89G; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z31si2032410ede.236.2019.10.25.13.40.35; Fri, 25 Oct 2019 13:41:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=KhSrz89G; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2440530AbfJYO4Y (ORCPT + 99 others); Fri, 25 Oct 2019 10:56:24 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:35222 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2440507AbfJYO4X (ORCPT ); Fri, 25 Oct 2019 10:56:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=aF6JPZTJ/gBdIJwVCjuZWdvm5qo4nqf8GBjBjU4VHfM=; b=KhSrz89GlOX23Pdcc/m/CEld3 js2tGCBFwjdMJJ34KizZkriCuEs4NYx5Ro5d1rNJ46rh8JBbTBv6pFyOMal5DlyU5GMO4Y0rIho2S bxS3FKE8dzctMQEiLrCHnnYT5RqBoJcg0csb+wB6zSoSWXrJOd9CcxKeM9J0iHNnbCQFg=; Received: from host86-174-61-171.range86-174.btcentralplus.com ([86.174.61.171] helo=fitzroy.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iO10k-00075b-CM; Fri, 25 Oct 2019 14:56:18 +0000 Received: by fitzroy.sirena.org.uk (Postfix, from userid 1000) id B0C42D020AD; Fri, 25 Oct 2019 15:56:17 +0100 (BST) Date: Fri, 25 Oct 2019 15:56:17 +0100 From: Mark Brown To: Lee Jones Cc: daniel.thompson@linaro.org, arnd@arndb.de, linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, baohua@kernel.org, stephan@gerhold.net Subject: Re: [PATCH v3 10/10] mfd: mfd-core: Move pdev->mfd_cell creation back into mfd_add_device() Message-ID: <20191025145617.GI4568@sirena.org.uk> References: <20191024163832.31326-1-lee.jones@linaro.org> <20191024163832.31326-11-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="NzX0AQGjRQPusK/O" Content-Disposition: inline In-Reply-To: <20191024163832.31326-11-lee.jones@linaro.org> X-Cookie: Keep out of the sunlight. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --NzX0AQGjRQPusK/O Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Oct 24, 2019 at 05:38:32PM +0100, Lee Jones wrote: > Most of the complexity of mfd_platform_add_cell() has been removed. The > only functionality left duplicates cell memory into the child's platform > device. Since it's only a few lines, moving it to the main thread and > removing the superfluous function makes sense. Reviewed-by: Mark Brown --NzX0AQGjRQPusK/O Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl2zDRAACgkQJNaLcl1U h9DO/Af/VagCkEQfGNe1Ncjxx+a7IFEhDSC4yzx8fMlWxETMK9yPwOBSBkR89NQZ pzaIK3X35Zh9LM/H8ptRf7FeKzJ8BeO3j0ck1uCAcJrvT3O4vzso8kdC1jwVQ/O0 hHd/+39lnnDfsP3OhZjMtAGu9EZy9klwIrHmj7PKXtJ2Cn3jXUlb4qUSBujNtEHY TXtxGhUrHPpJBEjchkG/36VYbRhG241EBxxPriQ5vRC5dm4YIbdpkeiYLQhB0Js2 tYQPsXSkGg7flTuGEtPZMhKXHt2TnzzKPmUcK3R4ikyCvO8Lt9g6VDIUiaeRM+jS wb1JBPSFwuy5dYVsQ9L1Til/GDq6Aw== =LFpK -----END PGP SIGNATURE----- --NzX0AQGjRQPusK/O--