Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH liburing 1/1] test/defer: Test deferring with drain and
 links
To:     Pavel Begunkov <asml.silence@gmail.com>,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
References: <b9509294fde6425b000d71613bd352059334c60d.1571995330.git.asml.silence@gmail.com>
 <3d2e8533-6085-b328-7e27-9a5be2027b7f@kernel.dk>
 <9ec359eb-b639-65a5-4f01-7e7fdfa9a8af@gmail.com>
From:   Jens Axboe <axboe@kernel.dk>
Message-ID: <7a2af956-e96f-a24c-2afe-806789a7fae2@kernel.dk>
Date:   Fri, 25 Oct 2019 09:47:08 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <9ec359eb-b639-65a5-4f01-7e7fdfa9a8af@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 10/25/19 9:40 AM, Pavel Begunkov wrote:
> On 25/10/2019 18:13, Jens Axboe wrote:
>> On 10/25/19 3:48 AM, Pavel Begunkov (Silence) wrote:
>>> From: Pavel Begunkov <asml.silence@gmail.com>
>>>
>>> 1. test user_data integrity with cancelled links
>>> 2. test the whole link is cancelled by sq_thread
>>> 3. hunging io_uring based on koverflow and kdropped
>>>
>>> Be aware, that this test may leave unkillable user process, or
>>> unstopped actively polling kthread.
>>
>> That's fine, that's what the test suite is for! Thanks, applied.
> 
> Just found it "a bit uncomfortable", that after several runs
> my CPU was doing nothing but polling in vain.

Looks like it's testing one of the cases that isn't fixed that. We
shouldn't do that until a known fix is available, at least. Basically
the tests should test for things that used to be a problem, but are
now fixed.

But let's just get it fixed :-)

-- 
Jens Axboe