Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <7869bb43-5cb1-270a-07d1-31574595e13e@huawei.com>
 <16e0170d878.280e.85c95baa4474aabc7814e68940a78392@paul-moore.com> <a700333e-53b8-1a28-b27d-2ba3f612df2a@huawei.com>
In-Reply-To: <a700333e-53b8-1a28-b27d-2ba3f612df2a@huawei.com>
From:   Paul Moore <paul@paul-moore.com>
Date:   Fri, 25 Oct 2019 11:54:58 -0400
Message-ID: <CAHC9VhRfEkPCC-T1W2AOD2FTkUD4Z=BT=R+-kF+=Rejv9fyWOw@mail.gmail.com>
Subject: Re: [PATCH] audit: remove redundant condition check in kauditd_thread()
To:     Yunfeng Ye <yeyunfeng@huawei.com>
Cc:     Eric Paris <eparis@redhat.com>, linux-audit@redhat.com,
        linux-kernel@vger.kernel.org, hushiyuan@huawei.com,
        linfeilong@huawei.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Oct 25, 2019 at 3:14 AM Yunfeng Ye <yeyunfeng@huawei.com> wrote:
> On 2019/10/25 13:43, Paul Moore wrote:
> > On October 23, 2019 3:27:50 PM Yunfeng Ye <yeyunfeng@huawei.com> wrote:
> >> Warning is found by the code analysis tool:
> >>  "the condition 'if(ac && rc < 0)' is redundant: ac"
> >>
> >>
> >> The @ac variable has been checked before. It can't be a null pointer
> >> here, so remove the redundant condition check.
> >>
> >>
> >> Signed-off-by: Yunfeng Ye <yeyunfeng@huawei.com>
> >> ---
> >> kernel/audit.c | 4 ++--
> >> 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > Hello,
> >
> > Thank you for the patch.  Looking quickly at it, it appears to be correct, unfortunately I'm not in a position to merge non-critical patches, but I expect to merge this next week.
> >
> ok, thanks.

I was able to find some time today to take a closer look and it still
looks good to me so I've merge it into audit/next - thanks!

-- 
paul moore
www.paul-moore.com