Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp4124089ybg; Fri, 25 Oct 2019 13:42:47 -0700 (PDT) X-Google-Smtp-Source: APXvYqyJcGIkR6otNU3x48xCGtQyYiUsAKU/iHe0iRWGOZ+QLCctMFc1Q0EtNSdm1NeVPkJosInW X-Received: by 2002:a17:906:e296:: with SMTP id gg22mr5490087ejb.211.1572036167000; Fri, 25 Oct 2019 13:42:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572036166; cv=none; d=google.com; s=arc-20160816; b=l+p3kbS8ERVOZmpobu/CNqAHYq0n3Cm8qFj39hkOlVRmDYauOy2aarWxGSmi1RXEay RZTDe14suzWpt3aqSaDYNpeCnH/mL7xoD9i1Gg/3PmKOGfpzz8r2iO9mJUWa2kIjrA74 3Iab6roQHHVMMjmAvvq9SL/vaNydikcF03iHe4SxzI3FM2WePeXddPBKrzXd+GegaR2A +knQtPMPRg8pxSaSx0IndDT4Ep2AJpk0UIyEM9H6lvWA7LY7yyEiD6B0jOI6n0ylKHnu AU4DF6xRWUbLR3bucXFMuOA202aFt8jM8EoCLg+w9AVwpB+i7ai8U8BphJMMlPEh7k2u qRDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=VlfRIm/IUQoWr2pXkJdNPTQB7pso0Fzi7iIhyuUYMCY=; b=sVTCy+DPimDgrzixQy8bS/EM7h1OBihfPWzQKP4dcyQI0wNxCgyUQWgKOM9cxggURe /fgZGfA/PxiTorrIRr89jZHew8F4ShFsvRd+x5xOHN/FQ1QA1uWRcBLzOq2YaRYaCZBA VVzqKz6FOSksV6t+AiJ/TIIKNyKE1css+QF0E3i9sULHKfvvEl5UVkCgH9TywwLCA31U hNhKKeu+ZQW3jSbxnx0qmNvLo17SXbiMybXdZ7ZadFUMCE4sCVNckGZ+CNH8vvZyU0T/ XD/z6C5rAvPSWxDBBF8d0F2oI4c7bOldPxdBa6i40ZRiUdE/T9ftNQJxoKc1bn89Zimt DPbg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@shutemov-name.20150623.gappssmtp.com header.s=20150623 header.b=L75ud86K; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k13si1967868eds.194.2019.10.25.13.42.23; Fri, 25 Oct 2019 13:42:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@shutemov-name.20150623.gappssmtp.com header.s=20150623 header.b=L75ud86K; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2395397AbfJYPgW (ORCPT + 99 others); Fri, 25 Oct 2019 11:36:22 -0400 Received: from mail-lj1-f193.google.com ([209.85.208.193]:40581 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727068AbfJYPgW (ORCPT ); Fri, 25 Oct 2019 11:36:22 -0400 Received: by mail-lj1-f193.google.com with SMTP id u22so3206469lji.7 for ; Fri, 25 Oct 2019 08:36:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=VlfRIm/IUQoWr2pXkJdNPTQB7pso0Fzi7iIhyuUYMCY=; b=L75ud86KWGPHxPbqsE9fYUV589praE+7kUBzz8/hFeYfnkE8fGeAHqRdb8aN8jIm4w zwageU2OR8t7hf7+ngdaTZtqyGunHZMDWOLObCvkvSlTGjc55LsULJyClg+ttQAlqI32 pLuSMdHO/IwduciZYA4QMk0OOMeuslnCC+VtWuqmJ6ntQHMdHyB4viEdkQ7PhNtp2e3W fclXfviKT7AjiDJ7QddXszNO6UWj2BCAzJQFg+vFW6ZKUz5o/PrYPFOCggvaLqeniVjp m7Pf3AW42s/vOFU0xM8h8oA+pYErBikv9SL3yl4hol4RbFGyh1714xhDJ/iWhHxm2uj3 cn1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=VlfRIm/IUQoWr2pXkJdNPTQB7pso0Fzi7iIhyuUYMCY=; b=t/1xKY22z0lP5TI1s0wugZPjLVbLxCejnUg76FHnvNk7T/evPlZsY8ED79OXMcy5Uu riPuFUZcLsZpQKglaenGaIKGfSS0DewCGxQ9v+FRpjzgLw8JhXqt8M7qRIi1jF6T+/Fy jjDbT7ptFHVaooZRUkrwh/p9MrWp0ksh5fbfGXaIW1T6ZXx+kP2LHX0XW7cFf/wz28aY htJd10FX5UEIJNhg3v4uLJHLFbIVf4CqY6QSz07yR8RFlryQhCCOzvl0zRbgG19MyEEN b3l5iGy3x4n7qWXx1BtN3IFTHNryWSo88qr347rOg3fdZO1YT39ytFJnOEWvo7TP7zBk iL0w== X-Gm-Message-State: APjAAAXCc06M8TqulEz7OFxdmI2EqffVUaa8jrX6CK7QEXT/XRw6hK5+ ZPoHF5fxyDmsxbWhNzuKLKIE6A== X-Received: by 2002:a2e:4e12:: with SMTP id c18mr3037222ljb.51.1572017780299; Fri, 25 Oct 2019 08:36:20 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id b6sm1066987lfi.72.2019.10.25.08.36.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Oct 2019 08:36:19 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id 04DB810267F; Fri, 25 Oct 2019 18:36:19 +0300 (+03) Date: Fri, 25 Oct 2019 18:36:18 +0300 From: "Kirill A. Shutemov" To: Yang Shi Cc: hughd@google.com, kirill.shutemov@linux.intel.com, aarcange@redhat.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: thp: clear PageDoubleMap flag when the last PMD map gone Message-ID: <20191025153618.ajcecye3bjm5abax@box> References: <1571938066-29031-1-git-send-email-yang.shi@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1571938066-29031-1-git-send-email-yang.shi@linux.alibaba.com> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 25, 2019 at 01:27:46AM +0800, Yang Shi wrote: > File THP sets PageDoubleMap flag when the first it gets PTE mapped, but > the flag is never cleared until the THP is freed. This result in > unbalanced state although it is not a big deal. > > Clear the flag when the last compound_mapcount is gone. It should be > cleared when all the PTE maps are gone (become PMD mapped only) as well, > but this needs check all subpage's _mapcount every time any subpage's > rmap is removed, the overhead may be not worth. The anonymous THP also > just clears PageDoubleMap flag when the last PMD map is gone. NAK, sorry. The key difference with anon THP that file THP can be mapped again with PMD after all PMD (or all) mappings are gone. Your patch breaks the case when you map the page with PMD again while the page is still mapped with PTEs. Who would set PageDoubleMap() in this case? -- Kirill A. Shutemov