Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp4129471ybg; Fri, 25 Oct 2019 13:47:53 -0700 (PDT) X-Google-Smtp-Source: APXvYqyFKrYKoTbhssJL9j2Usj2KCFSv4cmegIwGh6t/LZ0GYXVkE7J8SkTEPkC48XWyFJ9hbrNd X-Received: by 2002:aa7:c48c:: with SMTP id m12mr6303937edq.152.1572036472933; Fri, 25 Oct 2019 13:47:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572036472; cv=none; d=google.com; s=arc-20160816; b=X87HjQAdrWGEYAoxIy7YXO3eCU0t2remeXdTSvPQZisvH1lcWNzV/zvEVw4BRQ6HJI qu1iy0Jkz/5/MyODD64KHz7lPTMm0qwsiszHvdrPXNDepmqdCdL8Y7J5yOXkanX53fvN bBA7avgg/WD1EGkT/D88+JUA/OCGlLkM86amTKtqEu7EFtzMh5Mw6HRxeSxkptFMuUzm wPpNeqrr6PVwrQAgy8eOz5Nq/1AIu0jw6VDptHXUMcKnicrLyiXVqvGV/stZfg0nIEoX j3NOdbY19WUwuGxYQQnTjKrdS76E2ilgJi+hcTsWpulo5ey/MyDdRHciNlNFe/spV8cW L8DQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=/za/eHCc5YOxno3F960dEsfMKhLfXOAXTv/vlKJMoEE=; b=oMK9Uwi62aG7av3ieH5FjhiCcTbrIR0OEVXeGPd2Gx5WGBLnlw/e49US3JzUhIqis7 vAtGvTkWLEb1c5v0L6AqdAqR0Vn8/rigjau0g4KShc6vtxnNTITfgyFXKcUrr4zliG/4 nfcfZKorh45Pm5tQ1zqTGDkYlS4fKMZorFR3VFQXo7wMg56CxIB9vFTiK/o0qe37bb4I Zb0fEsmpWklwYLkvLRAHD+PPKa53EW2NxtiOpYET4qOO8Ne7jOxQ82/OIH/bfqlOLI5l hT+FHdSvN1jTDHHbPEQXA93CjR+4U8b0LFyh6hAAw94MWhswecps1q9vS9V/xPT3lLF6 mbiw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=G1oGiG8O; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m90si2357934ede.52.2019.10.25.13.47.29; Fri, 25 Oct 2019 13:47:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=G1oGiG8O; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2505916AbfJYRdX (ORCPT + 99 others); Fri, 25 Oct 2019 13:33:23 -0400 Received: from mail-il1-f194.google.com ([209.85.166.194]:40458 "EHLO mail-il1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2502736AbfJYRdX (ORCPT ); Fri, 25 Oct 2019 13:33:23 -0400 Received: by mail-il1-f194.google.com with SMTP id d83so2524434ilk.7 for ; Fri, 25 Oct 2019 10:33:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=/za/eHCc5YOxno3F960dEsfMKhLfXOAXTv/vlKJMoEE=; b=G1oGiG8O60afGke/KjUgd2tG/RdjqxXAI0+PdQzcUIRvQRnmMrIFdCL/v8qDg6c3CY Uml6mrI/c3Ct2PddLdPAdrlP8XOvds7Kjczg6z+MN2NjD53UMqlsGqIYqxlunNtwGZi7 gMBK+/G6/9TkEaxeOFC6MD3hqc8rUsfNvMZ08= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=/za/eHCc5YOxno3F960dEsfMKhLfXOAXTv/vlKJMoEE=; b=OblgQe+nGLfTg7PVx2i9r6rA6EYzJuIUGbzbxcUWuNe+UWvNBQtiC76FE5QTzin3F+ JDFKORLylgyH489cMGzHAHxCmthorkya9RsxdJAAkRs8ZL6kEqvpbhkxRxejXo9rXMo+ CIdrku2Ot3bBvw0TdKOLyQU/AXYhzS8wmyIoVus36P4PThybtSkdUcXKRV3PeeDOPpGg YrsOwu+fLCrSsdnJZu5FXG9UKU+Y9UygUAnVQd9ZZNM6eHHX4UcgiX4zn0MWszCt+kWr 5bAzRyYFw5sN9Q0ZGff0AdMatWsy99pgAXHOlSGdjd+1d/iMLUSrf28yplG0sCpGJLlD zphg== X-Gm-Message-State: APjAAAUouR8UHSEnJFOZUooYFfsH01AUISk9BHknmXynxetK/Ywo2Fxn nqXd57ddZdGEtRYMf4AbdVi6mw== X-Received: by 2002:a92:580d:: with SMTP id m13mr5299155ilb.117.1572024801694; Fri, 25 Oct 2019 10:33:21 -0700 (PDT) Received: from chromium.org ([2620:15c:183:200:5d69:b29f:8fd8:6f45]) by smtp.gmail.com with ESMTPSA id k3sm34224ilg.27.2019.10.25.10.33.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Oct 2019 10:33:21 -0700 (PDT) Date: Fri, 25 Oct 2019 11:33:19 -0600 From: Daniel Campello To: Nick Crews Cc: enric.balletbo@collabora.com, bleung@chromium.org, linux-leds@vger.kernel.org, jacek.anaszewski@gmail.com, pavel@ucw.cz, linux-kernel@vger.kernel.org, arnd@arndb.de, weiyongjun1@huawei.com, dlaurie@chromium.org, djkurtz@chromium.org, dtor@google.com, sjg@chromium.org, groeck@chromium.com Subject: Re: [PATCH v8 1/2] platform/chrome: wilco_ec: Add keyboard backlight LED support Message-ID: <20191025173319.GA1768@chromium.org> References: <20191024222805.183642-1-ncrews@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191024222805.183642-1-ncrews@chromium.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org LGTM. Reviewed-by: Daniel Campello