Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 25 Oct 2019 11:35:47 -0600
From:   Daniel Campello <campello@chromium.org>
To:     Nick Crews <ncrews@chromium.org>
Cc:     Enric Balletbo i Serra <enric.balletbo@collabora.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Thomas Gleixner <tglx@linutronix.de>,
        Benson Leung <bleung@chromium.org>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Duncan Laurie <dlaurie@google.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Wei Yongjun <weiyongjun1@huawei.com>
Subject: Re: [PATCH v6] platform/chrome: wilco_ec: Add Wilco EC keyboard
 backlight LEDs support
Message-ID: <20191025173547.GB1768@chromium.org>
References: <20191018120830.1.Id856c69b1fda0a9b2248218ea0cfb6919aa1cb0d@changeid>
 <3c8c22a0-db91-354f-d9b9-ef0d9b80641f@collabora.com>
 <CAHX4x86+1dNkGHUDvYcC_OhSyTPRcg8UJLAZKCdjmnwVWDOC+A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAHX4x86+1dNkGHUDvYcC_OhSyTPRcg8UJLAZKCdjmnwVWDOC+A@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Thanks Nick for taking care of this. I just reviewed your patch
in the other thread. Also, thanks Enric for your comments.

Thanks again.
Daniel

On Thu, Oct 24, 2019 at 04:18:07PM -0600, Nick Crews wrote:
> Thanks for getting this going again Daniel. This version of
> the patch is fairly old, and after so long I've found some
> things about it that I don't like, even though I wrote it
> originally :). One of the main things was how complicated it
> was, and how there was duplicated code in core.c and the
> kbd_backlight_leds.c.
>
> Therefore, I just sent a newer version of this that simplifies
> things greatly, and addresses the feedback that Enric just gave.
> Check for that patch (it's paired with another unrelated one)
> and see what you think.
>
> Cheers,
> Nick
>
> On Thu, Oct 24, 2019 at 3:54 AM Enric Balletbo i Serra
> <enric.balletbo@collabora.com> wrote:
> >
> > Hi Daniel,
> >
> > Some few comments, mostly nits. In general I'm fine with it.
> >
> > Thanks,
> >  Enric