Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp4135977ybg; Fri, 25 Oct 2019 13:54:54 -0700 (PDT) X-Google-Smtp-Source: APXvYqyEJAoBAH9XS5Qnfhm+rsyNSBMq5FytUlcfmbDI6vVWuuNgFy8UXH/F3OZ75bMUPoIeqOrw X-Received: by 2002:a17:906:19cf:: with SMTP id h15mr5540102ejd.184.1572036894566; Fri, 25 Oct 2019 13:54:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572036894; cv=none; d=google.com; s=arc-20160816; b=F1ynX51DO+ssoNboGQaKRnTZePLTkKZZwKKPeMtJC+aJEzPyuHd//3YPUkQPnlapeI mfhmkDqf5jRPE5wjtm30nDN7Di/nTwT8bDAzZxJ3DYqjMGcyBVlimkSDMnctbxTmAZ5q /Z8QvExQuLQz5F5kM5Ze/t6w5u/6T9pZ7zc+IiCdj7wBzfebVCmRqDyE8WB/9J9u4e4J K00pZQwNZFcO3Wn16PC+V1qgdTY6XWolBdaS2VrkSLHey0piZ6t9NLFhiWZg/hMFNAiR /kgIjU6++CWWsBi6ppXKxYo0cEI9eJhbZu/tFIoYsNHz85b1P/5FS55Ieqt0jKlezoX6 Ywfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=caqZS73ujV6Zdyymag8M26Wcqn5G2+KweE+j+HquELA=; b=cgrv9oaaF6TYwtQdN04vigNrmbRFdg1zbKVx8TqJeYiL5FSGO6ek+JAej9mzdQqCaK 1maaYVTQTIWl2eU51CyLd8nPzwv0oDKZhNrH5TfXMisw5lV7VBbXzwEZ1jxlEy0fMZUU O2StI62Pp9QJV8Nf2A8Ra1HOfecmax+XoUegXROLNT/YQ9JRHZkAmp0S3jDy4EpQ5YHm HO+DQc5otBSeGG2mj4ELBKnhJlobmrbijMkrswueQprxr1tBFrJXAd+6r3KNhOHpvtbv nWG1rQM7PIhnKC9mHNUIh2DCqkR2xWP3cddekYycbNca7fTue/k2f3DohpFTBSbpP1Ll vI/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=b4EDArzn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r10si1964131edh.358.2019.10.25.13.54.31; Fri, 25 Oct 2019 13:54:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=b4EDArzn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726939AbfJYTSd (ORCPT + 99 others); Fri, 25 Oct 2019 15:18:33 -0400 Received: from mail-ot1-f66.google.com ([209.85.210.66]:43031 "EHLO mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725783AbfJYTSd (ORCPT ); Fri, 25 Oct 2019 15:18:33 -0400 Received: by mail-ot1-f66.google.com with SMTP id b19so450314otq.10 for ; Fri, 25 Oct 2019 12:18:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=caqZS73ujV6Zdyymag8M26Wcqn5G2+KweE+j+HquELA=; b=b4EDArznp02keGtvfHllt+4DNwPB/wY2U4iXZgPoBpUBy8JsPeH4Qmg4aCBwc6NoZI ROfGAR3pXNQolhTlvEZNPiHhNH2bsdtOAfFz3jSVdFsDyUAJnt1KcP//X/ufZs+uHGQR mUz7uQkpYvQ7dgGjREk0laFRoO9N3Z+3on59o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=caqZS73ujV6Zdyymag8M26Wcqn5G2+KweE+j+HquELA=; b=QOQlw33YQppnnoELT+dnluhs9Dcwao8OkYAdWvOb9rQk97FKKcz0jrRt+ba2oaSJGz NqQCEU525mLsan+FJI4h+wKB08QldqDUBjDCStiCnY/LYIU4IBkpXlLUiDSPf56awAJG QikjautzqA0/7rBM1S6dXnFB1PioNDnK2Vou9iAr0JXyOdloO+aONHHU39njSGPd6AZb dXwvy6F8lUam4uF1jLa5rRWYDKECJFKHY12kX7zqUHY/rqDKEdZhujQxJquh9ZjrdT5c 1OYbP8NfX9fLrbwGGgfmChQ4IJ6xgJ8Ha+HNdWuM42WpQ07TDa18wY1hY85z4kLYa3TY yI4w== X-Gm-Message-State: APjAAAVfQfbe3Y5QG4JHcQ6UJ2HV5lNDVwBtYy+0gIitjrM0HLziwwil r4FvKuHDpRrlgol2iIRBhwSX+IiWeI0= X-Received: by 2002:a9d:6043:: with SMTP id v3mr3936833otj.6.1572031112168; Fri, 25 Oct 2019 12:18:32 -0700 (PDT) Received: from mail-ot1-f42.google.com (mail-ot1-f42.google.com. [209.85.210.42]) by smtp.gmail.com with ESMTPSA id n27sm980319otr.32.2019.10.25.12.18.31 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Oct 2019 12:18:31 -0700 (PDT) Received: by mail-ot1-f42.google.com with SMTP id b16so2783760otk.9 for ; Fri, 25 Oct 2019 12:18:31 -0700 (PDT) X-Received: by 2002:a05:6830:1147:: with SMTP id x7mr330026otq.349.1572031110654; Fri, 25 Oct 2019 12:18:30 -0700 (PDT) MIME-Version: 1.0 References: <20191024222805.183642-1-ncrews@chromium.org> <20191025173319.GA1768@chromium.org> In-Reply-To: <20191025173319.GA1768@chromium.org> From: Nick Crews Date: Fri, 25 Oct 2019 13:18:18 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v8 1/2] platform/chrome: wilco_ec: Add keyboard backlight LED support To: Daniel Campello Cc: Enric Balletbo i Serra , Benson Leung , linux-leds@vger.kernel.org, Jacek Anaszewski , Pavel Machek , linux-kernel , Arnd Bergmann , Wei Yongjun , Duncan Laurie , Daniel Kurtz , Dmitry Torokhov , Simon Glass , groeck@chromium.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 25, 2019 at 11:33 AM Daniel Campello wrote: > > LGTM. > Reviewed-by: Daniel Campello